From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6ECDAC433E0 for ; Wed, 10 Feb 2021 21:03:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECCC864ED0 for ; Wed, 10 Feb 2021 21:03:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ECCC864ED0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l9wdV-0007Jq-RS for qemu-devel@archiver.kernel.org; Wed, 10 Feb 2021 16:02:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41182) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9wX1-0004UQ-2H; Wed, 10 Feb 2021 15:56:15 -0500 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:54515) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l9wWz-0006Ig-Jk; Wed, 10 Feb 2021 15:56:14 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C0A105C01B9; Wed, 10 Feb 2021 15:56:11 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 10 Feb 2021 15:56:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=GokTOU8lAhjm/lFKNL21gwX/1dF ecWCh+6bxhAkpL58=; b=gVI3Z7P9F9bbJbTCITM5PSZ6EmlOuEoJE00VwQ62gS0 SP0QPcNRMYOwiN216uWyFnGAJAYO1ShV8O/BOphkFOiNRoRnnWHoJunbmox3B9pj 7aYrDidut8FhELWF/ulr102lw8EsAFag3xOpqPm4uZ3a8G9DCjEl4VpfmalPPVAp BZlkmNcg1CNm6a+5nBu9Q51vOF2Ntu8h01umQ6aizi+DhmjAiqr8Zl+8YMopHTNH JlwyVZKiOVdXweDfIAxsSBpkOPQu1KSk3O9mlV7F+QYoW8nMFv34IVMLKmcrbOAa 1OtNGGxoDgj3WJ6L+RTOhbCFdQKJYmwvFJtzqQBSP5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=GokTOU 8lAhjm/lFKNL21gwX/1dFecWCh+6bxhAkpL58=; b=TGNnktK+WHnuAuYFa5Gwjo 3KSZIClNZsqLKMADcT9fVXE5YclpHyOV867wgC3r/y9vauJsY6YiG3FSXifldYa3 C/g3j41m1L4JYfsIQVurIKAC0LxBQIXArxQ6VqQJlb/anybXZ7sMoq4WO+VSozbC 3J2kVYUGs6xVEejyXgF7OuPbeLgXg6vHIQcHj5Nm1s42hl71IjVWOouN5MszbWfg MMCj3t39cXpAcjQUg21cX7hlueI1pOL0vxjaBPO6Jbu0ZmkdC+mS8keoIOYZPr7y z3HKNWVua0TKiStOEFR2DS/B0fftxUfz8qDMXgwSfY3eKHwvDqmf5QXkiIe8zDIw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrheejgddufeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeejgeduffeuieetkeeileekvdeuleetveejudeileduffefjeegfffhuddvudff keenucfkphepkedtrdduieejrdelkedrudeltdenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 169C21080064; Wed, 10 Feb 2021 15:56:06 -0500 (EST) Date: Wed, 10 Feb 2021 21:56:05 +0100 From: Klaus Jensen To: qemu-devel@nongnu.org Subject: Re: [PATCH] hw/block/nvme: improve invalid zasl value reporting Message-ID: References: <20210208082532.308435-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mViZ5GneWlMw3a30" Content-Disposition: inline In-Reply-To: <20210208082532.308435-1-its@irrelevant.dk> Received-SPF: pass client-ip=66.111.4.26; envelope-from=its@irrelevant.dk; helo=out2-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, Dmitry Fomichev , Klaus Jensen , Max Reitz , Keith Busch , "info@dantalion.nl" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --mViZ5GneWlMw3a30 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Feb 8 09:25, Klaus Jensen wrote: > From: Klaus Jensen >=20 > The Zone Append Size Limit (ZASL) must be at least 4096 bytes, so > improve the user experience by adding an early parameter check in > nvme_check_constraints. >=20 > When ZASL is still too small due to the host configuring the device for > an even larger page size, convert the trace point in nvme_start_ctrl to > an NVME_GUEST_ERR such that this is logged by QEMU instead of only > traced. >=20 Thanks for the review; applied to nvme-next! --mViZ5GneWlMw3a30 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmAkSGQACgkQTeGvMW1P Deno6wf/Q0DyIRm4UPFy6Q8Ohtzxy9OsfRRmw8/+yz+l07eiA5nkaWHwVu4lT7oT 42ta0h60tDRx5Faq6c/tNjZuWVVxByyQYUrKVTZREtBCQe7lbPx1JecTl+XvDo61 qkj52b4kCf9e2t/DArT7Zb/gr7e59IUgvuXuugBGqybfFuSepGfSRIpjVOImxD9C zPeDxYIyvlaBjBQEqktIJ1Ip+BfKBKFCgvpifN+8lDcC2DjyrO76PiQF7K1h4Oxc GAtISt+h5++jAIKlvjAsnVR0glWuilWwxdHTubKs5LBYg4u0w2E8OIXVyn3sgFmI rf9W4T9rmAqZTaGuUzZJBm4pWpPDvA== =Mjep -----END PGP SIGNATURE----- --mViZ5GneWlMw3a30--