From: Klaus Jensen <its@irrelevant.dk>
To: Minwoo Im <minwoo.im.dev@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH 2/2] hw/nvme: move device-scoped functions
Date: Thu, 11 Feb 2021 08:27:50 +0100 [thread overview]
Message-ID: <YCTcdnp1zs5+fIAj@apples.localdomain> (raw)
In-Reply-To: <20210211025500.GC24885@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
On Feb 11 11:55, Minwoo Im wrote:
> On 21-02-09 12:08:26, Klaus Jensen wrote:
> > From: Klaus Jensen <k.jensen@samsung.com>
> >
> > Move a bunch of functions that are internal to a device out of the
> > shared header.
>
> May I ask why? I think some kind of these helpers can stick onto the
> header.
I just thought they were cluttering up the header for no good reason
when they dont really need to be exported to the individual devices.
Especially since I consolidated the header files.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-02-11 7:32 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-09 11:08 [PATCH 0/2] hw/nvme: move nvme emulation out of hw/block Klaus Jensen
2021-02-09 11:08 ` [PATCH 1/2] " Klaus Jensen
2021-02-11 2:52 ` Minwoo Im
2021-02-09 11:08 ` [PATCH 2/2] hw/nvme: move device-scoped functions Klaus Jensen
2021-02-11 2:55 ` Minwoo Im
2021-02-11 7:27 ` Klaus Jensen [this message]
2021-02-23 10:54 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCTcdnp1zs5+fIAj@apples.localdomain \
--to=its@irrelevant.dk \
--cc=k.jensen@samsung.com \
--cc=kbusch@kernel.org \
--cc=kwolf@redhat.com \
--cc=minwoo.im.dev@gmail.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.