All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lorenzo Bianconi <lorenzo@kernel.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: shayne.chen@mediatek.com, linux-wireless@vger.kernel.org
Subject: Re: [bug report] mt76: mt7915: add support for continuous tx in testmode
Date: Thu, 11 Feb 2021 10:01:23 +0100	[thread overview]
Message-ID: <YCTyY2GProMYGluQ@lore-desk> (raw)
In-Reply-To: <YCO+SaK0nJvCG5J5@mwanda>

[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]

> Hello Shayne Chen,

Hi Dan,

right. I will post a fix soon.

Regards,
Lorenzo

> 
> The patch 3f0caa3cbf94: "mt76: mt7915: add support for continuous tx
> in testmode" from Jan 5, 2021, leads to the following static checker
> warning:
> 
> 	drivers/net/wireless/mediatek/mt76/mt7915/testmode.c:597 mt7915_tm_set_tx_cont()
> 	error: uninitialized symbol 'mode'.
> 
> drivers/net/wireless/mediatek/mt76/mt7915/testmode.c
>    583                  break;
>    584          case MT76_TM_TX_MODE_HE_EXT_SU:
>    585                  mode = MT_PHY_TYPE_HE_EXT_SU;
>    586                  break;
>    587          case MT76_TM_TX_MODE_HE_TB:
>    588                  mode = MT_PHY_TYPE_HE_TB;
>    589                  break;
>    590          case MT76_TM_TX_MODE_HE_MU:
>    591                  mode = MT_PHY_TYPE_HE_MU;
>    592                  break;
>    593          default:
> 
> "mode" is uninitialized on the default path.
> 
>    594                  break;
>    595          }
>    596  
>    597          rateval =  mode << 6 | rate_idx;
>                            ^^^^^^^^^
> 
>    598          tx_cont->rateval = cpu_to_le16(rateval);
>    599  
>    600  out:
>    601          if (!en) {
>    602                  int ret;
>    603  
> 
> regards,
> dan carpenter

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

      reply	other threads:[~2021-02-11  9:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 11:06 [bug report] mt76: mt7915: add support for continuous tx in testmode Dan Carpenter
2021-02-11  9:01 ` Lorenzo Bianconi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCTyY2GProMYGluQ@lore-desk \
    --to=lorenzo@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=shayne.chen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.