From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B0942C433E0 for ; Fri, 12 Feb 2021 10:12:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D8F164E65 for ; Fri, 12 Feb 2021 10:12:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230152AbhBLKML (ORCPT ); Fri, 12 Feb 2021 05:12:11 -0500 Received: from mx2.suse.de ([195.135.220.15]:44622 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229948AbhBLKLx (ORCPT ); Fri, 12 Feb 2021 05:11:53 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1613124666; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=oyySMBM6VdigTL9j5eqbCLhS/R0Ql/YiJi2owvKug4w=; b=BjrSeaVaW2gwYyzIRdDR/cKkRycWDBgXGXAhbgQ/wu5fwnF611jaqJ8gXXYm988rn4e0NS pOEyQdBawm4RRlD0BZ6JEzYBwge0pg7f6atRTzR79Av9IaAauY4g+k+Srsak3akTEYDS5R qLY44RJdi7RynByaatgsbf1tFg5l6Xg= Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 7B24CB807; Fri, 12 Feb 2021 10:11:06 +0000 (UTC) Date: Fri, 12 Feb 2021 11:11:05 +0100 From: Michal Hocko To: David Hildenbrand Cc: Mike Rapoport , Andrew Morton , Andrea Arcangeli , Baoquan He , Borislav Petkov , Chris Wilson , "H. Peter Anvin" , Ingo Molnar , Linus Torvalds , =?utf-8?Q?=C5=81ukasz?= Majczak , Mel Gorman , Mike Rapoport , Qian Cai , "Sarvela, Tomi P" , Thomas Gleixner , Vlastimil Babka , linux-kernel@vger.kernel.org, linux-mm@kvack.org, stable@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v5 1/1] mm: refactor initialization of struct page for holes in memory layout Message-ID: References: <20210208110820.6269-1-rppt@kernel.org> <5dccbc93-f260-7f14-23bc-6dee2dff6c13@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri 12-02-21 10:56:19, David Hildenbrand wrote: > On 12.02.21 10:55, David Hildenbrand wrote: > > On 08.02.21 12:08, Mike Rapoport wrote: [...] > > > @@ -6519,8 +6581,19 @@ void __init get_pfn_range_for_nid(unsigned int nid, > > > *end_pfn = max(*end_pfn, this_end_pfn); > > > } > > > - if (*start_pfn == -1UL) > > > + if (*start_pfn == -1UL) { > > > *start_pfn = 0; > > > + return; > > > + } > > > + > > > +#ifdef CONFIG_SPARSEMEM > > > + /* > > > + * Sections in the memory map may not match actual populated > > > + * memory, extend the node span to cover the entire section. > > > + */ > > > + *start_pfn = round_down(*start_pfn, PAGES_PER_SECTION); > > > + *end_pfn = round_up(*end_pfn, PAGES_PER_SECTION); > > > > Does that mean that we might create overlapping zones when one node > > s/overlapping zones/overlapping nodes/ I didn't get to review the patch yet. Just wanted to note that we can interleave nodes/zone. Or what kind of concern do you have in mind? -- Michal Hocko SUSE Labs