All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Saravana Kannan <saravanak@google.com>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Android Kernel Team <kernel-team@android.com>,
	netdev <netdev@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Jon Hunter <jonathanh@nvidia.com>
Subject: Re: phy_attach_direct()'s use of device_bind_driver()
Date: Fri, 12 Feb 2021 15:04:50 +0100	[thread overview]
Message-ID: <YCaLAtsdV3BmbsGe@lunn.ch> (raw)
In-Reply-To: <CAGETcx9gS7oq65nU9nHicMU6NXN8L=z9zuuEuEDMjtLUYyOoVg@mail.gmail.com>

> So the plan to fix this warning is, when device_bind_driver() is called:
> 1. Delete all device links from the device (in this case, the PHY) to
> suppliers that haven't probed yet because there's no probe function
> that can defer at this point.

Just because it currently does not happen, does not mean it couldn't
happen in the future. What are the implications of removing the links?


> 2. Then call the usual device link status update code so that it
> updates the status of the remaining device links correctly. This will
> avoid the warning.
> 
> This seems like a generic solution that works for PHY and for any
> device that is force bound.

I don't know if there is any other case in the kernel where a fallback
driver is force bound on a device. But i agree this should be
generic. And hidden away in the drive core, with maybe a new call?

	 Andrew

  reply	other threads:[~2021-02-12 14:06 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-10 22:13 phy_attach_direct()'s use of device_bind_driver() Saravana Kannan
2021-02-10 22:40 ` Heiner Kallweit
2021-02-10 22:52 ` Andrew Lunn
2021-02-10 23:29   ` Saravana Kannan
2021-02-11  7:31     ` Heiner Kallweit
2021-02-11  8:57       ` Saravana Kannan
2021-02-11  9:29         ` Heiner Kallweit
2021-02-11 13:57         ` Andrew Lunn
2021-02-12  3:42           ` Saravana Kannan
2021-02-12 14:04             ` Andrew Lunn [this message]
2021-02-10 22:56 ` Andrew Lunn
2021-02-11 10:21   ` Jon Hunter
2021-02-11 14:03     ` Andrew Lunn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCaLAtsdV3BmbsGe@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=jonathanh@nvidia.com \
    --cc=kernel-team@android.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=saravanak@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.