From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB4D0C433DB for ; Fri, 12 Feb 2021 14:42:15 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3586364DDF for ; Fri, 12 Feb 2021 14:42:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3586364DDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:59996 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lAZeA-0003Yi-3Y for qemu-devel@archiver.kernel.org; Fri, 12 Feb 2021 09:42:14 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:34144) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lAZch-0002V4-9Y for qemu-devel@nongnu.org; Fri, 12 Feb 2021 09:40:43 -0500 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:34446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lAZcd-0001yG-9X for qemu-devel@nongnu.org; Fri, 12 Feb 2021 09:40:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1613140836; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SuVsU7pojW7S48jHOx0pST86uvysNSACHN9SQg5bwhI=; b=ZAhLUmEiKn87sFQFyjIOe2ef5AyoavS0ieGy24R+ygPJZH0ro+uJ2VeRojmf22ZWxZ5fNd PYmqMkky/AGolfMh4Q8hIhrJUHVVCb0kQaKItF6DdVeSfFcUrAaqIQq4CwQt++rQto/yF4 GFL8OI6i8XPZKusiCnTk3uehLcNNgYI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-506-igS48ofOPKeayybYuuY3xw-1; Fri, 12 Feb 2021 09:40:35 -0500 X-MC-Unique: igS48ofOPKeayybYuuY3xw-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 19F98801962; Fri, 12 Feb 2021 14:40:34 +0000 (UTC) Received: from localhost (ovpn-113-71.ams2.redhat.com [10.36.113.71]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 944415D735; Fri, 12 Feb 2021 14:40:26 +0000 (UTC) Date: Fri, 12 Feb 2021 15:40:24 +0100 From: Jens Freimann To: Laurent Vivier Subject: Re: [PATCH v3 3/4] failover: really display a warning when the primary device is not found Message-ID: References: <20210212135250.2738750-1-lvivier@redhat.com> <20210212135250.2738750-4-lvivier@redhat.com> MIME-Version: 1.0 In-Reply-To: <20210212135250.2738750-4-lvivier@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jfreimann@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=jfreimann@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -33 X-Spam_score: -3.4 X-Spam_bar: --- X-Spam_report: (-3.4 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.569, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: alex.williamson@redhat.com, "Michael S. Tsirkin" , qemu-trivial@nongnu.org, Jason Wang , quintela@redhat.com, Michael Tokarev , Laurent Vivier , qemu-devel@nongnu.org, zhengxiang9@huawei.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Fri, Feb 12, 2021 at 02:52:49PM +0100, Laurent Vivier wrote: >In failover_add_primary(), we search the id of the failover device by >scanning the list of the devices in the opts list to find a device with >a failover_pair_id equals to the id of the virtio-net device. > >If the failover_pair_id is not found, QEMU ignores the primary >device silently (which also means it will not be hidden and >it will be enabled directly at boot). > >After that, we search the id in the opts list to do a qdev_device_add() >with it. The device will be always found as otherwise we had exited >before, and thus the warning is never displayed. > >Fix that by moving the error report to the first exit condition. >Also add a g_assert() to be sure the compiler will not complain >about a possibly NULL pointer. > >Signed-off-by: Laurent Vivier >--- > hw/net/virtio-net.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) > Thank you Laurent! Reviewed-by: Jens Freimann regards, Jens