From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Kees Cook <keescook@chromium.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
stable@vger.kernel.org
Subject: Re: [PATCH] lkdtm: don't move ctors to .rodata
Date: Sun, 14 Feb 2021 18:16:29 +0100 [thread overview]
Message-ID: <YCla7cNQxBoG2KCr@kroah.com> (raw)
In-Reply-To: <161306959090.1254594.16358795480052823449@swboyd.mtv.corp.google.com>
On Thu, Feb 11, 2021 at 10:53:10AM -0800, Stephen Boyd wrote:
> Quoting Greg Kroah-Hartman (2021-02-11 06:23:10)
> > On Wed, Feb 10, 2021 at 04:36:08PM -0800, Stephen Boyd wrote:
> > > Quoting Greg Kroah-Hartman (2020-12-09 06:51:33)
> > > > On Tue, Dec 08, 2020 at 01:20:56PM -0800, Kees Cook wrote:
> > > > > On Mon, Dec 07, 2020 at 05:05:33PM +0000, Mark Rutland wrote:
> > > > > > [ 0.969110] Code: 00000003 00000000 00000000 00000000 (00000000)
> > > > > > [ 0.970815] ---[ end trace b5339784e20d015c ]---
> > > > > >
> > > > > > Signed-off-by: Mark Rutland <mark.rutland@arm.com>
> > > > >
> > > > > Oh, eek. Why was a ctor generated at all? But yes, this looks good.
> > > > > Greg, can you pick this up please?
> > > > >
> > > > > Acked-by: Kees Cook <keescook@chromium.org>
> > > >
> > > > Now picked up, thanks.
> > > >
> > >
> > > Can this be backported to 5.4 and 5.10 stable trees? I just ran across
> > > this trying to use kasan on 5.4 with lkdtm and it blows up early. This
> > > patch applies on 5.4 cleanly but doesn't compile because it's missing
> > > noinstr. Here's a version of the patch that introduces noinstr on 5.4.97
> > > so this patch can be picked to 5.4 stable trees.
> >
> > Why 5.10? This showed up in 5.8, so how would it be needed there?
> >
>
> Sorry for the confusion. Can commit 655389666643 ("vmlinux.lds.h: Create
> section for protection against instrumentation") and commit 3f618ab33234
> ("lkdtm: don't move ctors to .rodata") be backported to 5.4.y and only
> commit 3f618ab3323407ee4c6a6734a37eb6e9663ebfb9 be backported to 5.10.y?
655389666643 ("vmlinux.lds.h: Create section for protection against
instrumentation") does not apply cleanly to 5.4.y, so can you provide a
working backport for both of those patches to 5.4.y that you have
tested?
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-14 17:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 17:05 [PATCH] lkdtm: don't move ctors to .rodata Mark Rutland
2020-12-08 21:20 ` Kees Cook
2020-12-09 14:51 ` Greg Kroah-Hartman
2021-02-11 0:36 ` Stephen Boyd
2021-02-11 14:23 ` Greg Kroah-Hartman
2021-02-11 18:53 ` Stephen Boyd
2021-02-14 17:16 ` Greg Kroah-Hartman [this message]
2021-02-14 20:41 ` Stephen Boyd
2021-02-14 22:32 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCla7cNQxBoG2KCr@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=stable@vger.kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.