From: Al Viro <viro@zeniv.linux.org.uk>
To: Jens Axboe <axboe@kernel.dk>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC] namei: don't drop link paths acquired under LOOKUP_RCU
Date: Sun, 14 Feb 2021 22:57:51 +0000 [thread overview]
Message-ID: <YCmq75pc0bHInDGP@zeniv-ca.linux.org.uk> (raw)
In-Reply-To: <0699912b-84ae-39d5-6b2e-8cb04eaa3939@kernel.dk>
On Sun, Feb 14, 2021 at 09:45:39AM -0700, Jens Axboe wrote:
> >> +out3:
> >> + nd->depth = 0; // as we hadn't gotten to legitimize_links()
> >> out2:
> >> nd->path.mnt = NULL;
> >> out1:
> >
> > Alternatively, we could use the fact that legitimize_links() is not
> > called anywhere other than these two places and have LOOKUP_CACHED
> > checked there. As in
>
> Both fix the issue for me, just tested them. The second one seems
> cleaner to me, would probably be nice to have a comment on that in
> either the two callers or at least in legitimize_links() though.
Hmm... Do you have anything on top of that branch? If you do, there's
no way to avoid leaving bisect hazard; if not, I'd rather fold a fix
into the broken commit...
next prev parent reply other threads:[~2021-02-14 22:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-07 20:26 [PATCH RFC] namei: don't drop link paths acquired under LOOKUP_RCU Jens Axboe
2021-02-14 16:05 ` Al Viro
2021-02-14 16:40 ` Al Viro
2021-02-14 16:45 ` Jens Axboe
2021-02-14 22:57 ` Al Viro [this message]
2021-02-15 3:31 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCmq75pc0bHInDGP@zeniv-ca.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=axboe@kernel.dk \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.