From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7245AC433DB for ; Sun, 14 Feb 2021 23:00:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3D3B364DB1 for ; Sun, 14 Feb 2021 23:00:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229945AbhBNXAn (ORCPT ); Sun, 14 Feb 2021 18:00:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229793AbhBNXAl (ORCPT ); Sun, 14 Feb 2021 18:00:41 -0500 Received: from zeniv-ca.linux.org.uk (zeniv-ca.linux.org.uk [IPv6:2607:5300:60:148a::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 82BE8C061574 for ; Sun, 14 Feb 2021 15:00:01 -0800 (PST) Received: from viro by zeniv-ca.linux.org.uk with local (Exim 4.94 #2 (Red Hat Linux)) id 1lBQMp-00E2jt-1p; Sun, 14 Feb 2021 22:59:51 +0000 Date: Sun, 14 Feb 2021 22:59:51 +0000 From: Al Viro To: Randy Dunlap Cc: kernel test robot , kbuild-all@lists.01.org, linux-kernel@vger.kernel.org Subject: Re: arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' Message-ID: References: <202102120715.fQ8OSFnI-lkp@intel.com> <8b064ade-ccc2-909f-5ef9-ca8287212049@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b064ade-ccc2-909f-5ef9-ca8287212049@infradead.org> Sender: Al Viro Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 11, 2021 at 06:52:36PM -0800, Randy Dunlap wrote: > >>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' [-Werror=missing-prototypes] > > 328 | csum_and_copy_from_user(const void __user *src, void *dst, int len, > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototype for 'csum_partial_copy_nocheck' [-Werror=missing-prototypes] > > 375 | csum_partial_copy_nocheck(const void *src, void *dst, int len, __wsum sum) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > cc1: all warnings being treated as errors > > I can't reproduce this (wrong version of gcc) but it looks like adding > #include > to arch/alpha/lib/csum_partial_copy.c should fix the warnings. I'd rather go with net/checksum.h; converting all includes outside of net/checksum.h itself would have to wait, but let's not breed more of those without a good reason... From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============8127454283069741451==" MIME-Version: 1.0 From: Al Viro To: kbuild-all@lists.01.org Subject: Re: arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototype for 'csum_and_copy_from_user' Date: Sun, 14 Feb 2021 22:59:51 +0000 Message-ID: In-Reply-To: <8b064ade-ccc2-909f-5ef9-ca8287212049@infradead.org> List-Id: --===============8127454283069741451== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable On Thu, Feb 11, 2021 at 06:52:36PM -0800, Randy Dunlap wrote: > >>> arch/alpha/lib/csum_partial_copy.c:328:1: error: no previous prototyp= e for 'csum_and_copy_from_user' [-Werror=3Dmissing-prototypes] > > 328 | csum_and_copy_from_user(const void __user *src, void *dst, i= nt len, > > | ^~~~~~~~~~~~~~~~~~~~~~~ > > arch/alpha/lib/csum_partial_copy.c:375:1: error: no previous prototy= pe for 'csum_partial_copy_nocheck' [-Werror=3Dmissing-prototypes] > > 375 | csum_partial_copy_nocheck(const void *src, void *dst, int le= n, __wsum sum) > > | ^~~~~~~~~~~~~~~~~~~~~~~~~ > > cc1: all warnings being treated as errors > = > I can't reproduce this (wrong version of gcc) but it looks like adding > #include > to arch/alpha/lib/csum_partial_copy.c should fix the warnings. I'd rather go with net/checksum.h; converting all includes outside of net/checksum.h itself would have to wait, but let's not breed more of those without a good reason... --===============8127454283069741451==--