All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Shunsuke Nakamura <nakamura.shun@jp.fujitsu.com>
Cc: john.garry@huawei.com, will@kernel.org,
	mathieu.poirier@linaro.org, leo.yan@linaro.org,
	peterz@infradead.org, mingo@redhat.com, acme@kernel.org,
	mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
	namhyung@kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/3] perf tools: Add lexical definition of event name
Date: Mon, 15 Feb 2021 13:34:30 +0100	[thread overview]
Message-ID: <YCpqVuneU+wWtmMC@krava> (raw)
In-Reply-To: <20210212090318.1522292-3-nakamura.shun@jp.fujitsu.com>

On Fri, Feb 12, 2021 at 06:03:17PM +0900, Shunsuke Nakamura wrote:
> Add the lexical definition of event name so that the numbers are recognizable.
> 
> A64FX defines an event name that starts with a number.
>  - 0inst_commit
>  - 1inst_commit
>  - 2inst_commit
>  - 3inst_commit
>  - 4inst_commit
> 
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
> ---
>  tools/perf/util/parse-events.l | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 0b36285a9435..33f627187415 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -205,7 +205,7 @@ bpf_source	[^,{}]+\.c[a-zA-Z0-9._]*
>  num_dec		[0-9]+
>  num_hex		0x[a-fA-F0-9]+
>  num_raw_hex	[a-fA-F0-9]+
> -name		[a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]*
> +name		[a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]*

I can't see anything broken because of this change,
also numbers are defined few lines before so we should
be fine

but please add test for this to tests/parse-events.c,
if you could also add test for 'VALUE:VALUE' event,
that'd be fantastic ;-)

thanks,
jirka

>  name_tag	[\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\']
>  name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?.:]*
>  drv_cfg_term	[a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)?
> -- 
> 2.25.1
> 


WARNING: multiple messages have this Message-ID (diff)
From: Jiri Olsa <jolsa@redhat.com>
To: Shunsuke Nakamura <nakamura.shun@jp.fujitsu.com>
Cc: mark.rutland@arm.com, mathieu.poirier@linaro.org,
	peterz@infradead.org, john.garry@huawei.com,
	linux-kernel@vger.kernel.org, acme@kernel.org,
	alexander.shishkin@linux.intel.com, mingo@redhat.com,
	leo.yan@linaro.org, namhyung@kernel.org, will@kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 2/3] perf tools: Add lexical definition of event name
Date: Mon, 15 Feb 2021 13:34:30 +0100	[thread overview]
Message-ID: <YCpqVuneU+wWtmMC@krava> (raw)
In-Reply-To: <20210212090318.1522292-3-nakamura.shun@jp.fujitsu.com>

On Fri, Feb 12, 2021 at 06:03:17PM +0900, Shunsuke Nakamura wrote:
> Add the lexical definition of event name so that the numbers are recognizable.
> 
> A64FX defines an event name that starts with a number.
>  - 0inst_commit
>  - 1inst_commit
>  - 2inst_commit
>  - 3inst_commit
>  - 4inst_commit
> 
> Signed-off-by: Shunsuke Nakamura <nakamura.shun@fujitsu.com>
> ---
>  tools/perf/util/parse-events.l | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/parse-events.l b/tools/perf/util/parse-events.l
> index 0b36285a9435..33f627187415 100644
> --- a/tools/perf/util/parse-events.l
> +++ b/tools/perf/util/parse-events.l
> @@ -205,7 +205,7 @@ bpf_source	[^,{}]+\.c[a-zA-Z0-9._]*
>  num_dec		[0-9]+
>  num_hex		0x[a-fA-F0-9]+
>  num_raw_hex	[a-fA-F0-9]+
> -name		[a-zA-Z_*?\[\]][a-zA-Z0-9_*?.\[\]]*
> +name		[a-zA-Z0-9_*?\[\]][a-zA-Z0-9_*?.\[\]]*

I can't see anything broken because of this change,
also numbers are defined few lines before so we should
be fine

but please add test for this to tests/parse-events.c,
if you could also add test for 'VALUE:VALUE' event,
that'd be fantastic ;-)

thanks,
jirka

>  name_tag	[\'][a-zA-Z_*?\[\]][a-zA-Z0-9_*?\-,\.\[\]:=]*[\']
>  name_minus	[a-zA-Z_*?][a-zA-Z0-9\-_*?.:]*
>  drv_cfg_term	[a-zA-Z0-9_\.]+(=[a-zA-Z0-9_*?\.:]+)?
> -- 
> 2.25.1
> 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2021-02-15 12:36 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-12  9:03 [PATCH v6 0/3] perf vendor events: Support PMU events for A64FX Shunsuke Nakamura
2021-02-12  9:03 ` Shunsuke Nakamura
2021-02-12  9:03 ` [PATCH v6 1/3] perf vendor events arm64: Add more common and uarch events Shunsuke Nakamura
2021-02-12  9:03   ` Shunsuke Nakamura
2021-02-12  9:03 ` [PATCH v6 2/3] perf tools: Add lexical definition of event name Shunsuke Nakamura
2021-02-12  9:03   ` Shunsuke Nakamura
2021-02-12  9:53   ` John Garry
2021-02-12  9:53     ` John Garry
2021-02-15 12:34   ` Jiri Olsa [this message]
2021-02-15 12:34     ` Jiri Olsa
2021-02-16  8:23     ` Namhyung Kim
2021-02-16  8:23       ` Namhyung Kim
2021-02-16 11:13       ` Jiri Olsa
2021-02-16 11:13         ` Jiri Olsa
2021-02-12  9:03 ` [PATCH v6 3/3] perf vendor events arm64: Add Fujitsu A64FX pmu event Shunsuke Nakamura
2021-02-12  9:03   ` Shunsuke Nakamura
2021-02-12  9:52   ` John Garry
2021-02-12  9:52     ` John Garry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCpqVuneU+wWtmMC@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=john.garry@huawei.com \
    --cc=leo.yan@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathieu.poirier@linaro.org \
    --cc=mingo@redhat.com \
    --cc=nakamura.shun@jp.fujitsu.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.