From: Dan Carpenter <dan.carpenter@oracle.com> To: Jani Nikula <jani.nikula@linux.intel.com>, Chris Wilson <chris@chris-wilson.co.uk> Cc: kernel-janitors@vger.kernel.org, "David Airlie" <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, "Thomas Hellström" <thomas.hellstrom@intel.com> Subject: [PATCH] drm/i915/selftest: Fix an error code in mock_context_barrier() Date: Mon, 15 Feb 2021 15:58:27 +0000 [thread overview] Message-ID: <YCqaI95UW9L7Mg/L@mwanda> (raw) In-Reply-To: <20200714141216.GA314989@mwanda> If the igt_request_alloc() call fails then this should return a negative error code, but currently it returns success. Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c index d3f87dc4eda3..c30b583522ca 100644 --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c @@ -1942,6 +1942,7 @@ static int mock_context_barrier(void *arg) rq = igt_request_alloc(ctx, i915->gt.engine[RCS0]); if (IS_ERR(rq)) { pr_err("Request allocation failed!\n"); + err = PTR_ERR(rq); goto out; } i915_request_add(rq); -- 2.30.0
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com> To: Jani Nikula <jani.nikula@linux.intel.com>, Chris Wilson <chris@chris-wilson.co.uk> Cc: kernel-janitors@vger.kernel.org, "David Airlie" <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, "Thomas Hellström" <thomas.hellstrom@intel.com> Subject: [Intel-gfx] [PATCH] drm/i915/selftest: Fix an error code in mock_context_barrier() Date: Mon, 15 Feb 2021 18:58:27 +0300 [thread overview] Message-ID: <YCqaI95UW9L7Mg/L@mwanda> (raw) If the igt_request_alloc() call fails then this should return a negative error code, but currently it returns success. Fixes: 85fddf0b0027 ("drm/i915: Introduce a context barrier callback") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> --- drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c index d3f87dc4eda3..c30b583522ca 100644 --- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c +++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_context.c @@ -1942,6 +1942,7 @@ static int mock_context_barrier(void *arg) rq = igt_request_alloc(ctx, i915->gt.engine[RCS0]); if (IS_ERR(rq)) { pr_err("Request allocation failed!\n"); + err = PTR_ERR(rq); goto out; } i915_request_add(rq); -- 2.30.0 _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-02-15 15:58 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-14 14:12 [PATCH] drm/i915/selftest: Fix an error code in live_noa_gpr() Dan Carpenter 2020-07-14 14:12 ` [Intel-gfx] " Dan Carpenter 2020-07-14 14:16 ` Lionel Landwerlin 2020-07-14 14:16 ` [Intel-gfx] " Lionel Landwerlin 2020-07-14 14:31 ` Dan Carpenter 2020-07-14 14:31 ` [Intel-gfx] " Dan Carpenter 2020-07-14 14:36 ` [PATCH v2] " Dan Carpenter 2020-07-14 14:36 ` [Intel-gfx] " Dan Carpenter 2020-07-14 14:39 ` Lionel Landwerlin 2020-07-14 14:39 ` [Intel-gfx] " Lionel Landwerlin 2020-07-14 17:15 ` Chris Wilson 2020-07-14 17:15 ` Chris Wilson 2020-07-14 18:08 ` Dan Carpenter 2020-07-14 18:08 ` Dan Carpenter 2020-07-14 18:12 ` Colin Ian King 2020-07-14 18:12 ` Colin Ian King 2020-07-14 14:52 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2020-07-14 15:18 ` [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Fix an error code in live_noa_gpr() (rev2) Patchwork 2020-07-14 17:07 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork 2021-02-15 15:58 ` Dan Carpenter [this message] 2021-02-15 15:58 ` [Intel-gfx] [PATCH] drm/i915/selftest: Fix an error code in mock_context_barrier() Dan Carpenter 2021-02-15 16:35 ` Chris Wilson 2021-02-15 18:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for " Patchwork 2021-02-15 20:32 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=YCqaI95UW9L7Mg/L@mwanda \ --to=dan.carpenter@oracle.com \ --cc=airlied@linux.ie \ --cc=chris@chris-wilson.co.uk \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=kernel-janitors@vger.kernel.org \ --cc=thomas.hellstrom@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.