All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH v2 2/2] close_range02: Add simpler test and Check invalid params
Date: Tue, 16 Feb 2021 08:59:01 +0100	[thread overview]
Message-ID: <YCt7RUD/PeRkupr7@pevik> (raw)
In-Reply-To: <20210216074748.6873-2-rpalethorpe@suse.com>

Hi Richard,

> This adds some coverage for invalid parameters and a min fd above or
> on the limits. There is also some overlap with close_range01, but this
> test is simpler and has less requirements.

> Signed-off-by: Richard Palethorpe <rpalethorpe@suse.com>
> Reviewed-by: Petr Vorel <pvorel@suse.cz>
> ---

> V2: Try Closing the path file descriptor at the end if it was opened
>     to prevent hitting the FD limit with -i

Thanks! And yes, using close_range() is much better than plain close().

Waiting little longer for feedback before merging.

Kind regards,
Petr

  reply	other threads:[~2021-02-16  7:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  7:47 [LTP] [PATCH v2 1/2] close_range01: Drop CAP_SYS_ADMIN Richard Palethorpe
2021-02-16  7:47 ` [LTP] [PATCH v2 2/2] close_range02: Add simpler test and Check invalid params Richard Palethorpe
2021-02-16  7:59   ` Petr Vorel [this message]
2021-02-16  9:43   ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCt7RUD/PeRkupr7@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.