All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Du Cheng <ducheng2@gmail.com>
Cc: Manish Chopra <manishc@marvell.com>,
	devel@driverdev.osuosl.org, netdev@vger.kernel.org
Subject: Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c
Date: Tue, 16 Feb 2021 10:20:45 +0100	[thread overview]
Message-ID: <YCuObcmHwjqD52WN@kroah.com> (raw)
In-Reply-To: <20210216085326.178912-1-ducheng2@gmail.com>

On Tue, Feb 16, 2021 at 04:53:26PM +0800, Du Cheng wrote:
> align * in block comments on each line
> 
> changes v3:
> - add SUBSYSTEM in subject line
> - add explanation to past version of this patch
> 
> changes v2:
> - move closing of comment to the same line
> 
> changes v1:
> - align * in block comments

These "changes" should all go below the --- line, right?

And the subject shoudl be a bit more specific, look at how other commits
are done for this driver.  Something like:
	Subject: staging: qlge: fix comment style in qlge_main.c
matches much better, and conveys what is actually happening here, right?

v4 please?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Du Cheng <ducheng2@gmail.com>
Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org,
	Manish Chopra <manishc@marvell.com>
Subject: Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c
Date: Tue, 16 Feb 2021 10:20:45 +0100	[thread overview]
Message-ID: <YCuObcmHwjqD52WN@kroah.com> (raw)
In-Reply-To: <20210216085326.178912-1-ducheng2@gmail.com>

On Tue, Feb 16, 2021 at 04:53:26PM +0800, Du Cheng wrote:
> align * in block comments on each line
> 
> changes v3:
> - add SUBSYSTEM in subject line
> - add explanation to past version of this patch
> 
> changes v2:
> - move closing of comment to the same line
> 
> changes v1:
> - align * in block comments

These "changes" should all go below the --- line, right?

And the subject shoudl be a bit more specific, look at how other commits
are done for this driver.  Something like:
	Subject: staging: qlge: fix comment style in qlge_main.c
matches much better, and conveys what is actually happening here, right?

v4 please?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  parent reply	other threads:[~2021-02-16  9:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16  8:53 [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c Du Cheng
2021-02-16  8:53 ` Du Cheng
2021-02-16  9:20 ` Heiner Kallweit
2021-02-16  9:20   ` Heiner Kallweit
2021-02-16  9:35   ` Dan Carpenter
2021-02-16  9:35     ` Dan Carpenter
2021-02-16  9:20 ` Greg Kroah-Hartman [this message]
2021-02-16  9:20   ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCuObcmHwjqD52WN@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=ducheng2@gmail.com \
    --cc=manishc@marvell.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.