From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FA66C433DB for ; Tue, 16 Feb 2021 09:21:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 43E7F64DDA for ; Tue, 16 Feb 2021 09:21:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229802AbhBPJVa (ORCPT ); Tue, 16 Feb 2021 04:21:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:49684 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229676AbhBPJV3 (ORCPT ); Tue, 16 Feb 2021 04:21:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D176A64DA1; Tue, 16 Feb 2021 09:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613467248; bh=USVFaCTkHfp8hMrALvrjKjIQ9V+wGTJWnh0rlC+Gikg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OneRb18Tb6rgJW0FjlnMLlSnCn/CB4dBfj49T0iecMER4ZNzJJ53vzaoDMCpWIpgK 23zFRBo2sMFCkBfe2R3dp6ZdqtSYEhkv2eUQ4l/LYztGJBI3sRgG8m+41XiwmB9Q0z WHkXcxiNniJBYamfdqMwEmWPCZzDAcl+J8xxzwks= Date: Tue, 16 Feb 2021 10:20:45 +0100 From: Greg Kroah-Hartman To: Du Cheng Cc: Manish Chopra , devel@driverdev.osuosl.org, netdev@vger.kernel.org Subject: Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c Message-ID: References: <20210216085326.178912-1-ducheng2@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210216085326.178912-1-ducheng2@gmail.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Feb 16, 2021 at 04:53:26PM +0800, Du Cheng wrote: > align * in block comments on each line > > changes v3: > - add SUBSYSTEM in subject line > - add explanation to past version of this patch > > changes v2: > - move closing of comment to the same line > > changes v1: > - align * in block comments These "changes" should all go below the --- line, right? And the subject shoudl be a bit more specific, look at how other commits are done for this driver. Something like: Subject: staging: qlge: fix comment style in qlge_main.c matches much better, and conveys what is actually happening here, right? v4 please? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=BAYES_40,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5410DC433E0 for ; Tue, 16 Feb 2021 09:20:52 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5C4864DA3 for ; Tue, 16 Feb 2021 09:20:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5C4864DA3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id BFED787074; Tue, 16 Feb 2021 09:20:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nwCf1r7f0OZD; Tue, 16 Feb 2021 09:20:51 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 2F9B186FF9; Tue, 16 Feb 2021 09:20:51 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 95C031BF285 for ; Tue, 16 Feb 2021 09:20:49 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 89F71855A1 for ; Tue, 16 Feb 2021 09:20:49 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wi5pNJsb9289 for ; Tue, 16 Feb 2021 09:20:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id CB2608553B for ; Tue, 16 Feb 2021 09:20:48 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id D176A64DA1; Tue, 16 Feb 2021 09:20:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613467248; bh=USVFaCTkHfp8hMrALvrjKjIQ9V+wGTJWnh0rlC+Gikg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OneRb18Tb6rgJW0FjlnMLlSnCn/CB4dBfj49T0iecMER4ZNzJJ53vzaoDMCpWIpgK 23zFRBo2sMFCkBfe2R3dp6ZdqtSYEhkv2eUQ4l/LYztGJBI3sRgG8m+41XiwmB9Q0z WHkXcxiNniJBYamfdqMwEmWPCZzDAcl+J8xxzwks= Date: Tue, 16 Feb 2021 10:20:45 +0100 From: Greg Kroah-Hartman To: Du Cheng Subject: Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge_main.c Message-ID: References: <20210216085326.178912-1-ducheng2@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210216085326.178912-1-ducheng2@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, netdev@vger.kernel.org, Manish Chopra Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Tue, Feb 16, 2021 at 04:53:26PM +0800, Du Cheng wrote: > align * in block comments on each line > > changes v3: > - add SUBSYSTEM in subject line > - add explanation to past version of this patch > > changes v2: > - move closing of comment to the same line > > changes v1: > - align * in block comments These "changes" should all go below the --- line, right? And the subject shoudl be a bit more specific, look at how other commits are done for this driver. Something like: Subject: staging: qlge: fix comment style in qlge_main.c matches much better, and conveys what is actually happening here, right? v4 please? thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel