All of lore.kernel.org
 help / color / mirror / Atom feed
* [bug report] octeontx2-af: cn10k: MAC internal loopback support
@ 2021-02-16 10:12 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-02-16 10:12 UTC (permalink / raw)
  To: kernel-janitors

Hello Hariprasad Kelam,

The patch 3ad3f8f93c81: "octeontx2-af: cn10k: MAC internal loopback
support" from Feb 11, 2021, leads to the following static checker
warning:

	drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:731 rvu_cgx_config_intlbk()
	error: uninitialized symbol 'cgx_id'.

drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
   723  static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)
   724  {
   725          struct mac_ops *mac_ops;
   726          u8 cgx_id, lmac_id;
                   ^^^^^^

   727  
   728          if (!is_cgx_config_permitted(rvu, pcifunc))
   729                  return -EPERM;
   730  
   731          mac_ops = get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
                                                    ^^^^^^
Uninitialized.  This code probably hasn't been tested very well.

   732  
   733          return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),
   734                                            lmac_id, en);
   735  }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [bug report] octeontx2-af: cn10k: MAC internal loopback support
@ 2021-02-16 10:12 ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-02-16 10:12 UTC (permalink / raw)
  To: hkelam; +Cc: kernel-janitors

Hello Hariprasad Kelam,

The patch 3ad3f8f93c81: "octeontx2-af: cn10k: MAC internal loopback
support" from Feb 11, 2021, leads to the following static checker
warning:

	drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:731 rvu_cgx_config_intlbk()
	error: uninitialized symbol 'cgx_id'.

drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
   723  static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)
   724  {
   725          struct mac_ops *mac_ops;
   726          u8 cgx_id, lmac_id;
                   ^^^^^^

   727  
   728          if (!is_cgx_config_permitted(rvu, pcifunc))
   729                  return -EPERM;
   730  
   731          mac_ops = get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
                                                    ^^^^^^
Uninitialized.  This code probably hasn't been tested very well.

   732  
   733          return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),
   734                                            lmac_id, en);
   735  }

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [bug report] octeontx2-af: cn10k: MAC internal loopback support
@ 2021-02-16 10:14   ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-02-16 10:14 UTC (permalink / raw)
  To: kernel-janitors

On Tue, Feb 16, 2021 at 01:12:56PM +0300, Dan Carpenter wrote:
> Hello Hariprasad Kelam,
> 
> The patch 3ad3f8f93c81: "octeontx2-af: cn10k: MAC internal loopback
> support" from Feb 11, 2021, leads to the following static checker
> warning:
> 
> 	drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:731 rvu_cgx_config_intlbk()
> 	error: uninitialized symbol 'cgx_id'.
> 
> drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
>    723  static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)
>    724  {
>    725          struct mac_ops *mac_ops;
>    726          u8 cgx_id, lmac_id;
>                    ^^^^^^
> 
>    727  
>    728          if (!is_cgx_config_permitted(rvu, pcifunc))
>    729                  return -EPERM;
>    730  
>    731          mac_ops = get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
>                                                     ^^^^^^
> Uninitialized.  This code probably hasn't been tested very well.
> 
>    732  
>    733          return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),
>    734                                            lmac_id, en);
                                                    ^^^^^^^

drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:734
rvu_cgx_config_intlbk() error: uninitialized symbol 'lmac_id'.

This isn't initialized either.

regards,
dan carpenter

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [bug report] octeontx2-af: cn10k: MAC internal loopback support
@ 2021-02-16 10:14   ` Dan Carpenter
  0 siblings, 0 replies; 4+ messages in thread
From: Dan Carpenter @ 2021-02-16 10:14 UTC (permalink / raw)
  To: hkelam; +Cc: kernel-janitors

On Tue, Feb 16, 2021 at 01:12:56PM +0300, Dan Carpenter wrote:
> Hello Hariprasad Kelam,
> 
> The patch 3ad3f8f93c81: "octeontx2-af: cn10k: MAC internal loopback
> support" from Feb 11, 2021, leads to the following static checker
> warning:
> 
> 	drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:731 rvu_cgx_config_intlbk()
> 	error: uninitialized symbol 'cgx_id'.
> 
> drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c
>    723  static int rvu_cgx_config_intlbk(struct rvu *rvu, u16 pcifunc, bool en)
>    724  {
>    725          struct mac_ops *mac_ops;
>    726          u8 cgx_id, lmac_id;
>                    ^^^^^^
> 
>    727  
>    728          if (!is_cgx_config_permitted(rvu, pcifunc))
>    729                  return -EPERM;
>    730  
>    731          mac_ops = get_mac_ops(rvu_cgx_pdata(cgx_id, rvu));
>                                                     ^^^^^^
> Uninitialized.  This code probably hasn't been tested very well.
> 
>    732  
>    733          return mac_ops->mac_lmac_intl_lbk(rvu_cgx_pdata(cgx_id, rvu),
>    734                                            lmac_id, en);
                                                    ^^^^^^^

drivers/net/ethernet/marvell/octeontx2/af/rvu_cgx.c:734
rvu_cgx_config_intlbk() error: uninitialized symbol 'lmac_id'.

This isn't initialized either.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-02-16 10:16 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-16 10:12 [bug report] octeontx2-af: cn10k: MAC internal loopback support Dan Carpenter
2021-02-16 10:12 ` Dan Carpenter
2021-02-16 10:14 ` Dan Carpenter
2021-02-16 10:14   ` Dan Carpenter

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.