From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 590ACC433DB for ; Tue, 16 Feb 2021 11:28:10 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C30C564DA5 for ; Tue, 16 Feb 2021 11:28:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C30C564DA5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 50E0A871B3; Tue, 16 Feb 2021 11:28:09 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id u04oFyDyjYBJ; Tue, 16 Feb 2021 11:28:06 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 77398871AE; Tue, 16 Feb 2021 11:28:06 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id 553491BF589 for ; Tue, 16 Feb 2021 11:28:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 518AC8577F for ; Tue, 16 Feb 2021 11:28:05 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XOAbJpUyBe2n for ; Tue, 16 Feb 2021 11:28:04 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id E5E1785742 for ; Tue, 16 Feb 2021 11:28:04 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id DA2B564DEC; Tue, 16 Feb 2021 11:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613474884; bh=Qmzh7QqnywIBB0w0xGPHUwkb0SXro3xsJLw4+9mfABE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pa2g3RpSOiuP415/PfbzWTyQIkHcNKi9Wa5pbJ71kqG8lEN08tUishIFMBfQTuAWL 2SFmZxE1atCEurhJYEMxGa5E8ad32qQ9nHWPx7trdilZ3q7WxREi7MfwKsjiyEuYym UwyJcBZD65FEO9frXgY/NpwFq3Kfy+zGwX7MNWNQ= Date: Tue, 16 Feb 2021 12:28:01 +0100 From: Greg Kroah-Hartman To: Du Cheng Subject: Re: [PATCH v2] staging: greybus: fix coding style of greybus/loopback.c Message-ID: References: <20210216111353.190238-1-ducheng2@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210216111353.190238-1-ducheng2@gmail.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Tue, Feb 16, 2021 at 07:13:53PM +0800, Du Cheng wrote: > fix macro gb_loopback_stats_attrs by wrapping its multi-line definition > inside a do {} while(0) block, in compliance to scripts/checkpatch.pl. > > Signed-off-by: Du Cheng > --- > changes v2: > * relign backslashes with tabstop=8 > * improve description and subject > > changes v1: > * fix coding style of the macro > > drivers/staging/greybus/loopback.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c > index 2471448ba42a..24b769688817 100644 > --- a/drivers/staging/greybus/loopback.c > +++ b/drivers/staging/greybus/loopback.c > @@ -163,9 +163,11 @@ static ssize_t name##_avg_show(struct device *dev, \ > static DEVICE_ATTR_RO(name##_avg) > > #define gb_loopback_stats_attrs(field) \ > +do { \ > gb_loopback_ro_stats_attr(field, min, u); \ > gb_loopback_ro_stats_attr(field, max, u); \ > - gb_loopback_ro_avg_attr(field) > + gb_loopback_ro_avg_attr(field); \ > +} while (0) > > #define gb_loopback_attr(field, type) \ > static ssize_t field##_show(struct device *dev, \ > -- > 2.27.0 Did you successfully build this change? Please do so... thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel