All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Nathan Rossi <nathan@nathanrossi.com>
Cc: netdev@vger.kernel.org, Nathan Rossi <nathan.rossi@digi.com>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] of: of_mdio: Handle properties for non-phy mdio devices
Date: Tue, 16 Feb 2021 14:06:28 +0100	[thread overview]
Message-ID: <YCvDVEvBU5wabIx7@lunn.ch> (raw)
In-Reply-To: <20210215070218.1188903-1-nathan@nathanrossi.com>

On Mon, Feb 15, 2021 at 07:02:18AM +0000, Nathan Rossi wrote:
> From: Nathan Rossi <nathan.rossi@digi.com>
> 
> The documentation for MDIO bindings describes the "broken-turn-around",
> "reset-assert-us", and "reset-deassert-us" properties such that any MDIO
> device can define them. Other MDIO devices may require these properties
> in order to correctly function on the MDIO bus.
> 
> Enable the parsing and configuration associated with these properties by
> moving the associated OF parsing to a common function
> of_mdiobus_child_parse and use it to apply these properties for both
> PHYs and other MDIO devices.

Hi Nathan

What device are you using this with?

The Marvell Switch driver does its own GPIO reset handling. It has a
better idea when a hardware reset should be applied than what the
phylib core has. It will also poll the EEPROM busy bit after a
reset. How long a pause you need after the reset depends on how full
the EEPROM is.

And i've never had problems with broken-turn-around with Marvell
switches.

Given the complexity of an Ethernet switch, it is probably better if
it handles its own reset.

     Andrew

  reply	other threads:[~2021-02-16 13:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-15  7:02 [PATCH] of: of_mdio: Handle properties for non-phy mdio devices Nathan Rossi
2021-02-16 13:06 ` Andrew Lunn [this message]
2021-02-16 17:50   ` Florian Fainelli
2021-02-16 22:57     ` Nathan Rossi
2021-02-16 23:14       ` Florian Fainelli
2021-02-17  3:19       ` Andrew Lunn
2021-02-17  4:48         ` Nathan Rossi
2021-02-17 13:25           ` Andrew Lunn
2021-02-17  4:44 ` [PATCH v2] of: of_mdio: Handle broken-turn-around " Nathan Rossi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YCvDVEvBU5wabIx7@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=nathan.rossi@digi.com \
    --cc=nathan@nathanrossi.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.