From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: corbet@lwn.net, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, rric@kernel.org,
bhelgaas@google.com, wsa@kernel.org, linux-doc@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-pci@vger.kernel.org,
kw@linux.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] PCI: Introduce pcim_alloc_irq_vectors()
Date: Tue, 16 Feb 2021 16:40:01 +0200 [thread overview]
Message-ID: <YCvZQUaTI2Jt6N4q@smile.fi.intel.com> (raw)
In-Reply-To: <20210216141810.747678-2-zhengdejin5@gmail.com>
On Tue, Feb 16, 2021 at 10:18:07PM +0800, Dejin Zheng wrote:
> Introduce pcim_alloc_irq_vectors(), a device-managed version of
> pci_alloc_irq_vectors(). Introducing this function can simplify
> the error handling path in many drivers.
> - if (dev->msi_enabled)
> - pci_disable_msi(dev);
> - if (dev->msix_enabled)
> - pci_disable_msix(dev);
> + pci_free_irq_vectors(dev);
This change deserves a line in the commit message.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2021-02-16 14:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-16 14:18 [PATCH v2 0/4] Introduce pcim_alloc_irq_vectors() Dejin Zheng
2021-02-16 14:18 ` [PATCH v2 1/4] PCI: " Dejin Zheng
2021-02-16 14:40 ` Andy Shevchenko [this message]
2021-02-16 14:18 ` [PATCH v2 2/4] Documentation: devres: Add pcim_alloc_irq_vectors() Dejin Zheng
2021-02-16 14:18 ` [PATCH v2 3/4] i2c: designware: Use the correct name of device-managed function Dejin Zheng
2021-02-16 14:39 ` Andy Shevchenko
2021-02-16 16:11 ` Dejin Zheng
2021-02-16 14:18 ` [PATCH v2 4/4] i2c: thunderx: " Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCvZQUaTI2Jt6N4q@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=corbet@lwn.net \
--cc=jarkko.nikula@linux.intel.com \
--cc=kw@linux.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rric@kernel.org \
--cc=wsa@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.