From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A65A1C433E0 for ; Wed, 17 Feb 2021 09:07:03 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B50A064E02 for ; Wed, 17 Feb 2021 09:07:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B50A064E02 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:47768 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lCInV-00034C-86 for qemu-devel@archiver.kernel.org; Wed, 17 Feb 2021 04:07:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCIjU-0002Ap-8u; Wed, 17 Feb 2021 04:02:52 -0500 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:56637) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lCIjS-0001HL-3K; Wed, 17 Feb 2021 04:02:51 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 07185F40; Wed, 17 Feb 2021 04:02:46 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 17 Feb 2021 04:02:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=2VDclYhEuuvnLyPYgOjvNf8hQ2d 3Rs464TzQQLoX4/0=; b=F85io4KcSPpqmKlzbP4NjAbI7ZgqNKxJ8+wh7WPiO07 I0PSbz5DfsQRxIRqogn0fW9joe9nC4PvAaI5VWw7xlfROe5mFJeTdMBGJh2TJfd2 Dzk4R+hvkXB3wRHmoNxW2BAhT9zH1hUOVTRk9JVy2Tpve3Jd1RVvn387XBclXVwH +vjGhHOb8Jz029JFUjjlWqkWml0uEB3vwve+duLB4AyacCTIG+VNrO8HRsm2MZnK Yd5n+0hs4Ij8aHSaPFrpsWDtPF6OqCbXlYloye4JTmpqFQZScJ6mQ8foyckYjaA4 hgTUmIS61E5mo68l+qHrpztUAAEQFBHU1Egi/qhOPNg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=2VDclY hEuuvnLyPYgOjvNf8hQ2d3Rs464TzQQLoX4/0=; b=rcaBOCwKa45yhLu4KN2CmO cJ7DqZH5h4FzuHaiWBfDz5MD4ex548n3MB60ILooNxFyY0bpMJPOrbROFeg0m8ir SQwcaWDGJNJnjel+IgRpoq25hP96NbyMQN999XxZKBuZxHg/5iNVLJiPMXW50FIt +42oDxj1Je38EYI3As7TLhlapRz9uDjvF43GME9dc/G/Zv/bg3UtvGhr9ZCM5aeH m1EwxLK9fRNY7SfPBDQKz+ouiU1zz5TzvpjEoPGEixCFFbf6Wm6q5wEW+6tq32c5 4HUPqspuS6OV+LM54NLNJZLcSdixsv2abf1IIhcdV3P6Y2nngeCJdfNwZ55RDsJg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrjedugdduvdegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeejgeduffeuieetkeeileekvdeuleetveejudeileduffefjeegfffhuddvudff keenucfkphepkedtrdduieejrdelkedrudeltdenucevlhhushhtvghrufhiiigvpedtne curfgrrhgrmhepmhgrihhlfhhrohhmpehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id 1EC1E24005B; Wed, 17 Feb 2021 04:02:43 -0500 (EST) Date: Wed, 17 Feb 2021 10:02:40 +0100 From: Klaus Jensen To: Keith Busch Subject: Re: [PATCH RFC v3 09/12] hw/block/nvme: add verify command Message-ID: References: <20210214230240.301275-1-its@irrelevant.dk> <20210214230240.301275-10-its@irrelevant.dk> <20210216231213.GE2708768@dhcp-10-100-145-180.wdc.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Rv0CtS/wVBUqPRRj" Content-Disposition: inline In-Reply-To: <20210216231213.GE2708768@dhcp-10-100-145-180.wdc.com> Received-SPF: pass client-ip=64.147.123.21; envelope-from=its@irrelevant.dk; helo=wout5-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , qemu-block@nongnu.org, Klaus Jensen , Gollu Appalanaidu , qemu-devel@nongnu.org, Max Reitz , Stefan Hajnoczi Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --Rv0CtS/wVBUqPRRj Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Feb 16 15:12, Keith Busch wrote: > On Mon, Feb 15, 2021 at 12:02:37AM +0100, Klaus Jensen wrote: > > From: Gollu Appalanaidu > >=20 > > See NVM Express 1.4, section 6.14 ("Verify Command"). > >=20 > > Signed-off-by: Gollu Appalanaidu > > [k.jensen: rebased, refactored for e2e] > > Signed-off-by: Klaus Jensen >=20 > Verify is a generic block command supported in other protocols beyond > nvme. If we're going to support the command in nvme, I prefer the > implementation had generic backing out of the qemu block API rather than > emulate the entirety out of the nvme device. You mean that the block API could provide a basic "check that we can read this stuff without error"-call? Sounds reasonable enough, but since the end-to-end data protection checks are performed in the device, we need to pass the data buffers up anyway. If we had basic I/O (non-pi) verify in the block API it would defeat the purpose if it provided those buffers. We've actually been asked directly on the availablity of Verify support in QEMU, so I think this implementation as-is provides something useful to users. --Rv0CtS/wVBUqPRRj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmAs268ACgkQTeGvMW1P DelA8gf/ettjjJ8nwKm1I4jnMIpUC6I10LoigOZ0Io7teR7T4BH61jDsLidzaMQG jCpOfDRGMyps2r7p6syFXm6GWtmQYUElJJxDKR6OmL47C5nsgDoARG4Yhq9SB02Z ocX4UTB1oz8etOssfE7Egy+hj2NOIP+rTlKHa2GGPGZ8rYGd9DdUO0/mp8nk4I+G 8fUqOmR3KIOhHP6tTjmuq+y3EVkz6doS8XzT2o1U5yvXCE5wW7/Cmy2z8/WRZAmC UFURaroG0IoNODspFm92dGnIRfcDIFHMbgLz7W4RWPgxgFYzMDRDUmYK3zK0EJxA EEm4dh1Aw5cq7elP4tyOBlhNSNOv/g== =BO4D -----END PGP SIGNATURE----- --Rv0CtS/wVBUqPRRj--