From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C84F0C4332B for ; Tue, 2 Mar 2021 06:55:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 977FB6148E for ; Tue, 2 Mar 2021 06:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1573976AbhCBD2d (ORCPT ); Mon, 1 Mar 2021 22:28:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:50834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S243436AbhCAUdz (ORCPT ); Mon, 1 Mar 2021 15:33:55 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id D7D1D64DA3; Mon, 1 Mar 2021 18:53:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614624790; bh=3ELhbjMqRRzMMMCjxYb3jrE9yCN1/eAHw8TPFwAgK1g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=v1zW3X8zlY6cj6ucIok+Ue2b/pCILK0xYZxkFeRkWrNV1K0VYuvvdsicmN9sNP18+ WPaszXpZaxs3H1RkXTkQN/dKdB56MEepPLiy2UMokAaiUromuwEQzYTIZ+5up61rx4 IOJSxlOX927LiLJfpHveSSVc7PvEth42ftYMyBZ8= Date: Mon, 1 Mar 2021 19:50:35 +0100 From: Greg Kroah-Hartman To: Dmitry Baryshkov Cc: Bjorn Andersson , Arnd Bergmann , open list , Srinivas Kandagatla , Jonathan Marek , stable@vger.kernel.org, Nicolas Dechesne Subject: Re: [PATCH v2] misc: fastrpc: restrict user apps from sending kernel RPC messages Message-ID: References: <20210212192658.3476137-1-dmitry.baryshkov@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 01, 2021 at 08:45:34PM +0300, Dmitry Baryshkov wrote: > On Mon, 1 Mar 2021 at 18:48, Greg Kroah-Hartman > wrote: > > > > On Mon, Mar 01, 2021 at 06:34:10PM +0300, Dmitry Baryshkov wrote: > > > On Sat, 13 Feb 2021 at 11:25, Greg Kroah-Hartman > > > wrote: > > > > > > > > On Fri, Feb 12, 2021 at 10:26:58PM +0300, Dmitry Baryshkov wrote: > > > > > Verify that user applications are not using the kernel RPC message > > > > > handle to restrict them from directly attaching to guest OS on the > > > > > remote subsystem. This is a port of CVE-2019-2308 fix. > > > > > > > > A port of the fix of what to what? > > > > > > I'm sorry for the confusion. It is a port of the original > > > Qualcomm/CodeAurora fix to the upstream driver. > > > > > > See https://source.codeaurora.org/quic/la/kernel/msm-4.9/commit/?id=cc2e11eeb988964af72309f71b0fb21c11ed6ca9, > > > > So this is a fix from 2019 that you never submitted upstream causing all > > of these kernels to be vulnerable? > > It seems there is some kind of confusion here. > Srinivas and Thierry have developed the fastrpc driver. It is not the > same as the driver developed by Qualcomm. However in this case it > suffers from the same problem as the original adsprpc driver.. > We have submitted the fix as soon as we've noticed the issue. Ah, that makes more sense, thanks. So really, it's not the same CVE issue, aren't they fun? :) thanks, greg k-h