* [PATCH] tpm: Remove unintentional dump_stack() call
@ 2021-03-01 9:44 jarkko
2021-03-01 21:08 ` Rikard Falkeborn
0 siblings, 1 reply; 3+ messages in thread
From: jarkko @ 2021-03-01 9:44 UTC (permalink / raw)
To: linux-integrity
Cc: linux-kernel, Jarkko Sakkinen, Rikard Falkeborn, Peter Huewe,
Jason Gunthorpe
From: Jarkko Sakkinen <jarkko@kernel.org>
Somewhere along the line, probably during a rebase, an unintentional
dump_stack() got included. Revert this change.
Reported-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Fixes: 90cba8d20f8b ("tpm/ppi: Constify static struct attribute_group")
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
---
drivers/char/tpm/tpm-chip.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
index 19e23fcc6bc8..ddaeceb7e109 100644
--- a/drivers/char/tpm/tpm-chip.c
+++ b/drivers/char/tpm/tpm-chip.c
@@ -278,8 +278,6 @@ static void tpm_devs_release(struct device *dev)
{
struct tpm_chip *chip = container_of(dev, struct tpm_chip, devs);
- dump_stack();
-
/* release the master device reference */
put_device(&chip->dev);
}
--
2.30.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tpm: Remove unintentional dump_stack() call
2021-03-01 9:44 [PATCH] tpm: Remove unintentional dump_stack() call jarkko
@ 2021-03-01 21:08 ` Rikard Falkeborn
0 siblings, 0 replies; 3+ messages in thread
From: Rikard Falkeborn @ 2021-03-01 21:08 UTC (permalink / raw)
To: jarkko
Cc: linux-integrity, linux-kernel, Rikard Falkeborn, Peter Huewe,
Jason Gunthorpe
On Mon, Mar 01, 2021 at 11:44:09AM +0200, jarkko@kernel.org wrote:
> From: Jarkko Sakkinen <jarkko@kernel.org>
>
> Somewhere along the line, probably during a rebase, an unintentional
> dump_stack() got included. Revert this change.
>
> Reported-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> Fixes: 90cba8d20f8b ("tpm/ppi: Constify static struct attribute_group")
> Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
> ---
> drivers/char/tpm/tpm-chip.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
> index 19e23fcc6bc8..ddaeceb7e109 100644
> --- a/drivers/char/tpm/tpm-chip.c
> +++ b/drivers/char/tpm/tpm-chip.c
> @@ -278,8 +278,6 @@ static void tpm_devs_release(struct device *dev)
> {
> struct tpm_chip *chip = container_of(dev, struct tpm_chip, devs);
>
> - dump_stack();
> -
> /* release the master device reference */
> put_device(&chip->dev);
> }
> --
> 2.30.1
>
Acked-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] tpm: Remove unintentional dump_stack() call
@ 2021-03-01 21:24 Jarkko Sakkinen
0 siblings, 0 replies; 3+ messages in thread
From: Jarkko Sakkinen @ 2021-03-01 21:24 UTC (permalink / raw)
To: linux-integrity
Cc: linux-kernel, Jarkko Sakkinen, Rikard Falkeborn, Peter Huewe,
Jason Gunthorpe
Somewhere along the line, probably during a rebase, an unintentional
dump_stack() got included. Revert this change.
Reported-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Fixes: 90cba8d20f8b ("tpm/ppi: Constify static struct attribute_group")
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
---
drivers/char/tpm/tpm-chip.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/char/tpm/tpm-chip.c b/drivers/char/tpm/tpm-chip.c
index 19e23fcc6bc8..ddaeceb7e109 100644
--- a/drivers/char/tpm/tpm-chip.c
+++ b/drivers/char/tpm/tpm-chip.c
@@ -278,8 +278,6 @@ static void tpm_devs_release(struct device *dev)
{
struct tpm_chip *chip = container_of(dev, struct tpm_chip, devs);
- dump_stack();
-
/* release the master device reference */
put_device(&chip->dev);
}
--
2.30.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-02 7:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-01 9:44 [PATCH] tpm: Remove unintentional dump_stack() call jarkko
2021-03-01 21:08 ` Rikard Falkeborn
2021-03-01 21:24 Jarkko Sakkinen
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.