All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: linux-usb@vger.kernel.org,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Subject: Re: [PATCH 5/6] USB: typec: fusb302: create debugfs subdir for the driver
Date: Tue, 2 Mar 2021 08:32:02 +0100	[thread overview]
Message-ID: <YD3p8mQHgQyE4B9N@kroah.com> (raw)
In-Reply-To: <46f9d74a-85a5-835b-208a-c612e2c56199@roeck-us.net>

On Tue, Feb 16, 2021 at 07:24:14AM -0800, Guenter Roeck wrote:
> On 2/16/21 6:46 AM, Greg Kroah-Hartman wrote:
> > The single debugfs file for this driver really is a log file, so make a
> > subdir and call it "log" to make it obvious this is what it is for.
> > This makes cleanup simpler as we just remove the whole directory, no
> > need to handle individual files anymore.
> > 
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> > Cc: linux-usb@vger.kernel.org
> > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> 
> Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> 
> I'd probably have explored the possibility to group files like this
> under the newly created tcpm debugfs directory, but that is really
> a nitpick.

Good idea, I'll look into doing that next...

thanks,

greg k-h

  reply	other threads:[~2021-03-02 11:01 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-16 14:46 [PATCH 1/6] USB: host: isp116x: remove dentry pointer for debugfs Greg Kroah-Hartman
2021-02-16 14:46 ` [PATCH 2/6] USB: host: isp1362: " Greg Kroah-Hartman
2021-02-16 14:46 ` [PATCH 3/6] USB: host: sl811: " Greg Kroah-Hartman
2021-02-16 14:46 ` [PATCH 4/6] USB: host: uhci: " Greg Kroah-Hartman
2021-02-16 14:46 ` [PATCH 5/6] USB: typec: fusb302: create debugfs subdir for the driver Greg Kroah-Hartman
2021-02-16 15:24   ` Guenter Roeck
2021-03-02  7:32     ` Greg Kroah-Hartman [this message]
2021-03-01 15:15   ` Heikki Krogerus
2021-02-16 14:46 ` [PATCH 6/6] USB: typec: tcpm: " Greg Kroah-Hartman
2021-02-16 15:22   ` Guenter Roeck
2021-03-01 15:16   ` Heikki Krogerus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YD3p8mQHgQyE4B9N@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.