All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petri Latvala <petri.latvala@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/kmod: Stop producing results at all for kernel selftests on taint
Date: Tue, 2 Mar 2021 14:39:35 +0200	[thread overview]
Message-ID: <YD4yB/x4tv3Du7vG@platvala-desk.ger.corp.intel.com> (raw)
In-Reply-To: <161468568208.13469.12406365697364305928@build.alporthouse.com>

On Tue, Mar 02, 2021 at 11:48:02AM +0000, Chris Wilson wrote:
> Quoting Petri Latvala (2021-02-25 08:35:53)
> > Instead of producing skips for the rest when one selftest taints the
> > kernel, stop running them altogether. Having the skips produced yields
> > no value and just makes future improvements (like correctly tagging
> > tests that cause taints) harder. In effect, this gets us back to the
> > old setup when tainting made igt_runner immediately kill the test and
> > similarly made us not get spurious results for the rest of the
> > selftests.
> 
> Skip isn't spurious here. I don't see how this impacts tagging the
> earlier tests. So the only question for me is whether SKIP or NOTRUN is
> more applicable. And skip is far more informative when run by hand...

When run by hand on an already tainted kernel, the first (specified)
selftest still gets a skip and others don't get executed.

The immediate value I'll be getting from this is my ongoing work on
the ugly igt@runner@aborted pseudoresult to instead mark the last
executed test as 'ABORT' result when igt_runner decides to abort the
execution (due to a taint). If we have skips, I'd need to do some
selftest-specific handling to not mark the last executed dynamic
subtest, but the last non-skipping dynamic subtest.


-- 
Petri Latvala
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2021-03-02 12:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-25  8:35 [igt-dev] [PATCH i-g-t] lib/kmod: Stop producing results at all for kernel selftests on taint Petri Latvala
2021-02-25  9:42 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2021-02-25 10:56 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
2021-03-03  8:00   ` Petri Latvala
2021-03-04  5:28     ` Vudum, Lakshminarayana
2021-03-02 11:48 ` [igt-dev] [PATCH i-g-t] " Chris Wilson
2021-03-02 12:39   ` Petri Latvala [this message]
2021-03-02 13:04     ` Chris Wilson
2021-03-02 13:23       ` Petri Latvala
2021-03-02 13:29         ` Chris Wilson
2021-03-02 13:54           ` Petri Latvala
2021-03-02 13:42         ` Chris Wilson
2021-03-03  8:01           ` Petri Latvala
2021-03-03 17:01 ` [igt-dev] ✓ Fi.CI.IGT: success for " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YD4yB/x4tv3Du7vG@platvala-desk.ger.corp.intel.com \
    --to=petri.latvala@intel.com \
    --cc=chris@chris-wilson.co.uk \
    --cc=igt-dev@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.