From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3DA1C4160E for ; Tue, 2 Mar 2021 22:37:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9D0DC64F35 for ; Tue, 2 Mar 2021 22:37:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2359898AbhCBWFE (ORCPT ); Tue, 2 Mar 2021 17:05:04 -0500 Received: from mail.kernel.org ([198.145.29.99]:40460 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1836075AbhCBThF (ORCPT ); Tue, 2 Mar 2021 14:37:05 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id F1B5D64F38; Tue, 2 Mar 2021 16:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614702746; bh=yumA0cahWTD9QKsYQGmd5EnWtZ0ZFFVwv1aA4Z0Bb98=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nJ19DVR55kPfbyXMcsrz/03FRzp0jmKIAnxQ9RGA4YhpkPNZpPaiu0Jai15qoliiD vTxy9f9LM2sDIOafwlRf+rfe4RhR4Xx5PRwVhnT/4SAci94zznNl8mN+17/UHYFVlh 4gOFlMdTdx6wPcjh17NCIATGiswdGHvK2TKbOAqYpL4MPuf01zd+egP86vQX06jTDc zKmveU+OGTV1jOCJa71o35jBGe4liaYgTgNpFt3zUuwFFptOSKhOoS420onTPSnM1X nQMIK7czeNZJ2BiUHSHLmOyXurTqzHnFCide8lW9bLbOn+57Ad3eaHiYSvXTjMV0yp s1R7rrYcH2/+A== Date: Tue, 2 Mar 2021 22:02:21 +0530 From: Vinod Koul To: Daniel Lezcano Cc: rafael@kernel.org, andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Etienne Carriere , Chunfeng Yun , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" Subject: Re: [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros Message-ID: References: <20210224144222.23762-1-daniel.lezcano@linaro.org> <20210224144222.23762-9-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210224144222.23762-9-daniel.lezcano@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24-02-21, 15:42, Daniel Lezcano wrote: > HZ unit conversion macros are available in units.h, use them and > remove the duplicate definition. > > Signed-off-by: Daniel Lezcano > --- > drivers/phy/st/phy-stm32-usbphyc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c > index a54317e96c41..02dd12bb4692 100644 > --- a/drivers/phy/st/phy-stm32-usbphyc.c > +++ b/drivers/phy/st/phy-stm32-usbphyc.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #define STM32_USBPHYC_PLL 0x0 > #define STM32_USBPHYC_MISC 0x8 > @@ -48,7 +49,6 @@ static const char * const supplies_names[] = { > #define PLL_FVCO_MHZ 2880 > #define PLL_INFF_MIN_RATE_HZ 19200000 > #define PLL_INFF_MAX_RATE_HZ 38400000 > -#define HZ_PER_MHZ 1000000L I dont see this in units.h, can you send this once it is merged upstream -- ~Vinod From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4AA6C433E0 for ; Wed, 3 Mar 2021 15:09:59 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 39B2B64EBA for ; Wed, 3 Mar 2021 15:09:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 39B2B64EBA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=GjvmRngnarFCVL0bKvPdctdYtnZcAWLn8i6ZqoASkNo=; b=HQUtWkSyxwRcYu5qR6UT2WXA5 ap8lsLgCgtBnv32ze+a7P8fDDH/sofpivSHwZtP5e0a0JDflboq8knU4mUIecRwbiZrgXU/vJDbJN KU6L1oKpq29Cqru63ZD7U5qD21dFMIx8QY3ESSq30lvmKL0+pOLg9fTn9ANncoSqtgFuKuHrDzx8I O95DzvSmKICzB9GBmKGXuhInvbBjok9oJHy2pCfbiM7lpZNvnYwxEJbmFM892j/ESlL6mudqeNa7s 0gti4OnGSrzXWuSh0NiYzA1JSAvBp1dWsuh1AfgL5Cgz2N4FeX6KhxKFZ6w84SGWOazUyN0mzxKh0 Uf12v0FwA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lHT5g-005Ip3-NG; Wed, 03 Mar 2021 15:07:09 +0000 Received: from casper.infradead.org ([2001:8b0:10b:1236::1]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lHSBu-0054ZA-LJ for linux-arm-kernel@desiato.infradead.org; Wed, 03 Mar 2021 14:09:31 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=PT7krf8O45IDgWotpeXhE9lzQcv5SIvDxC/2lhJgAMs=; b=RayGvwnnnJL9wkxmwu/bVQIYJF La5giuj51PZ+koaLLsb9w9HhopXzudx2WQL4MfGs8OrN736lRZZTu9Qcjd4zdSzBLDzRJdOaFWL13 8npYkOOctnM+8HCqdhaUu2pVHQx/OR9fP7ilDNTOn6GevtG4GjuT0HfOP875R9D/pkwy7cEGWuJCs DuC3ZZlW4XFhFla6JM0ujY6wIe/dtjQBk/xGur8ItrxdPjZqZA5/6kGR62uD6lTzkShzlRsehUTxZ sQiHQTlY6BFGaVWUtPKFtwtIAZjujhZPbux1LHMAtgVkCc4tLuO6p9UbqFV2pD32Cigpxpe7NbRq8 uPATrlXA==; Received: from mail.kernel.org ([198.145.29.99]) by casper.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lH7wn-00HSBC-Av for linux-arm-kernel@lists.infradead.org; Tue, 02 Mar 2021 16:32:35 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id F1B5D64F38; Tue, 2 Mar 2021 16:32:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614702746; bh=yumA0cahWTD9QKsYQGmd5EnWtZ0ZFFVwv1aA4Z0Bb98=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nJ19DVR55kPfbyXMcsrz/03FRzp0jmKIAnxQ9RGA4YhpkPNZpPaiu0Jai15qoliiD vTxy9f9LM2sDIOafwlRf+rfe4RhR4Xx5PRwVhnT/4SAci94zznNl8mN+17/UHYFVlh 4gOFlMdTdx6wPcjh17NCIATGiswdGHvK2TKbOAqYpL4MPuf01zd+egP86vQX06jTDc zKmveU+OGTV1jOCJa71o35jBGe4liaYgTgNpFt3zUuwFFptOSKhOoS420onTPSnM1X nQMIK7czeNZJ2BiUHSHLmOyXurTqzHnFCide8lW9bLbOn+57Ad3eaHiYSvXTjMV0yp s1R7rrYcH2/+A== Date: Tue, 2 Mar 2021 22:02:21 +0530 From: Vinod Koul To: Daniel Lezcano Cc: rafael@kernel.org, andriy.shevchenko@linux.intel.com, linux-kernel@vger.kernel.org, Kishon Vijay Abraham I , Maxime Coquelin , Alexandre Torgue , Amelie Delaunay , Etienne Carriere , Chunfeng Yun , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" Subject: Re: [PATCH v2 9/9] phy/drivers/stm32: Use HZ macros Message-ID: References: <20210224144222.23762-1-daniel.lezcano@linaro.org> <20210224144222.23762-9-daniel.lezcano@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210224144222.23762-9-daniel.lezcano@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210302_163235_532200_E3F0C917 X-CRM114-Status: GOOD ( 12.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 24-02-21, 15:42, Daniel Lezcano wrote: > HZ unit conversion macros are available in units.h, use them and > remove the duplicate definition. > > Signed-off-by: Daniel Lezcano > --- > drivers/phy/st/phy-stm32-usbphyc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c > index a54317e96c41..02dd12bb4692 100644 > --- a/drivers/phy/st/phy-stm32-usbphyc.c > +++ b/drivers/phy/st/phy-stm32-usbphyc.c > @@ -14,6 +14,7 @@ > #include > #include > #include > +#include > > #define STM32_USBPHYC_PLL 0x0 > #define STM32_USBPHYC_MISC 0x8 > @@ -48,7 +49,6 @@ static const char * const supplies_names[] = { > #define PLL_FVCO_MHZ 2880 > #define PLL_INFF_MIN_RATE_HZ 19200000 > #define PLL_INFF_MAX_RATE_HZ 38400000 > -#define HZ_PER_MHZ 1000000L I dont see this in units.h, can you send this once it is merged upstream -- ~Vinod _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel