From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F821C433E0 for ; Sun, 21 Feb 2021 15:03:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 031BF64ED7 for ; Sun, 21 Feb 2021 15:03:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230040AbhBUPC7 (ORCPT ); Sun, 21 Feb 2021 10:02:59 -0500 Received: from mail.kernel.org ([198.145.29.99]:57190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229663AbhBUPC5 (ORCPT ); Sun, 21 Feb 2021 10:02:57 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 52E1E64EDE; Sun, 21 Feb 2021 15:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613919736; bh=d4ANynSmNbXObqDDoOwixZII/pFiyoIFifqZb3QHJZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BV9ea2WRL93VHHdd8M4b8HmNPaZy1+rg+pDZAZdqOMg7bSHrdC7QpKLfxCHBi3d+w AlokQjkItPU6LenTidaXAe8jDxkUsXPerszhfTEjGRClM+8bgPooQYW9OKjzSiCS27 EEh2oy7Qnon8J3Rvbp5GbJBHAJgcq/smrvnFlO0w= Date: Sun, 21 Feb 2021 16:02:14 +0100 From: Greg Kroah-Hartman To: karthik alapati Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] staging: media/atomisp: don't compile unused code Message-ID: References: <90eb63796a8f8aca988efb33247ea01f4a860074.1613915981.git.mail@karthek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90eb63796a8f8aca988efb33247ea01f4a860074.1613915981.git.mail@karthek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 21, 2021 at 07:34:57PM +0530, karthik alapati wrote: > currently the functions defined in ibuf_ctrl_rmgr.c file are only > used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected > so dont't compile it when not needed, also fixes some sparse warnings > > Signed-off-by: karthik alapati > --- > drivers/staging/media/atomisp/Makefile | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) This has nothing to do with the previous 2 patches, why did you add it to this series? And note, you missed the correct people to send this patch to, so it's not going to ever get applied :( thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_05,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759D0C433E0 for ; Sun, 21 Feb 2021 15:02:30 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C35F64ED7 for ; Sun, 21 Feb 2021 15:02:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C35F64ED7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id EBB678709D; Sun, 21 Feb 2021 15:02:29 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SBgyFo-+PRVO; Sun, 21 Feb 2021 15:02:29 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id 7E8A587080; Sun, 21 Feb 2021 15:02:29 +0000 (UTC) Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by ash.osuosl.org (Postfix) with ESMTP id A1C4A1BF95A for ; Sun, 21 Feb 2021 15:02:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id 9EA9985DD1 for ; Sun, 21 Feb 2021 15:02:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RQxHuR-SSb8Q for ; Sun, 21 Feb 2021 15:02:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by fraxinus.osuosl.org (Postfix) with ESMTPS id 3C4C885DCF for ; Sun, 21 Feb 2021 15:02:17 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 52E1E64EDE; Sun, 21 Feb 2021 15:02:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1613919736; bh=d4ANynSmNbXObqDDoOwixZII/pFiyoIFifqZb3QHJZQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BV9ea2WRL93VHHdd8M4b8HmNPaZy1+rg+pDZAZdqOMg7bSHrdC7QpKLfxCHBi3d+w AlokQjkItPU6LenTidaXAe8jDxkUsXPerszhfTEjGRClM+8bgPooQYW9OKjzSiCS27 EEh2oy7Qnon8J3Rvbp5GbJBHAJgcq/smrvnFlO0w= Date: Sun, 21 Feb 2021 16:02:14 +0100 From: Greg Kroah-Hartman To: karthik alapati Subject: Re: [PATCH 3/3] staging: media/atomisp: don't compile unused code Message-ID: References: <90eb63796a8f8aca988efb33247ea01f4a860074.1613915981.git.mail@karthek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <90eb63796a8f8aca988efb33247ea01f4a860074.1613915981.git.mail@karthek.com> X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Sun, Feb 21, 2021 at 07:34:57PM +0530, karthik alapati wrote: > currently the functions defined in ibuf_ctrl_rmgr.c file are only > used by isys_init.c when CONFIG_VIDEO_ATOMISP_ISP2401 is selected > so dont't compile it when not needed, also fixes some sparse warnings > > Signed-off-by: karthik alapati > --- > drivers/staging/media/atomisp/Makefile | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) This has nothing to do with the previous 2 patches, why did you add it to this series? And note, you missed the correct people to send this patch to, so it's not going to ever get applied :( thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel