From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23AD5C433DB for ; Sun, 21 Feb 2021 20:52:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D755364DF2 for ; Sun, 21 Feb 2021 20:52:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230459AbhBUUwx (ORCPT ); Sun, 21 Feb 2021 15:52:53 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:51628 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230375AbhBUUwx (ORCPT ); Sun, 21 Feb 2021 15:52:53 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lDvhz-007il1-Q2; Sun, 21 Feb 2021 21:52:03 +0100 Date: Sun, 21 Feb 2021 21:52:03 +0100 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Cc: Gregory CLEMENT , Rui Salvaterra , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org Subject: Re: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Message-ID: References: <20210220231144.32325-1-kabel@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210220231144.32325-1-kabel@kernel.org> Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org On Sun, Feb 21, 2021 at 12:11:44AM +0100, Marek Behún wrote: > Use the `marvell,reg-init` DT property to configure the LED[2]/INTn pin > of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode. > > Without this the pin is by default in LED[2] mode, and the Marvell PHY > driver configures LED[2] into "On - Link, Blink - Activity" mode. > > This fixes the issue where the pca9538 GPIO/interrupt controller (which > can't mask interrupts in HW) received too many interrupts and after a > time started ignoring the interrupt with error message: > IRQ 71: nobody cared > > There is a work in progress to have the Marvell PHY driver support > parsing PHY LED nodes from OF and registering the LEDs as Linux LED > class devices. Once this is done the PHY driver can also automatically > set the pin into INTn mode if it does not find LED[2] in OF. > > Until then, though, we fix this via `marvell,reg-init` DT property. > > Signed-off-by: Marek Behún > Reported-by: Rui Salvaterra > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") > Cc: Uwe Kleine-König > Cc: linux-arm-kernel@lists.infradead.org > Cc: Andrew Lunn > Cc: Gregory CLEMENT > Cc: Hi Marek Reviewed-by: Andrew Lunn > This patch fixes bug introduced with the commit that added Turris > Omnia's DTS (26ca8b52d6e1), but will not apply cleanly because there is > commit 8ee4a5f4f40d which changed node name and node compatible > property and this commit did not go into stable. > > So either commit 8ee4a5f4f40d has also to go into stable before this, or > this patch has to be fixed a little in order to apply to 4.14+. Once this has made it into Linus's tree, you can give GregKH a version which will apply cleanly to 4.14. Reference the upstream version so they can be linked together. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 404A2C433E0 for ; Sun, 21 Feb 2021 20:53:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D912664E09 for ; Sun, 21 Feb 2021 20:53:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D912664E09 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F+NjdfhQ185AAEikMC1/274G+K1qphl9fLPsxidBZPk=; b=YnqYVfmiAB109sTV4aYM0q+ug rX7g4Nx34/SNeVXrHQA/MChIDT1fI7GRy1SIbwxWQcYSgNe8nu3GzUuTy+/LDrOqO/hKVmHDswMrQ 07bKSJPkabDRmsl/2mPgzIgDmMbWZJIOFJ8fXV+cYsnAFINjkckfQO7yEfo41j0IiFtmRNh8Wajjy PhNre5r6Ftbkuohky2n3aO+CLv55X+wVybpcLPdCBDqXEOU83s9ksf/wldtxPzrGA9UlVZSsHtVsn cpLmDJ5QvHI1ssC8CFoPi30enJ/hKAdzvsaCK4UKerqVGUeO1DKdnm8xxgiwrToVl19+Dh72FYJxB e2SDStiGw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDviA-0000xz-CE; Sun, 21 Feb 2021 20:52:14 +0000 Received: from vps0.lunn.ch ([185.16.172.187]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lDvi7-0000xc-Ks for linux-arm-kernel@lists.infradead.org; Sun, 21 Feb 2021 20:52:12 +0000 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1lDvhz-007il1-Q2; Sun, 21 Feb 2021 21:52:03 +0100 Date: Sun, 21 Feb 2021 21:52:03 +0100 From: Andrew Lunn To: Marek =?iso-8859-1?Q?Beh=FAn?= Subject: Re: [PATCH mvebu-dt] ARM: dts: turris-omnia: configure LED[2]/INTn pin as interrupt pin Message-ID: References: <20210220231144.32325-1-kabel@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210220231144.32325-1-kabel@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210221_155211_745476_908F1E54 X-CRM114-Status: GOOD ( 17.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stable@vger.kernel.org, Gregory CLEMENT , linux-arm-kernel@lists.infradead.org, Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Rui Salvaterra Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, Feb 21, 2021 at 12:11:44AM +0100, Marek Beh=FAn wrote: > Use the `marvell,reg-init` DT property to configure the LED[2]/INTn pin > of the Marvell 88E1514 ethernet PHY on Turris Omnia into interrupt mode. > = > Without this the pin is by default in LED[2] mode, and the Marvell PHY > driver configures LED[2] into "On - Link, Blink - Activity" mode. > = > This fixes the issue where the pca9538 GPIO/interrupt controller (which > can't mask interrupts in HW) received too many interrupts and after a > time started ignoring the interrupt with error message: > IRQ 71: nobody cared > = > There is a work in progress to have the Marvell PHY driver support > parsing PHY LED nodes from OF and registering the LEDs as Linux LED > class devices. Once this is done the PHY driver can also automatically > set the pin into INTn mode if it does not find LED[2] in OF. > = > Until then, though, we fix this via `marvell,reg-init` DT property. > = > Signed-off-by: Marek Beh=FAn > Reported-by: Rui Salvaterra > Fixes: 26ca8b52d6e1 ("ARM: dts: add support for Turris Omnia") > Cc: Uwe Kleine-K=F6nig > Cc: linux-arm-kernel@lists.infradead.org > Cc: Andrew Lunn > Cc: Gregory CLEMENT > Cc: Hi Marek Reviewed-by: Andrew Lunn > This patch fixes bug introduced with the commit that added Turris > Omnia's DTS (26ca8b52d6e1), but will not apply cleanly because there is > commit 8ee4a5f4f40d which changed node name and node compatible > property and this commit did not go into stable. > = > So either commit 8ee4a5f4f40d has also to go into stable before this, or > this patch has to be fixed a little in order to apply to 4.14+. Once this has made it into Linus's tree, you can give GregKH a version which will apply cleanly to 4.14. Reference the upstream version so they can be linked together. Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel