From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 666FEC433DB for ; Mon, 22 Feb 2021 01:20:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3F2B064E76 for ; Mon, 22 Feb 2021 01:20:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230202AbhBVBUG (ORCPT ); Sun, 21 Feb 2021 20:20:06 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:54606 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230060AbhBVBUC (ORCPT ); Sun, 21 Feb 2021 20:20:02 -0500 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 4050C517; Mon, 22 Feb 2021 02:19:20 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1613956760; bh=52zTbjDt8qwop+IsJgzCXfjEF2FUyaNJ9q3or9+UqX0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WcaI0I2cPf7peCk6nYfQJHaSvZACyxPqA/3UV57udUVD6GGBJEv14FJ+gHUC8X2SY bftQXDcNLYYdLR0LqK11ewN50Pb8SQABb8NBqnF+stB1oEfVWXHLIs/d+KWeSp7xhH uWcoilFMcNKm+h3MMq6wNRPYIdnY0gy8Kt79P2oc= Date: Mon, 22 Feb 2021 03:18:53 +0200 From: Laurent Pinchart To: Jacopo Mondi Cc: Kieran Bingham , niklas.soderlund+renesas@ragnatech.se, geert@linux-m68k.org, Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 07/16] media: i2c: rdacm2x: Fix wake up delay Message-ID: References: <20210216174146.106639-1-jacopo+renesas@jmondi.org> <20210216174146.106639-8-jacopo+renesas@jmondi.org> <3e759da5-9bba-54ae-fe39-a7db2cbbb31c@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <3e759da5-9bba-54ae-fe39-a7db2cbbb31c@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jacopo, Thank you for the patch. On Wed, Feb 17, 2021 at 01:33:01PM +0000, Kieran Bingham wrote: > On 16/02/2021 17:41, Jacopo Mondi wrote: > > The MAX9271 chip manual prescribes a delay of 5 milliseconds > > after the chip exists from low power state. > > > > Adjust the required delay in the rdacm21 camera module and add it > > to the rdacm20 that currently doesn't implement one. > > This sounds to me like it should be a common function in the max9271 module: > > > /* Verify communication with the MAX9271: ping to wakeup. */ > > dev->serializer.client->addr = MAX9271_DEFAULT_ADDR; > > i2c_smbus_read_byte(dev->serializer.client); > > usleep_range(5000, 8000); > > Especially as that MAX9271_DEFAULT_ADDR should probably be handled > directly in the max9271.c file too, and the RDACM's shouldn't care about it. I think this is a good idea. With this addressed, Reviewed-by: Laurent Pinchart > If we end up moving the max9271 'library' into more of a module/device > then this would have to be done in it's 'probe' anyway, so it's likely > better handled down there...? > > But ... it's not essential at this point in the series, so if you want > to keep this patch as is, > > Reviewed-by: Kieran Bingham > > Signed-off-by: Jacopo Mondi > > --- > > drivers/media/i2c/rdacm20.c | 1 + > > drivers/media/i2c/rdacm21.c | 2 +- > > 2 files changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/media/i2c/rdacm20.c b/drivers/media/i2c/rdacm20.c > > index ea30cc936531..39e4b4241870 100644 > > --- a/drivers/media/i2c/rdacm20.c > > +++ b/drivers/media/i2c/rdacm20.c > > @@ -460,6 +460,7 @@ static int rdacm20_initialize(struct rdacm20_device *dev) > > /* Verify communication with the MAX9271: ping to wakeup. */ > > dev->serializer.client->addr = MAX9271_DEFAULT_ADDR; > > i2c_smbus_read_byte(dev->serializer.client); > > + usleep_range(5000, 8000); > > > > /* Serial link disabled during config as it needs a valid pixel clock. */ > > ret = max9271_set_serial_link(&dev->serializer, false); > > diff --git a/drivers/media/i2c/rdacm21.c b/drivers/media/i2c/rdacm21.c > > index 179d107f494c..b22a2ca5340b 100644 > > --- a/drivers/media/i2c/rdacm21.c > > +++ b/drivers/media/i2c/rdacm21.c > > @@ -453,7 +453,7 @@ static int rdacm21_initialize(struct rdacm21_device *dev) > > /* Verify communication with the MAX9271: ping to wakeup. */ > > dev->serializer.client->addr = MAX9271_DEFAULT_ADDR; > > i2c_smbus_read_byte(dev->serializer.client); > > - usleep_range(3000, 5000); > > + usleep_range(5000, 8000); > > > > /* Enable reverse channel and disable the serial link. */ > > ret = max9271_set_serial_link(&dev->serializer, false); -- Regards, Laurent Pinchart