From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 300B4C433E6 for ; Wed, 24 Feb 2021 09:54:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A09D864DE7 for ; Wed, 24 Feb 2021 09:54:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234840AbhBXJyl (ORCPT ); Wed, 24 Feb 2021 04:54:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:49032 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234828AbhBXJyP (ORCPT ); Wed, 24 Feb 2021 04:54:15 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 55AC264DE7; Wed, 24 Feb 2021 09:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614160414; bh=yPq43gjzxrgBKpMUKdRA8k7osexf6QroB0Hwxh2xhRM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J47XGjL/RWEgvCjt9OrrAs8q/K4YqViy0nMAZ8p4k1rMcVhwx8ah2cyG7f8MYtTJJ Aa18lAUd3hlWwBwhZFF8MrJ8fxBZw9EF+CuqJhNe+0HGjZJBhl9chcP3AKfX60DiYO Gq9N7GACqILJ74Db5NWffmSrH0/xelPdKBaCYYAIsYQpE4Z6B+ffXvCbQ6/TlWNshd F1y4uO8SzwqkcEcnmqoCqUv+DLdqyhu4KkYEV3dC8uU73UYYEU1C7IPdxph5cmy3oD Ms6S3E6KGOap1wtQovM1ZVzFEHQOWgFkQmocDmq334k7Td6KHIQ0BwtEnpM98k4UVT CNwaO6ZY5Z3/A== Date: Wed, 24 Feb 2021 11:53:30 +0200 From: Leon Romanovsky To: Bjorn Helgaas Cc: Greg Kroah-Hartman , Bjorn Helgaas , Saeed Mahameed , Jason Gunthorpe , Alexander Duyck , Jakub Kicinski , linux-pci@vger.kernel.org, linux-rdma@vger.kernel.org, netdev@vger.kernel.org, Don Dutile , Alex Williamson , "David S . Miller" , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= Subject: Re: [PATCH mlx5-next v6 1/4] PCI: Add sysfs callback to allow MSI-X table size change of SR-IOV VFs Message-ID: References: <20210223210743.GA1475710@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210223210743.GA1475710@bjorn-Precision-5520> Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Feb 23, 2021 at 03:07:43PM -0600, Bjorn Helgaas wrote: > On Sun, Feb 21, 2021 at 08:59:18AM +0200, Leon Romanovsky wrote: > > On Sat, Feb 20, 2021 at 01:06:00PM -0600, Bjorn Helgaas wrote: > > > On Fri, Feb 19, 2021 at 09:20:18AM +0100, Greg Kroah-Hartman wrote: > > > > > > > Ok, can you step back and try to explain what problem you are trying to > > > > solve first, before getting bogged down in odd details? I find it > > > > highly unlikely that this is something "unique", but I could be wrong as > > > > I do not understand what you are wanting to do here at all. > > > > > > We want to add two new sysfs files: > > > > > > sriov_vf_total_msix, for PF devices > > > sriov_vf_msix_count, for VF devices associated with the PF > > > > > > AFAICT it is *acceptable* if they are both present always. But it > > > would be *ideal* if they were only present when a driver that > > > implements the ->sriov_get_vf_total_msix() callback is bound to the > > > PF. > > > > BTW, we already have all possible combinations: static, static with > > folder, with and without "sriov_" prefix, dynamic with and without > > folders on VFs. > > > > I need to know on which version I'll get Acked-by and that version I > > will resubmit. > > I propose that you make static attributes for both files, so > "sriov_vf_total_msix" is visible for *every* PF in the system and > "sriov_vf_msix_count" is visible for *every* VF in the system. No problem, this is close to v0/v1. > > The PF "sriov_vf_total_msix" show function can return zero if there's > no PF driver or it doesn't support ->sriov_get_vf_total_msix(). > (Incidentally, I think the documentation should mention that when it > *is* supported, the contents of this file are *constant*, i.e., it > does not decrease as vectors are assigned to VFs.) > > The "sriov_vf_msix_count" set function can ignore writes if there's no > PF driver or it doesn't support ->sriov_get_vf_total_msix(), or if a > VF driver is bound. Just to be clear, why don't we return EINVAL/EOPNOTSUPP instead of silently ignore? Thanks