From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E1EEC4332B for ; Wed, 24 Feb 2021 15:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5754064F0C for ; Wed, 24 Feb 2021 15:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236493AbhBXPOS (ORCPT ); Wed, 24 Feb 2021 10:14:18 -0500 Received: from mail-wm1-f51.google.com ([209.85.128.51]:38310 "EHLO mail-wm1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233826AbhBXO0H (ORCPT ); Wed, 24 Feb 2021 09:26:07 -0500 Received: by mail-wm1-f51.google.com with SMTP id n4so557064wmq.3; Wed, 24 Feb 2021 06:25:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yNOTeF74AEVCmwolAA0/8VTyL+nE8bLyKqVdo+FWMqY=; b=hK4+NygG1uT+ASYbGOVKdVkNg2OkhfSOpVkF3l6MiqRDlOM0+gcS+ETrRhXO/Gn5WE sUKy0HHUvxZ+5S4KHr0FVNxFb6y/dHf5bnp9uniBymMq86wO/rGYxsE46ktxpp/w6gTW BHX81cud8/1kyDQ2aBYLyVukLf2MUvrKJZ/ysAnuj867tJwG49nl6/hjytSBaxazstCj MozmgNt0MxmRvXNMSC09/N2rbbGitr4H9kaTi/t5V1zkHu1Y5sIlFahce2o0pkpKC4k7 rutG2YqXNUfL4g4Bu6k/wSBH53xTyo2PzwhZFc1u6FT0siTPEzH9LFiBkHBRrCynrcim tXAQ== X-Gm-Message-State: AOAM533+I4kh8ts6JHuvrs5nYHb6EGL1V0hBDWrRb6phJkEyPVKRsSqI L0VTHI1xtLzWfAqHnTim7rk= X-Google-Smtp-Source: ABdhPJxfrJvj1Nu7atjaQwkrtJNZuIvIcIcghN5f788Gg2oxt+yrdZvub8CkWecyTONsxU0eMBnWow== X-Received: by 2002:a1c:e041:: with SMTP id x62mr3285059wmg.95.1614176701475; Wed, 24 Feb 2021 06:25:01 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id j16sm3898710wra.17.2021.02.24.06.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 06:25:01 -0800 (PST) Date: Wed, 24 Feb 2021 15:24:59 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Jianjun Wang Cc: Bjorn Helgaas , Rob Herring , maz@kernel.org, Lorenzo Pieralisi , Ryder Lee , Philipp Zabel , Matthias Brugger , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sj Huang , youlin.pei@mediatek.com, chuanjia.liu@mediatek.com, qizhong.cheng@mediatek.com, sin_jieyang@mediatek.com, drinkcat@chromium.org, Rex-BC.Chen@mediatek.com, anson.chuang@mediatek.com Subject: Re: [v8,4/7] PCI: mediatek-gen3: Add INTx support Message-ID: References: <20210224061132.26526-1-jianjun.wang@mediatek.com> <20210224061132.26526-5-jianjun.wang@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210224061132.26526-5-jianjun.wang@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jianjun, [...] > +/** > + * mtk_intx_eoi > + * @data: pointer to chip specific data > + * > + * As an emulated level IRQ, its interrupt status will remain > + * until the corresponding de-assert message is received; hence that > + * the status can only be cleared when the interrupt has been serviced. > + */ [...] See my comment about the kernel-doc from the following: https://lore.kernel.org/linux-pci/YDZWUGcKet%2FlNWlF@rocinante/ [...] > + if (err) { > + dev_err(dev, "failed to init PCIe IRQ domain\n"); > + return err; > + } [...] Just a nitpick. What about using "initialize" in the above? Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6B37C433DB for ; Wed, 24 Feb 2021 14:25:15 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 789A264EF1 for ; Wed, 24 Feb 2021 14:25:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 789A264EF1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Uks9XJFrgDjWnHZGGrK9RjXEOxqbiPWR5dDQgDVY3So=; b=F+4QANCz6xwvX5335TLWOGEXc QvClkW54Ldoxlt/JeN71mvSWRPVL6V+HotpvpcCAueu7F+UjUDQKQoQ5TeEyyzzRjr6pv0/q05dp4 xiiJcK5/GwlfalCuqDtrG4jmgEQVHFADc8iVVoOTA2jLC8u9mmZlWjIBqaXCpt5tQpoeCYe94+kBh toWv9Nu004n1s9SuipCWLxg6w2Y516YBRZ+cF7fNLt3mEoDyd7vZ9e8NrbTu5eyHGxnrd58ABM/n0 IGVYmzguLKXcV7ytZ8Cc2t9jw6S6R4yetWrBIotrIkCHQb5/nZ08eLCjAkVaRKzWNMjN5tqeo3d72 VBnv1abhg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEv69-00032e-CK; Wed, 24 Feb 2021 14:25:05 +0000 Received: from mail-wm1-f52.google.com ([209.85.128.52]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEv67-00031f-2S; Wed, 24 Feb 2021 14:25:04 +0000 Received: by mail-wm1-f52.google.com with SMTP id u125so1971871wmg.4; Wed, 24 Feb 2021 06:25:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yNOTeF74AEVCmwolAA0/8VTyL+nE8bLyKqVdo+FWMqY=; b=bzPnGkZoRInOJNVuI7wJLvh89FUpMGzziYXVx6gm7EbZpaTNq1VAtMz2sl2aCUbjue JFxen6cW9GNKnYdVYwhMSAywil0CP94i5QGvqguAxqDHGmg0FqwZtLb4hwTkQKphCl0I pVUvdyMyo0x0Wi4cAgTxhiKEWR3qb1/+GrCDMIuwYMzWWYBZjuxQR+YO+nEzCFa+ZA+n dCPUy8YHlFqXRAk/q5+hv6OvRF0aH9HAgAkTcDt8BnVjMOaxBGSjSMZ3v8NeoDv7SY1i HDdQNxpME8hOcNxh4m7+OVspAbQtYRh8WIkHeMeRu2xI0IlHzUWRTBJsb0h+FM/GVkJY e36A== X-Gm-Message-State: AOAM530KcBJ0D+rUTXpzXxLho5TkI9wbGtDIuARVpQVK/MmzCWcIbBjT zgv4prg8cRwz5XtAh0d+vd4= X-Google-Smtp-Source: ABdhPJxfrJvj1Nu7atjaQwkrtJNZuIvIcIcghN5f788Gg2oxt+yrdZvub8CkWecyTONsxU0eMBnWow== X-Received: by 2002:a1c:e041:: with SMTP id x62mr3285059wmg.95.1614176701475; Wed, 24 Feb 2021 06:25:01 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id j16sm3898710wra.17.2021.02.24.06.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 06:25:01 -0800 (PST) Date: Wed, 24 Feb 2021 15:24:59 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Jianjun Wang Subject: Re: [v8,4/7] PCI: mediatek-gen3: Add INTx support Message-ID: References: <20210224061132.26526-1-jianjun.wang@mediatek.com> <20210224061132.26526-5-jianjun.wang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210224061132.26526-5-jianjun.wang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210224_092503_126753_F53440AB X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, Lorenzo Pieralisi , Rex-BC.Chen@mediatek.com, qizhong.cheng@mediatek.com, chuanjia.liu@mediatek.com, maz@kernel.org, drinkcat@chromium.org, Ryder Lee , linux-kernel@vger.kernel.org, sin_jieyang@mediatek.com, Sj Huang , Rob Herring , Bjorn Helgaas , Philipp Zabel , linux-pci@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, anson.chuang@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Jianjun, [...] > +/** > + * mtk_intx_eoi > + * @data: pointer to chip specific data > + * > + * As an emulated level IRQ, its interrupt status will remain > + * until the corresponding de-assert message is received; hence that > + * the status can only be cleared when the interrupt has been serviced. > + */ [...] See my comment about the kernel-doc from the following: https://lore.kernel.org/linux-pci/YDZWUGcKet%2FlNWlF@rocinante/ [...] > + if (err) { > + dev_err(dev, "failed to init PCIe IRQ domain\n"); > + return err; > + } [...] Just a nitpick. What about using "initialize" in the above? Krzysztof _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10A24C433E0 for ; Wed, 24 Feb 2021 14:26:21 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9145264DD3 for ; Wed, 24 Feb 2021 14:26:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9145264DD3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xxJ51WmUA8my/Q4938hH58fxHEylWGLcwVvJbzbwPEY=; b=c3anJFXnjXXjhPyuQT3XkmfMw YIclqG2maNCZNZE02GM3HDBNgvzaHMHGiIXfRo2VpoZSeNPwkKmybXDZosKq9J00YNXAGsQrrbiD6 jGN4RHZzobbOxe1LE6+Ht21RAbXOar78E1OEXVgheu0luI9aJx8N0MHulRRxIXiGAU9Psjx2+zK+0 wplg/9Aah5SF00xu6OGPF1iBH+3QikC3VZB9BGDAsPSwWXc2/iMyPaYaZUAyZTeH//JEGGFcx8YZT ORaSVg2CZfw1IURfGaknAnZM386LrAS8sWWlJM8xp9jsqP9SleD31gguQ1/MChqmuA7afaEQuF5vn GzTFnwR9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEv6A-00032t-Ih; Wed, 24 Feb 2021 14:25:06 +0000 Received: from mail-wm1-f52.google.com ([209.85.128.52]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEv67-00031f-2S; Wed, 24 Feb 2021 14:25:04 +0000 Received: by mail-wm1-f52.google.com with SMTP id u125so1971871wmg.4; Wed, 24 Feb 2021 06:25:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yNOTeF74AEVCmwolAA0/8VTyL+nE8bLyKqVdo+FWMqY=; b=bzPnGkZoRInOJNVuI7wJLvh89FUpMGzziYXVx6gm7EbZpaTNq1VAtMz2sl2aCUbjue JFxen6cW9GNKnYdVYwhMSAywil0CP94i5QGvqguAxqDHGmg0FqwZtLb4hwTkQKphCl0I pVUvdyMyo0x0Wi4cAgTxhiKEWR3qb1/+GrCDMIuwYMzWWYBZjuxQR+YO+nEzCFa+ZA+n dCPUy8YHlFqXRAk/q5+hv6OvRF0aH9HAgAkTcDt8BnVjMOaxBGSjSMZ3v8NeoDv7SY1i HDdQNxpME8hOcNxh4m7+OVspAbQtYRh8WIkHeMeRu2xI0IlHzUWRTBJsb0h+FM/GVkJY e36A== X-Gm-Message-State: AOAM530KcBJ0D+rUTXpzXxLho5TkI9wbGtDIuARVpQVK/MmzCWcIbBjT zgv4prg8cRwz5XtAh0d+vd4= X-Google-Smtp-Source: ABdhPJxfrJvj1Nu7atjaQwkrtJNZuIvIcIcghN5f788Gg2oxt+yrdZvub8CkWecyTONsxU0eMBnWow== X-Received: by 2002:a1c:e041:: with SMTP id x62mr3285059wmg.95.1614176701475; Wed, 24 Feb 2021 06:25:01 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id j16sm3898710wra.17.2021.02.24.06.25.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Feb 2021 06:25:01 -0800 (PST) Date: Wed, 24 Feb 2021 15:24:59 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Jianjun Wang Subject: Re: [v8,4/7] PCI: mediatek-gen3: Add INTx support Message-ID: References: <20210224061132.26526-1-jianjun.wang@mediatek.com> <20210224061132.26526-5-jianjun.wang@mediatek.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210224061132.26526-5-jianjun.wang@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210224_092503_126753_F53440AB X-CRM114-Status: GOOD ( 11.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org, Lorenzo Pieralisi , Rex-BC.Chen@mediatek.com, qizhong.cheng@mediatek.com, chuanjia.liu@mediatek.com, maz@kernel.org, drinkcat@chromium.org, Ryder Lee , linux-kernel@vger.kernel.org, sin_jieyang@mediatek.com, Sj Huang , Rob Herring , Bjorn Helgaas , Philipp Zabel , linux-pci@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, anson.chuang@mediatek.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jianjun, [...] > +/** > + * mtk_intx_eoi > + * @data: pointer to chip specific data > + * > + * As an emulated level IRQ, its interrupt status will remain > + * until the corresponding de-assert message is received; hence that > + * the status can only be cleared when the interrupt has been serviced. > + */ [...] See my comment about the kernel-doc from the following: https://lore.kernel.org/linux-pci/YDZWUGcKet%2FlNWlF@rocinante/ [...] > + if (err) { > + dev_err(dev, "failed to init PCIe IRQ domain\n"); > + return err; > + } [...] Just a nitpick. What about using "initialize" in the above? Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel