From: Greg KH <gregkh@linuxfoundation.org>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
open list <linux-kernel@vger.kernel.org>,
stable@vger.kernel.org, olteanv@gmail.com, sashal@kernel.org
Subject: Re: [PATCH stable-5.9.y] net: dsa: b53: Correct learning for standalone ports
Date: Thu, 25 Feb 2021 09:16:32 +0100 [thread overview]
Message-ID: <YDdc4PlMJjPhivLv@kroah.com> (raw)
In-Reply-To: <20210225010956.946545-6-f.fainelli@gmail.com>
On Wed, Feb 24, 2021 at 05:09:54PM -0800, Florian Fainelli wrote:
> Standalone ports should not have learning enabled since all the frames
> are always copied to the CPU port. This is particularly important in
> case an user-facing port intentionally spoofs the CPU port's MAC
> address. With learning enabled we would end up with the switch having
> incorrectly learned the address of the CPU port which typically results
> in a complete break down of network connectivity until the address
> learned ages out and gets re-learned, from the correct port this time.
>
> There was no control of the BR_LEARNING flag until upstream commit
> 4098ced4680a485c5953f60ac63dff19f3fb3d42 ("Merge branch 'brport-flags'")
> which is why we default to enabling learning when the ports gets added
> as a bridge member.
>
> Fixes: 967dd82ffc52 ("net: dsa: b53: Add support for Broadcom RoboSwitch")
> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/dsa/b53/b53_common.c | 18 ++++++++++++++++++
> drivers/net/dsa/b53/b53_regs.h | 1 +
> drivers/net/dsa/bcm_sf2.c | 15 +--------------
> 3 files changed, 20 insertions(+), 14 deletions(-)
Note, 5.9.y and 5.8.y are long end-of-life. You can see that at the
front page of www.kernel.org if you ever are curious about it.
thanks,
greg k-h
next prev parent reply other threads:[~2021-02-25 8:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 1:08 [PATCH stable 0/8] net: dsa: b53: Correct learning for standalone ports Florian Fainelli
2021-02-25 1:09 ` [PATCH stable-4.9.y] " Florian Fainelli
2021-02-25 1:09 ` [PATCH stable-4.14.y] " Florian Fainelli
2021-02-25 1:09 ` [PATCH stable-4.19.y] " Florian Fainelli
2021-02-25 1:09 ` [PATCH stable-5.4.y] " Florian Fainelli
2021-02-25 1:09 ` [PATCH stable-5.8.y] " Florian Fainelli
2021-02-25 1:09 ` [PATCH stable-5.9.y] " Florian Fainelli
2021-02-25 8:16 ` Greg KH [this message]
2021-02-25 1:09 ` [PATCH stable-5.10.y] " Florian Fainelli
2021-02-25 1:09 ` [PATCH stable-5.11.y] " Florian Fainelli
2021-02-25 8:15 ` [PATCH stable 0/8] " Greg KH
2021-02-25 16:53 ` Florian Fainelli
2021-02-25 17:11 ` Greg KH
2021-02-25 18:31 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDdc4PlMJjPhivLv@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.