All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 06/13] xfs: move log iovec alignment to preparation function
Date: Thu, 25 Feb 2021 10:39:32 +0100	[thread overview]
Message-ID: <YDdwVEodKSIZWkg0@infradead.org> (raw)
In-Reply-To: <20210224063459.3436852-7-david@fromorbit.com>

On Wed, Feb 24, 2021 at 05:34:52PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> To include log op headers directly into the log iovec regions that
> the ophdrs wrap, we need to move the buffer alignment code from
> xlog_finish_iovec() to xlog_prepare_iovec(). This is because the
> xlog_op_header is only 12 bytes long, and we need the buffer that
> the caller formats their data into to be 8 byte aligned.
> 
> Hence once we start prepending the ophdr in xlog_prepare_iovec(), we
> are going to need to manage the padding directly to ensure that the
> buffer pointer returned is correctly aligned.
> 
> Signed-off-by: Dave Chinner <dchinner@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2021-02-25  9:43 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-24  6:34 [PATCH 0/13] xfs: rewrite xlog_write() Dave Chinner
2021-02-24  6:34 ` [PATCH 01/13] xfs: factor out the CIL transaction header building Dave Chinner
2021-02-25  9:12   ` Christoph Hellwig
2021-02-24  6:34 ` [PATCH 02/13] xfs: only CIL pushes require a start record Dave Chinner
2021-02-25  9:15   ` Christoph Hellwig
2021-02-25 22:11     ` Dave Chinner
2021-02-24  6:34 ` [PATCH 03/13] xfs: embed the xlog_op_header in the unmount record Dave Chinner
2021-02-25  9:26   ` Christoph Hellwig
2021-02-24  6:34 ` [PATCH 04/13] " Dave Chinner
2021-02-25  9:38   ` Christoph Hellwig
2021-02-25 22:13     ` Dave Chinner
2021-02-26  2:57   ` Darrick J. Wong
2021-02-26  4:23     ` Dave Chinner
2021-02-24  6:34 ` [PATCH 05/13] xfs: log tickets don't need log client id Dave Chinner
2021-02-25  9:20   ` Christoph Hellwig
2021-02-24  6:34 ` [PATCH 06/13] xfs: move log iovec alignment to preparation function Dave Chinner
2021-02-25  9:39   ` Christoph Hellwig [this message]
2021-02-24  6:34 ` [PATCH 07/13] xfs: reserve space and initialise xlog_op_header in item formatting Dave Chinner
2021-02-25 18:27   ` Christoph Hellwig
2021-02-25 22:16     ` Dave Chinner
2021-02-24  6:34 ` [PATCH 08/13] xfs: log ticket region debug is largely useless Dave Chinner
2021-02-25  9:21   ` Christoph Hellwig
2021-02-24  6:34 ` [PATCH 09/13] xfs: pass lv chain length and size into xlog_write() Dave Chinner
2021-02-25 18:30   ` Christoph Hellwig
2021-02-24  6:34 ` [PATCH 10/13] xfs: introduce xlog_write_single() Dave Chinner
2021-02-25 18:43   ` Christoph Hellwig
2021-02-25 22:21     ` Dave Chinner
2021-02-24  6:34 ` [PATCH 11/13] xfs:_introduce xlog_write_partial() Dave Chinner
2021-02-25 18:54   ` Christoph Hellwig
2021-02-25 22:23     ` Dave Chinner
2021-02-24  6:34 ` [PATCH 12/13] xfs: xlog_write() no longer needs contwr state Dave Chinner
2021-02-24  6:34 ` [PATCH 13/13] xfs: CIL context doesn't need to count iovecs Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YDdwVEodKSIZWkg0@infradead.org \
    --to=hch@infradead.org \
    --cc=david@fromorbit.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.