From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 546A4C433E0 for ; Fri, 26 Feb 2021 12:48:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 062FB64DFF for ; Fri, 26 Feb 2021 12:48:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230144AbhBZMsW (ORCPT ); Fri, 26 Feb 2021 07:48:22 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbhBZMsU (ORCPT ); Fri, 26 Feb 2021 07:48:20 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5389DC061574; Fri, 26 Feb 2021 04:47:40 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 47D59580; Fri, 26 Feb 2021 13:47:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1614343654; bh=//WROYy2yrpIokeweAuXJ+Feiva/VBmtXT/9QdWXFV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IXeoh41MUKm4uY1NPZ3OVkVek/zinxj0KfnlN3R+Zoq/rSdF4U/EzYzmefZt4FWBc 8IxxuWZDX7hHWAl/HnEisplVFPjvlJfXsQar1mjr4OWASxAUoy3kkNJoGDtoQfJOnf YguGwpmyYFBUfq6MoNtGnus29S09gDXBnB7xCbWI= Date: Fri, 26 Feb 2021 14:47:05 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Rob Herring , Arnd Bergmann , Geert Uytterhoeven , Greg Kroah-Hartman , linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Will Deacon , Chris Paterson , Prabhakar Mahadev Lad , Phil Edworthy , Dirk Behme , Peter Erben Subject: Re: [PATCH 5/7] arm64: dts: renesas: r8a77990: Add DAB support Message-ID: References: <20210225225147.29920-1-fabrizio.castro.jz@renesas.com> <20210225225147.29920-6-fabrizio.castro.jz@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210225225147.29920-6-fabrizio.castro.jz@renesas.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabrizio, Thank you for the patch. On Thu, Feb 25, 2021 at 10:51:45PM +0000, Fabrizio Castro wrote: > R-Car E3 (a.k.a. r8a77990) comes with the DAB hardware accelerator. > This patch adds SoC specific support. > > Signed-off-by: Fabrizio Castro > --- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > index 5010f23fafcc..5a6b835f137a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > @@ -963,6 +963,18 @@ ipmmu_vp0: iommu@fe990000 { > #iommu-cells = <1>; > }; > > + dab: dab@e6730000 { > + compatible = "renesas,dab-r8a77990", > + "renesas,rcar-gen3-dab"; > + reg = <0x00 0xe6730000 0x00 0x120>; We often express the first cell as just 0. reg = <0 0xe6730000 0 0x120>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 1016>; As the clock isn't documented in the documentation, I can't verify this of the resets property :-S > + clock-names = "dab"; I'll comment on the clock name in the DT bindings. Reviewed-by: Laurent Pinchart > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 1016>; > + status = "disabled"; > + }; > + > avb: ethernet@e6800000 { > compatible = "renesas,etheravb-r8a77990", > "renesas,etheravb-rcar-gen3"; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08C98C433E0 for ; Fri, 26 Feb 2021 12:48:57 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9480F64DFF for ; Fri, 26 Feb 2021 12:48:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9480F64DFF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wahq/ACaFpkmTmw2mFRjTPZOVn82nq6xLDNrvQNJb9U=; b=GGK6ZygR0kKWDBqkiGmPnMAZ4 f6blsoN5E4UyCzZyXY0n06xSYfWmmriv8sjWOjc23WanXMau/muK6YSVfpG7CtMxx62deblPqR1Aq aMBccRW+gza6ka1GZsAM17uCXszO82lE48zoJ7u1j6YKVwlOC85MFdnh8cHxOngHlS4ZUUZ5sKeQz mT7/ToqQDpO4SpQeWIAMv9aPnU/7vYjiMOOPgScWXxJKC9iGQOFIhac78XjdpF9+uMxgd6sY63hn+ DSU9FB9ByorK0SicvT1DFg5012LglJShnfRldJDaF5PkZDWSV5Iev0Ak/4qg2LTPyhfOAexik2F0N C1eHAkwTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFcWz-0005dO-TD; Fri, 26 Feb 2021 12:47:41 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFcWv-0005cq-S2 for linux-arm-kernel@lists.infradead.org; Fri, 26 Feb 2021 12:47:39 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 47D59580; Fri, 26 Feb 2021 13:47:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1614343654; bh=//WROYy2yrpIokeweAuXJ+Feiva/VBmtXT/9QdWXFV4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IXeoh41MUKm4uY1NPZ3OVkVek/zinxj0KfnlN3R+Zoq/rSdF4U/EzYzmefZt4FWBc 8IxxuWZDX7hHWAl/HnEisplVFPjvlJfXsQar1mjr4OWASxAUoy3kkNJoGDtoQfJOnf YguGwpmyYFBUfq6MoNtGnus29S09gDXBnB7xCbWI= Date: Fri, 26 Feb 2021 14:47:05 +0200 From: Laurent Pinchart To: Fabrizio Castro Subject: Re: [PATCH 5/7] arm64: dts: renesas: r8a77990: Add DAB support Message-ID: References: <20210225225147.29920-1-fabrizio.castro.jz@renesas.com> <20210225225147.29920-6-fabrizio.castro.jz@renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210225225147.29920-6-fabrizio.castro.jz@renesas.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210226_074738_336472_1CD59DC9 X-CRM114-Status: GOOD ( 17.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Chris Paterson , Phil Edworthy , Catalin Marinas , Arnd Bergmann , Geert Uytterhoeven , Greg Kroah-Hartman , Peter Erben , linux-kernel@vger.kernel.org, Prabhakar Mahadev Lad , linux-renesas-soc@vger.kernel.org, Dirk Behme , Rob Herring , linux-api@vger.kernel.org, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabrizio, Thank you for the patch. On Thu, Feb 25, 2021 at 10:51:45PM +0000, Fabrizio Castro wrote: > R-Car E3 (a.k.a. r8a77990) comes with the DAB hardware accelerator. > This patch adds SoC specific support. > > Signed-off-by: Fabrizio Castro > --- > arch/arm64/boot/dts/renesas/r8a77990.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > index 5010f23fafcc..5a6b835f137a 100644 > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > @@ -963,6 +963,18 @@ ipmmu_vp0: iommu@fe990000 { > #iommu-cells = <1>; > }; > > + dab: dab@e6730000 { > + compatible = "renesas,dab-r8a77990", > + "renesas,rcar-gen3-dab"; > + reg = <0x00 0xe6730000 0x00 0x120>; We often express the first cell as just 0. reg = <0 0xe6730000 0 0x120>; > + interrupts = ; > + clocks = <&cpg CPG_MOD 1016>; As the clock isn't documented in the documentation, I can't verify this of the resets property :-S > + clock-names = "dab"; I'll comment on the clock name in the DT bindings. Reviewed-by: Laurent Pinchart > + power-domains = <&sysc R8A77990_PD_ALWAYS_ON>; > + resets = <&cpg 1016>; > + status = "disabled"; > + }; > + > avb: ethernet@e6800000 { > compatible = "renesas,etheravb-r8a77990", > "renesas,etheravb-rcar-gen3"; -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel