From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA52CC433DB for ; Fri, 26 Feb 2021 12:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 96D8A64DD0 for ; Fri, 26 Feb 2021 12:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230281AbhBZMuJ (ORCPT ); Fri, 26 Feb 2021 07:50:09 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229545AbhBZMt6 (ORCPT ); Fri, 26 Feb 2021 07:49:58 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5F752C061574; Fri, 26 Feb 2021 04:49:18 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD370580; Fri, 26 Feb 2021 13:49:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1614343757; bh=x5nZBQVf0wlRzwxr5wF1qzN/XY/UC6gmCNzOn6eKkyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eugQ5CXUG/1ciTyosRm7hWzCJsd7tzZ178f+djJByvIgxhyY2EdKTvBOivgrse29M uRYT6b2uwtmrP3RiQ7VdqUhDLkd20KVTjhheJ0HligW+KOgKqj2hRa6oXKK9E+exLn tbEIxBiLELWhg5mCw2YhhFvvkzWpa5C2vZWB43I4= Date: Fri, 26 Feb 2021 14:48:49 +0200 From: Laurent Pinchart To: Fabrizio Castro Cc: Geert Uytterhoeven , Rob Herring , Arnd Bergmann , Greg Kroah-Hartman , Linux-Renesas , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , Linux API , Linux Kernel Mailing List , Catalin Marinas , Will Deacon , Chris Paterson , Prabhakar Mahadev Lad , Phil Edworthy , Dirk Behme , Peter Erben Subject: Re: [PATCH 2/7] clk: renesas: r8a77965: Add DAB clock Message-ID: References: <20210225225147.29920-1-fabrizio.castro.jz@renesas.com> <20210225225147.29920-3-fabrizio.castro.jz@renesas.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabrizio, Thank you for the patch. On Fri, Feb 26, 2021 at 09:45:20AM +0100, Geert Uytterhoeven wrote: > On Thu, Feb 25, 2021 at 11:53 PM Fabrizio Castro wrote: > > This patch adds the DAB clock to the R8A77965 SoC. > > > > Signed-off-by: Fabrizio Castro > > Thanks for your patch! > > > --- a/drivers/clk/renesas/r8a77965-cpg-mssr.c > > +++ b/drivers/clk/renesas/r8a77965-cpg-mssr.c > > @@ -250,6 +250,7 @@ static const struct mssr_mod_clk r8a77965_mod_clks[] __initconst = { > > DEF_MOD("ssi2", 1013, MOD_CLK_ID(1005)), > > DEF_MOD("ssi1", 1014, MOD_CLK_ID(1005)), > > DEF_MOD("ssi0", 1015, MOD_CLK_ID(1005)), > > + DEF_MOD("dab", 1016, R8A77965_CLK_S0D6), > > Unfortunately this bit is not documented in the R-Car Gen3 Hardware > User's Manual, so I have to trust you on this. > > While it's not unusual that the same module on R-Car E3 and M3-N > has different parent clocks, it does strike me as odd that S0D6 on M3-N > runs at 133 MHz, while S3D1 on E3 runs at 266 MHz. > Probably it doesn't matter that much, as your driver doesn't care > about the actual clock rate. I have the exact same concerns, here and for 1/7. > > DEF_MOD("scu-all", 1017, R8A77965_CLK_S3D4), > > DEF_MOD("scu-dvc1", 1018, MOD_CLK_ID(1017)), > > DEF_MOD("scu-dvc0", 1019, MOD_CLK_ID(1017)), -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63541C433E0 for ; Fri, 26 Feb 2021 12:50:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D68F2600CC for ; Fri, 26 Feb 2021 12:50:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D68F2600CC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7QSmHi/jv3vHESeqJ2FB0T0y03zvZ9s7njT84J4AGe8=; b=Nzac4C+IvEWzcmoBbLySyxGyS W8kf23CoetQxGeUBB8l91zUt7IoxgY2a5yGoq16ykQ3bH62FsxWxL9rWBv4ai9H+S/DzNYIuqa1Sl zkA1EsPnoESARczWCt7yofY51LS6MFX4eja3olVJ8oQu4UEin+g1IzbTgm5lhgYshHQM7L7fbueun irF/u/D9DYZKHymebdDXkt+OvXlF53Fk3+T8MSXQdAYv8QlGU/3CNUDLsr3ADJRmStP60OLlbL04P L4uFp9e7bzO8Uwl/Usgl/6AYW0thn9CRdPrtIApQ//RpU34rQzMm/XNbHsqBdion4KbjosM3Noyg2 NIIBRn8jg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFcYa-0005qd-SD; Fri, 26 Feb 2021 12:49:20 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lFcYX-0005pr-WD for linux-arm-kernel@lists.infradead.org; Fri, 26 Feb 2021 12:49:18 +0000 Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD370580; Fri, 26 Feb 2021 13:49:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1614343757; bh=x5nZBQVf0wlRzwxr5wF1qzN/XY/UC6gmCNzOn6eKkyg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=eugQ5CXUG/1ciTyosRm7hWzCJsd7tzZ178f+djJByvIgxhyY2EdKTvBOivgrse29M uRYT6b2uwtmrP3RiQ7VdqUhDLkd20KVTjhheJ0HligW+KOgKqj2hRa6oXKK9E+exLn tbEIxBiLELWhg5mCw2YhhFvvkzWpa5C2vZWB43I4= Date: Fri, 26 Feb 2021 14:48:49 +0200 From: Laurent Pinchart To: Fabrizio Castro Subject: Re: [PATCH 2/7] clk: renesas: r8a77965: Add DAB clock Message-ID: References: <20210225225147.29920-1-fabrizio.castro.jz@renesas.com> <20210225225147.29920-3-fabrizio.castro.jz@renesas.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210226_074918_151388_D805EFE7 X-CRM114-Status: GOOD ( 20.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Chris Paterson , Phil Edworthy , Catalin Marinas , Arnd Bergmann , Greg Kroah-Hartman , Peter Erben , Linux Kernel Mailing List , Prabhakar Mahadev Lad , Linux-Renesas , Dirk Behme , Rob Herring , Geert Uytterhoeven , Linux API , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Fabrizio, Thank you for the patch. On Fri, Feb 26, 2021 at 09:45:20AM +0100, Geert Uytterhoeven wrote: > On Thu, Feb 25, 2021 at 11:53 PM Fabrizio Castro wrote: > > This patch adds the DAB clock to the R8A77965 SoC. > > > > Signed-off-by: Fabrizio Castro > > Thanks for your patch! > > > --- a/drivers/clk/renesas/r8a77965-cpg-mssr.c > > +++ b/drivers/clk/renesas/r8a77965-cpg-mssr.c > > @@ -250,6 +250,7 @@ static const struct mssr_mod_clk r8a77965_mod_clks[] __initconst = { > > DEF_MOD("ssi2", 1013, MOD_CLK_ID(1005)), > > DEF_MOD("ssi1", 1014, MOD_CLK_ID(1005)), > > DEF_MOD("ssi0", 1015, MOD_CLK_ID(1005)), > > + DEF_MOD("dab", 1016, R8A77965_CLK_S0D6), > > Unfortunately this bit is not documented in the R-Car Gen3 Hardware > User's Manual, so I have to trust you on this. > > While it's not unusual that the same module on R-Car E3 and M3-N > has different parent clocks, it does strike me as odd that S0D6 on M3-N > runs at 133 MHz, while S3D1 on E3 runs at 266 MHz. > Probably it doesn't matter that much, as your driver doesn't care > about the actual clock rate. I have the exact same concerns, here and for 1/7. > > DEF_MOD("scu-all", 1017, R8A77965_CLK_S3D4), > > DEF_MOD("scu-dvc1", 1018, MOD_CLK_ID(1017)), > > DEF_MOD("scu-dvc0", 1019, MOD_CLK_ID(1017)), -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel