From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7778C433DB for ; Sun, 28 Feb 2021 04:53:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7458F64E4B for ; Sun, 28 Feb 2021 04:53:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230206AbhB1ExS (ORCPT ); Sat, 27 Feb 2021 23:53:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:55584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230190AbhB1ExR (ORCPT ); Sat, 27 Feb 2021 23:53:17 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 98E9D64E10; Sun, 28 Feb 2021 04:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614487955; bh=TPuIvHd6Bs3bRcf4BzsMlYT1Gou/E7eosJtAO9spevc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XWT16qHiyEgYEN0ob4FNSqQgnCfQ43mP460op4rpQT66dn4Fgs7IsUpqLG2JNYtDy lyTR/iNVLSrRWSzYlY2V6Hbv09osFS66gmwtmch8TPIB2U8morsrtYSSRK61UNk0bW koQt8M22CxbzZBby7YoAlZVS9w1roVZXprnWrOYpE1ykxHUGfW98OxtaZGDbbQXER7 K3MtK7AdhMjg7M0pr11zcGILqHTaddZGeGEbZxoSP0ezV7FYO1SIBsr0Lcngk7JU0Q W2DcSSDKOpezdbVlCe4Knz4sCn3RKOCl9S6Eobzr/W0lf8hFBiNj/HdVkjapTh2tsH bZeaSrB1i/Slg== Date: Sat, 27 Feb 2021 20:52:34 -0800 From: Jaegeuk Kim To: Eric Biggers Cc: heyunlei 00015531 , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, bintian.wang@hihonor.com, linux-fscrypt@vger.kernel.org Subject: Re: [PATCH] f2fs: fsverity: Truncate cache pages if set verity failed Message-ID: References: <20210223112425.19180-1-heyunlei@hihonor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-fscrypt@vger.kernel.org Hi Yunlei, Could you please post another version to have all the suggestions? :) Thanks, On 02/25, Eric Biggers wrote: > On Fri, Feb 26, 2021 at 09:42:33AM +0800, heyunlei 00015531 wrote: > > > > 在 2021/2/25 7:11, Eric Biggers 写道: > > > On Wed, Feb 24, 2021 at 03:02:52PM -0800, Eric Biggers wrote: > > > > Hi Yunlei, > > > > > > > > On Wed, Feb 24, 2021 at 09:16:24PM +0800, Chao Yu wrote: > > > > > Hi Yunlei, > > > > > > > > > > On 2021/2/23 19:24, heyunlei wrote: > > > > > > If file enable verity failed, should truncate anything wrote > > > > > > past i_size, including cache pages. > > > > > +Cc Eric, > > > > > > > > > > After failure of enabling verity, we will see verity metadata if we truncate > > > > > file to larger size later? > > > > > > > > > > Thanks, > > Hi Eric， > > > > > > Signed-off-by: heyunlei > > > > > > --- > > > > > > fs/f2fs/verity.c | 4 +++- > > > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > > > > > diff --git a/fs/f2fs/verity.c b/fs/f2fs/verity.c > > > > > > index 054ec852b5ea..f1f9b9361a71 100644 > > > > > > --- a/fs/f2fs/verity.c > > > > > > +++ b/fs/f2fs/verity.c > > > > > > @@ -170,8 +170,10 @@ static int f2fs_end_enable_verity(struct file *filp, const void *desc, > > > > > > } > > > > > > /* If we failed, truncate anything we wrote past i_size. */ > > > > > > - if (desc == NULL || err) > > > > > > + if (desc == NULL || err) { > > > > > > + truncate_inode_pages(inode->i_mapping, inode->i_size); > > > > > > f2fs_truncate(inode); > > > > > > + } > > > > > > clear_inode_flag(inode, FI_VERITY_IN_PROGRESS); > > > > > > > > By the way，should  we consider  set xattr failed? > > > > Yes, that seems to be another oversight. Similarly for ext4, if > ext4_journal_start(), ext4_orphan_del(), or ext4_reserve_inode_write() fails. > > I think the right fix is to move the truncation to the end of the function. > > - Eric From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17E4EC433E0 for ; Sun, 28 Feb 2021 04:53:02 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A0F5C64DA1 for ; Sun, 28 Feb 2021 04:53:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A0F5C64DA1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lGE4h-00060l-Na; Sun, 28 Feb 2021 04:52:59 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lGE4g-00060G-7G for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Feb 2021 04:52:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Qu1td/Jn27TzGu8aY3Kazr0TbCjq4IzdD5q9/9nFniw=; b=jhCZCt+guhZTsWvPgm1bdm3Axd VrMkUwiVUR5wr13fVnTsjnK6eIz/LJi9iQngpctkOZX/vvskoz8FAICeMPk3VXnR/DqGUjS20ShGi UgrG76YZjxVkBAP5Kd6fS2MXuWHM9MdU3dIDY0YU7U9I5eWXzIfTj4CGo6e2xovLc190=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Qu1td/Jn27TzGu8aY3Kazr0TbCjq4IzdD5q9/9nFniw=; b=dWhWq+yi4IXxNESyC4jcLqHCZy VBa1WIZl97jBB0YcUZYbgYLRvlEhUtArgVcnr73K4CxBK/8gvp2CiTzo6pfXa3esasByOZfcZMiXS KB7HD0KF7FH0H3AkJ1UL7YpKTTwAKvZStYgojXO3hf4usKTf4B5bwhtP9aHbR9KeActs=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lGE4V-0005ft-35 for linux-f2fs-devel@lists.sourceforge.net; Sun, 28 Feb 2021 04:52:54 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 98E9D64E10; Sun, 28 Feb 2021 04:52:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1614487955; bh=TPuIvHd6Bs3bRcf4BzsMlYT1Gou/E7eosJtAO9spevc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XWT16qHiyEgYEN0ob4FNSqQgnCfQ43mP460op4rpQT66dn4Fgs7IsUpqLG2JNYtDy lyTR/iNVLSrRWSzYlY2V6Hbv09osFS66gmwtmch8TPIB2U8morsrtYSSRK61UNk0bW koQt8M22CxbzZBby7YoAlZVS9w1roVZXprnWrOYpE1ykxHUGfW98OxtaZGDbbQXER7 K3MtK7AdhMjg7M0pr11zcGILqHTaddZGeGEbZxoSP0ezV7FYO1SIBsr0Lcngk7JU0Q W2DcSSDKOpezdbVlCe4Knz4sCn3RKOCl9S6Eobzr/W0lf8hFBiNj/HdVkjapTh2tsH bZeaSrB1i/Slg== Date: Sat, 27 Feb 2021 20:52:34 -0800 From: Jaegeuk Kim To: Eric Biggers Message-ID: References: <20210223112425.19180-1-heyunlei@hihonor.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1lGE4V-0005ft-35 Subject: Re: [f2fs-dev] [PATCH] f2fs: fsverity: Truncate cache pages if set verity failed X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fscrypt@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net SGkgWXVubGVpLAoKQ291bGQgeW91IHBsZWFzZSBwb3N0IGFub3RoZXIgdmVyc2lvbiB0byBoYXZl IGFsbCB0aGUgc3VnZ2VzdGlvbnM/IDopCgpUaGFua3MsCgpPbiAwMi8yNSwgRXJpYyBCaWdnZXJz IHdyb3RlOgo+IE9uIEZyaSwgRmViIDI2LCAyMDIxIGF0IDA5OjQyOjMzQU0gKzA4MDAsIGhleXVu bGVpIDAwMDE1NTMxIHdyb3RlOgo+ID4gCj4gPiDlnKggMjAyMS8yLzI1IDc6MTEsIEVyaWMgQmln Z2VycyDlhpnpgZM6Cj4gPiA+IE9uIFdlZCwgRmViIDI0LCAyMDIxIGF0IDAzOjAyOjUyUE0gLTA4 MDAsIEVyaWMgQmlnZ2VycyB3cm90ZToKPiA+ID4gPiBIaSBZdW5sZWksCj4gPiA+ID4gCj4gPiA+ ID4gT24gV2VkLCBGZWIgMjQsIDIwMjEgYXQgMDk6MTY6MjRQTSArMDgwMCwgQ2hhbyBZdSB3cm90 ZToKPiA+ID4gPiA+IEhpIFl1bmxlaSwKPiA+ID4gPiA+IAo+ID4gPiA+ID4gT24gMjAyMS8yLzIz IDE5OjI0LCBoZXl1bmxlaSB3cm90ZToKPiA+ID4gPiA+ID4gSWYgZmlsZSBlbmFibGUgdmVyaXR5 IGZhaWxlZCwgc2hvdWxkIHRydW5jYXRlIGFueXRoaW5nIHdyb3RlCj4gPiA+ID4gPiA+IHBhc3Qg aV9zaXplLCBpbmNsdWRpbmcgY2FjaGUgcGFnZXMuCj4gPiA+ID4gPiArQ2MgRXJpYywKPiA+ID4g PiA+IAo+ID4gPiA+ID4gQWZ0ZXIgZmFpbHVyZSBvZiBlbmFibGluZyB2ZXJpdHksIHdlIHdpbGwg c2VlIHZlcml0eSBtZXRhZGF0YSBpZiB3ZSB0cnVuY2F0ZQo+ID4gPiA+ID4gZmlsZSB0byBsYXJn ZXIgc2l6ZSBsYXRlcj8KPiA+ID4gPiA+IAo+ID4gPiA+ID4gVGhhbmtzLAo+ID4gSGkgRXJpY++8 jAo+ID4gPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBoZXl1bmxlaSA8aGV5dW5sZWlAaGlob25vci5j b20+Cj4gPiA+ID4gPiA+IC0tLQo+ID4gPiA+ID4gPiAgICBmcy9mMmZzL3Zlcml0eS5jIHwgNCAr KystCj4gPiA+ID4gPiA+ICAgIDEgZmlsZSBjaGFuZ2VkLCAzIGluc2VydGlvbnMoKyksIDEgZGVs ZXRpb24oLSkKPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+IGRpZmYgLS1naXQgYS9mcy9mMmZzL3Zl cml0eS5jIGIvZnMvZjJmcy92ZXJpdHkuYwo+ID4gPiA+ID4gPiBpbmRleCAwNTRlYzg1MmI1ZWEu LmYxZjliOTM2MWE3MSAxMDA2NDQKPiA+ID4gPiA+ID4gLS0tIGEvZnMvZjJmcy92ZXJpdHkuYwo+ ID4gPiA+ID4gPiArKysgYi9mcy9mMmZzL3Zlcml0eS5jCj4gPiA+ID4gPiA+IEBAIC0xNzAsOCAr MTcwLDEwIEBAIHN0YXRpYyBpbnQgZjJmc19lbmRfZW5hYmxlX3Zlcml0eShzdHJ1Y3QgZmlsZSAq ZmlscCwgY29uc3Qgdm9pZCAqZGVzYywKPiA+ID4gPiA+ID4gICAgCX0KPiA+ID4gPiA+ID4gICAg CS8qIElmIHdlIGZhaWxlZCwgdHJ1bmNhdGUgYW55dGhpbmcgd2Ugd3JvdGUgcGFzdCBpX3NpemUu ICovCj4gPiA+ID4gPiA+IC0JaWYgKGRlc2MgPT0gTlVMTCB8fCBlcnIpCj4gPiA+ID4gPiA+ICsJ aWYgKGRlc2MgPT0gTlVMTCB8fCBlcnIpIHsKPiA+ID4gPiA+ID4gKwkJdHJ1bmNhdGVfaW5vZGVf cGFnZXMoaW5vZGUtPmlfbWFwcGluZywgaW5vZGUtPmlfc2l6ZSk7Cj4gPiA+ID4gPiA+ICAgIAkJ ZjJmc190cnVuY2F0ZShpbm9kZSk7Cj4gPiA+ID4gPiA+ICsJfQo+ID4gPiA+ID4gPiAgICAJY2xl YXJfaW5vZGVfZmxhZyhpbm9kZSwgRklfVkVSSVRZX0lOX1BST0dSRVNTKTsKPiA+ID4gPiA+ID4g Cj4gPiBCeSB0aGUgd2F577yMc2hvdWxkwqAgd2UgY29uc2lkZXLCoCBzZXQgeGF0dHIgZmFpbGVk Pwo+ID4gCj4gCj4gWWVzLCB0aGF0IHNlZW1zIHRvIGJlIGFub3RoZXIgb3ZlcnNpZ2h0LiAgU2lt aWxhcmx5IGZvciBleHQ0LCBpZgo+IGV4dDRfam91cm5hbF9zdGFydCgpLCBleHQ0X29ycGhhbl9k ZWwoKSwgb3IgZXh0NF9yZXNlcnZlX2lub2RlX3dyaXRlKCkgZmFpbHMuCj4gCj4gSSB0aGluayB0 aGUgcmlnaHQgZml4IGlzIHRvIG1vdmUgdGhlIHRydW5jYXRpb24gdG8gdGhlIGVuZCBvZiB0aGUg ZnVuY3Rpb24uCj4gCj4gLSBFcmljCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KTGludXgtZjJmcy1kZXZlbCBtYWlsaW5nIGxpc3QKTGludXgtZjJmcy1k ZXZlbEBsaXN0cy5zb3VyY2Vmb3JnZS5uZXQKaHR0cHM6Ly9saXN0cy5zb3VyY2Vmb3JnZS5uZXQv bGlzdHMvbGlzdGluZm8vbGludXgtZjJmcy1kZXZlbAo=