From: Roman Gushchin <guro@fb.com>
To: Hugh Dickins <hughd@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Vlastimil Babka <vbabka@suse.cz>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/4] mm: no more EINVAL from /proc/sys/vm/stat_refresh
Date: Sun, 28 Feb 2021 16:38:46 -0800 [thread overview]
Message-ID: <YDw3lsR1wkaFLhhX@carbon.dhcp.thefacebook.com> (raw)
In-Reply-To: <alpine.LSU.2.11.2102251510410.13363@eggly.anvils>
On Thu, Feb 25, 2021 at 03:12:10PM -0800, Hugh Dickins wrote:
> EINVAL was good for drawing the refresher's attention to a warning in
> dmesg, but became very tiresome when running test suites scripted with
> "set -e": an underflow from a bug in one feature would cause unrelated
> tests much later to fail, just because their /proc/sys/vm/stat_refresh
> touch failed with that error. Stop doing that.
Totally agree!
>
> Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Roman Gushchin <guro@fb.com>
> ---
>
> mm/vmstat.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> --- vmstat1/mm/vmstat.c 2021-02-25 11:50:36.000000000 -0800
> +++ vmstat2/mm/vmstat.c 2021-02-25 11:56:18.000000000 -0800
> @@ -1844,7 +1844,6 @@ int vmstat_refresh(struct ctl_table *tab
> if (val < 0) {
> pr_warn("%s: %s %ld\n",
> __func__, zone_stat_name(i), val);
> - err = -EINVAL;
> }
> }
> #ifdef CONFIG_NUMA
> @@ -1853,7 +1852,6 @@ int vmstat_refresh(struct ctl_table *tab
> if (val < 0) {
> pr_warn("%s: %s %ld\n",
> __func__, numa_stat_name(i), val);
> - err = -EINVAL;
> }
> }
> #endif
> @@ -1862,11 +1860,8 @@ int vmstat_refresh(struct ctl_table *tab
> if (val < 0) {
> pr_warn("%s: %s %ld\n",
> __func__, node_stat_name(i), val);
> - err = -EINVAL;
> }
> }
> - if (err)
> - return err;
> if (write)
> *ppos += *lenp;
> else
next prev parent reply other threads:[~2021-03-01 0:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-25 23:10 [PATCH 1/4] mm: restore node stat checking in /proc/sys/vm/stat_refresh Hugh Dickins
2021-02-25 23:10 ` Hugh Dickins
2021-02-25 23:12 ` [PATCH 2/4] mm: no more EINVAL from /proc/sys/vm/stat_refresh Hugh Dickins
2021-02-25 23:12 ` Hugh Dickins
2021-03-01 0:38 ` Roman Gushchin [this message]
2021-02-25 23:14 ` [PATCH 3/4] mm: /proc/sys/vm/stat_refresh skip checking known negative stats Hugh Dickins
2021-02-25 23:14 ` Hugh Dickins
2021-03-01 0:53 ` Roman Gushchin
2021-03-01 22:08 ` Hugh Dickins
2021-03-01 22:08 ` Hugh Dickins
2021-03-02 0:34 ` Roman Gushchin
2021-03-02 6:03 ` [PATCH v2 " Hugh Dickins
2021-03-02 6:03 ` Hugh Dickins
2021-03-04 2:25 ` Roman Gushchin
2021-02-25 23:15 ` [PATCH 4/4] mm: /proc//sys/vm/stat_refresh stop checking monotonic numa stats Hugh Dickins
2021-02-25 23:15 ` Hugh Dickins
2021-03-01 0:53 ` Roman Gushchin
2021-03-01 0:37 ` [PATCH 1/4] mm: restore node stat checking in /proc/sys/vm/stat_refresh Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YDw3lsR1wkaFLhhX@carbon.dhcp.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.