From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76186C433E0 for ; Mon, 15 Mar 2021 11:41:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 086AE64DE7 for ; Mon, 15 Mar 2021 11:41:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 086AE64DE7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:36564 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lLlb7-00012t-2k for qemu-devel@archiver.kernel.org; Mon, 15 Mar 2021 07:41:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lLlZ3-0007hl-6b for qemu-devel@nongnu.org; Mon, 15 Mar 2021 07:39:18 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:48465) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lLlYw-0001mG-Tx for qemu-devel@nongnu.org; Mon, 15 Mar 2021 07:39:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615808344; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fiHpG74xB+fNUJbZVvOCCRWI25ZUxJxhjwtnsG1PR40=; b=VDVwIC1T+RhqGCBbSv4DUzZ84814+72GAUbXsQasFO+cMvQ3p6hacUgNHteTrik3SkeLWl QGff8kk1hEHW68zPhY5IYxIiOFsgiUw+qTQgefoA1yGjQlqylsOtm6P9mv7ym1ayKEAP/e mfCtvCk+SYjid8EBnRAbkbI63rKq5eo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-428-_KNGArVTNNG6_QrxWC2jOg-1; Mon, 15 Mar 2021 07:39:02 -0400 X-MC-Unique: _KNGArVTNNG6_QrxWC2jOg-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E3A56184F564; Mon, 15 Mar 2021 11:39:01 +0000 (UTC) Received: from work-vm (ovpn-114-235.ams2.redhat.com [10.36.114.235]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C0D1B5C3E6; Mon, 15 Mar 2021 11:38:50 +0000 (UTC) Date: Mon, 15 Mar 2021 11:38:48 +0000 From: "Dr. David Alan Gilbert" To: Kevin Wolf Subject: Re: [PATCH v3 27/30] hmp: QAPIfy object_add Message-ID: References: <20210308165440.386489-1-kwolf@redhat.com> <20210308165440.386489-28-kwolf@redhat.com> <87pn03rxmq.fsf@dusky.pond.sub.org> <87tupckb7d.fsf@dusky.pond.sub.org> MIME-Version: 1.0 In-Reply-To: User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dgilbert@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=63.128.21.124; envelope-from=dgilbert@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.25, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, thuth@redhat.com, pkrempa@redhat.com, berrange@redhat.com, ehabkost@redhat.com, qemu-block@nongnu.org, libvir-list@redhat.com, jasowang@redhat.com, Markus Armbruster , qemu-devel@nongnu.org, kraxel@redhat.com, Paolo Bonzini , mreitz@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" * Kevin Wolf (kwolf@redhat.com) wrote: > Am 15.03.2021 um 10:39 hat Markus Armbruster geschrieben: > > Paolo Bonzini writes: > > > > > On 13/03/21 14:28, Markus Armbruster wrote: > > >> Kevin Wolf writes: > > >> > > >>> This switches the HMP command object_add from a QemuOpts-based parser to > > >>> user_creatable_add_from_str() which uses a keyval parser and enforces > > >>> the QAPI schema. > > >>> > > >>> Apart from being a cleanup, this makes non-scalar properties and help > > >>> accessible. In order for help to be printed to the monitor instead of > > >>> stdout, the printf() calls in the help functions are changed to > > >>> qemu_printf(). > > >>> > > >>> Signed-off-by: Kevin Wolf > > >>> Acked-by: Peter Krempa > > >>> Reviewed-by: Eric Blake > > >>> Reviewed-by: Dr. David Alan Gilbert > > >>> --- > > >>> monitor/hmp-cmds.c | 17 ++--------------- > > >>> qom/object_interfaces.c | 11 ++++++----- > > >>> hmp-commands.hx | 2 +- > > >>> 3 files changed, 9 insertions(+), 21 deletions(-) > > >>> > > >>> diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c > > >>> index 3c88a4faef..652cf9ff21 100644 > > >>> --- a/monitor/hmp-cmds.c > > >>> +++ b/monitor/hmp-cmds.c > > >>> @@ -1670,24 +1670,11 @@ void hmp_netdev_del(Monitor *mon, const QDict *qdict) > > >>> > > >>> void hmp_object_add(Monitor *mon, const QDict *qdict) > > >>> { > > >>> + const char *options = qdict_get_str(qdict, "object"); > > >>> Error *err = NULL; > > >>> - QemuOpts *opts; > > >>> - Object *obj = NULL; > > >>> - > > >>> - opts = qemu_opts_from_qdict(qemu_find_opts("object"), qdict, &err); > > >>> - if (err) { > > >>> - goto end; > > >>> - } > > >>> > > >>> - obj = user_creatable_add_opts(opts, &err); > > >>> - qemu_opts_del(opts); > > >>> - > > >>> -end: > > >>> + user_creatable_add_from_str(options, &err); > > >>> hmp_handle_error(mon, err); > > >>> - > > >>> - if (obj) { > > >>> - object_unref(obj); > > >>> - } > > >>> } > > >> > > >> Doesn't this break the list-valued properties (Memdev member host-nodes, > > >> NumaNodeOptions member cpus) exactly the same way that made us keep > > >> QemuOpts for qemu-system-FOO -object? > > > > > > Yes, it does. I guess it can just be documented, unlike for the command > > > line? > > > > Maybe. Judgement call, not mine to make. > > > > Do people create such objects in HMP? I figure we don't really know. > > Educated guess? > > > > If you try, how does it break? Is it confusing? Can you show an > > example? > > (qemu) object_add memory-backend-ram,id=mem,size=4G,policy=bind,host-nodes=0 > Error: Invalid parameter type for 'host-nodes', expected: array > (qemu) object_add memory-backend-ram,id=mem,size=4G,policy=bind,host-nodes.0=0 > (qemu) > > HMP is not a stable interface, so changing the syntax didn't feel like a > problem to me. I doubt many people do HMP memory hotplug while setting a > specific NUMA policy, but it wouldn't change my assessment anyway. I > should have made this explicit in the commit message, though. I'm OK for it to change, but yes I'd like to have the before/after syntax listed somewhere as easy references for people confused. Dave > Kevin -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK