From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 421B4C433E0 for ; Fri, 5 Mar 2021 08:53:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0842264DE8 for ; Fri, 5 Mar 2021 08:53:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229489AbhCEIwc (ORCPT ); Fri, 5 Mar 2021 03:52:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:53722 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229538AbhCEIwI (ORCPT ); Fri, 5 Mar 2021 03:52:08 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id C7C3F64F59; Fri, 5 Mar 2021 08:52:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1614934327; bh=YomETzGtBP9KFxio8Vo2yqnxfBIHiDfol7GxCxmGtU0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=z+KYGf6BTBkscKqK3tJt4E+PFzmX5WeMIS7j74De5lLwQwmAp5fo+XDqJpK42h8LB DwzXgbF2PgreCzTcYhdqdA/Qu2LiFNO8QgGKVGq7kC2ujJa1GXV0BeFjSAJqd8Y+Si XbsucLPiloZ2XkSU8Zql42Tsj3y1VGXE+6emO+1g= Date: Fri, 5 Mar 2021 09:52:04 +0100 From: Greg Kroah-Hartman To: Naresh Kamboju Cc: Linus Torvalds , Guenter Roeck , open list , Shuah Khan , Florian Fainelli , patches@kernelci.org, lkft-triage@lists.linaro.org, Jon Hunter , linux-stable , Pavel Machek , Andrew Morton Subject: Re: [PATCH 5.10 000/657] 5.10.20-rc4 review Message-ID: References: <20210302192700.399054668@linuxfoundation.org> <175fac9c-ac3f-bd82-9e5d-2c2970cfc519@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 05, 2021 at 01:39:46PM +0530, Naresh Kamboju wrote: > On Fri, 5 Mar 2021 at 02:45, Linus Torvalds > wrote: > > > > On Thu, Mar 4, 2021 at 9:56 AM Naresh Kamboju wrote: > > > > > > On Thu, 4 Mar 2021 at 01:34, Guenter Roeck wrote: > > > > > > > > Upstream has: > > > > > > > > e71a8d5cf4b4 tty: fix up iterate_tty_read() EOVERFLOW handling > > > > ddc5fda74561 tty: fix up hung_up_tty_read() conversion > > > > > > I have applied these two patches and the reported problem did not solve. > > > > Hmm. Upstream has: > > > > * 3342ff2698e9 ("tty: protect tty_write from odd low-level tty disciplines") > > * a9cbbb80e3e7 ("tty: avoid using vfs_iocb_iter_write() for > > redirected console writes") > > * 17749851eb9c ("tty: fix up hung_up_tty_write() conversion") > > G e71a8d5cf4b4 ("tty: fix up iterate_tty_read() EOVERFLOW handling") > > G ddc5fda74561 ("tty: fix up hung_up_tty_read() conversion") > > * c7135bbe5af2 ("tty: fix up hung_up_tty_write() conversion") > > d7fe75cbc23c ("tty: teach the n_tty ICANON case about the new > > "cookie continuations" too") > > 15ea8ae8e03f ("tty: teach n_tty line discipline about the new > > "cookie continuations"") > > 64a69892afad ("tty: clean up legacy leftovers from n_tty line discipline") > > * 9bb48c82aced ("tty: implement write_iter") > > * dd78b0c483e3 ("tty: implement read_iter") > > * 3b830a9c34d5 ("tty: convert tty_ldisc_ops 'read()' function to take > > a kernel pointer") > > > > Where those ones marked with '*' seem to be in v5.10.y, and the one > > prefixed with 'G' are the ones Guenter mentioned. > > > > (We seem to have the "tty: fix up hung_up_tty_write() conversion" > > commit twice. I'm not sure how that happened, but whatever). I merged it through two different branches by applying it from email, one for 5.10-final and one for 5.11-rc1, sorry about that. > > But that still leaves three commits that don't seem to be in 5.10.y: > > > > d7fe75cbc23c ("tty: teach the n_tty ICANON case about the new > > "cookie continuations" too") > > 15ea8ae8e03f ("tty: teach n_tty line discipline about the new > > "cookie continuations"") > > 64a69892afad ("tty: clean up legacy leftovers from n_tty line discipline") > > > > and they might fix what are otherwise short reads. Which is allowed by > > POSIX, afaik, but .. > > > > Do those three commits fix your test-case? > > Yes. > As per your suggestion I've added these three patches and tested > and the reported test case PASS now [1]. > > This means I have five extra patches on top of the stable v5.10.20 tag. > > $ git log --oneline > 8c1c1de499af tty: teach the n_tty ICANON case about the new "cookie > continuations" too > 02aada164879 tty: teach n_tty line discipline about the new "cookie > continuations" > fb0df6b17897 tty: clean up legacy leftovers from n_tty line discipline > 429f7fc84d6a tty: fix up iterate_tty_read() EOVERFLOW handling > d0d54bca80a8 tty: fix up hung_up_tty_read() conversion > 83be32b6c9e5 (tag: v5.10.20, origin/linux-5.10.y) Linux 5.10.20 That last commit, "tty: fix up hung_up_tty_read() conversion" is already in 5.10.20 as e018e57fd5c0 ("tty: fix up hung_up_tty_write() conversion"), it came in at 5.10.11, so how did you apply it again? Anyway, thanks for these, I've queued up the 4 other commits now to the 5.10.y and 5.11.y trees, let's see what happens... greg k-h