All of
 help / color / mirror / Atom feed
From: "Krzysztof Wilczyński" <>
To: chakravarthikulkarni <>
Cc: "Rafael J. Wysocki" <>,
	Len Brown <>, Bjorn Helgaas <>,,,
Subject: Re: [PATCH] PCI: acpiphp:  Fixed coding style
Date: Sun, 7 Mar 2021 02:18:01 +0100	[thread overview]
Message-ID: <YEQpyWPgAI8az5gO@rocinante> (raw)
In-Reply-To: <>


Thank you for sending the patch over.  Few suggestions below.

There seem to be an extra space in the subject line.

> In this commit fixed coding style for braces and comments.

Where these coding style changes suggested by a tool?  For example, was it
something like  If so, then it would be prudent to
mention that the script found these for future reference.

> -	struct list_head funcs;		/* one slot may have different
> -					   objects (i.e. for each function) */
> +	struct list_head funcs;		/* one slot may have different */
> +					/* objects (i.e. for each function) */

Above would be a single line commit that has been made to with within
the line length rules, as otherwise the line would be too long.

This is not necessarily something that we ought to fix, see for example:

> -struct acpiphp_attention_info
> -{
> +struct acpiphp_attention_info {
>  	int (*set_attn)(struct hotplug_slot *slot, u8 status);
>  	int (*get_attn)(struct hotplug_slot *slot, u8 *status);
>  	struct module *owner;

Nice catch!

Generally, you would also need to your full name when providing your
"Signed-off-by:" following the style that has been widely accepted.  See
git log for how it would normally look like, and also have a look at the
following for some general guidance on how to submit patches:


  reply	other threads:[~2021-03-07  1:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-01  7:21 [PATCH] PCI: acpiphp: Fixed coding style chakravarthikulkarni
2021-03-07  1:18 ` Krzysztof Wilczyński [this message]
2021-04-16 19:35 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEQpyWPgAI8az5gO@rocinante \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.