From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D39FC433DB for ; Sun, 7 Mar 2021 23:45:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4F90864EBD for ; Sun, 7 Mar 2021 23:45:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231877AbhCGXoV (ORCPT ); Sun, 7 Mar 2021 18:44:21 -0500 Received: from mail-lj1-f173.google.com ([209.85.208.173]:39876 "EHLO mail-lj1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229797AbhCGXoD (ORCPT ); Sun, 7 Mar 2021 18:44:03 -0500 Received: by mail-lj1-f173.google.com with SMTP id u4so13000155ljh.6; Sun, 07 Mar 2021 15:44:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kB1ak2ni3jTw1VEk48TtG0sEob5ZqARNSeDM3pcSJ3k=; b=bFSOurn42jzzGG9pi66FScbaTjPwr/pDrS6Z4v8RGVMWYm/0XWO/Q5YrDG2n2DwT40 a9D0+W9KJsw4oLSo7WuN3MllGMNeDGnIWpYjrLxTDybgxxclXJFJht0RyAv2D9lgi5Uf a5A4LSMT6bdz2FzF7/5nDBpa88cubSp4BbfPp9A7UiJhME4isrOd28XzprnTVEO3JvSr Lwc3qa4qXwKCtbUlC88HRRyip2uPYIVL9l1ZW4vIWfobZC4Oee+wAFUzrrBbxnGAB7ho vUU3+NO3g98GEae14qR5uv6lLpMC5xbt2eSAg12m1pHIW6HL0o5H9W/6B3qgc9qIS9Lk wuUQ== X-Gm-Message-State: AOAM530DVoW9orD0jlUx4nKIL/0xdSYRiLqqFiigqdyvMpbkdbwXIHwq Mhpp/0PBL7SScGt+293eVEs= X-Google-Smtp-Source: ABdhPJzl4r+3SNeNNsgwDhSNMljeyw95BY3AjokZY4vQ+v6Wn1uSlEzLwEmpfVXmWBJ8Ki0XjkZ3cw== X-Received: by 2002:a2e:5716:: with SMTP id l22mr6068229ljb.244.1615160641921; Sun, 07 Mar 2021 15:44:01 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id k11sm1262574ljg.119.2021.03.07.15.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 15:44:00 -0800 (PST) Date: Mon, 8 Mar 2021 00:43:58 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Kunihiko Hayashi Cc: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jassi Brar , Masami Hiramatsu Subject: Re: [PATCH v9 1/3] PCI: portdrv: Add pcie_port_service_get_irq() function Message-ID: References: <1611007785-25771-1-git-send-email-hayashi.kunihiko@socionext.com> <1611007785-25771-2-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1611007785-25771-2-git-send-email-hayashi.kunihiko@socionext.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, [...] > +/* > + * pcie_port_service_get_irq - get irq of the service > + * @dev: PCI Express port the service is associated with > + * @service: For the service to find > + * > + * Get irq number associated with given service on a pci_dev > + */ > +int pcie_port_service_get_irq(struct pci_dev *dev, u32 service) [...] A small nitpick. It would be "IRQ" rather than "irq" in the above kernel-doc. Also, missing periods at the end of sentence. Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 688A7C433DB for ; Sun, 7 Mar 2021 23:45:40 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E27BA64F3B for ; Sun, 7 Mar 2021 23:45:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E27BA64F3B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bqC6EPl5iFyZVImDYZUAt4JDtxt4F7YzpiuPg/V4YJs=; b=BkHGpuOdkgaIft3/AY4fZu7hz 3XgwqISjY280+epHvI/JLraCs7Y7BEcHU/KMNoax+dm8c44oFeXEtXR9Aw7L7rHqI8MXGNdlqGGH1 y+LYD6v3TY4TFbZL8eo0l0Fi3utjTDVM5CrECibwZ/XcD+do00D0/l9MWEgx8XkTKM32+D5mrGgod rKoXaxC3mspqgnVigS2FQY2Pn7wFOEBBTJKvKQQ1734gtqPfsqR7n7PDtbqe0zRwjS2Qiotu6VutF EwKNf0Z+6S+09rhm7Hf1wsRls1xqvDZI6vCx7IIInKurdQwP6zuFUQCtESyDIGdwrkp2SJBepJwVB KEEsIRk+g==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lJ34C-00DZYU-8o; Sun, 07 Mar 2021 23:44:08 +0000 Received: from mail-lj1-f176.google.com ([209.85.208.176]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lJ346-00DZWh-NK for linux-arm-kernel@lists.infradead.org; Sun, 07 Mar 2021 23:44:04 +0000 Received: by mail-lj1-f176.google.com with SMTP id q14so12995443ljp.4 for ; Sun, 07 Mar 2021 15:44:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=kB1ak2ni3jTw1VEk48TtG0sEob5ZqARNSeDM3pcSJ3k=; b=MEargu9k6QNBqM7CDmifp4DjZtl5yfqXa4ZReL1OoDFCZBuErpxqBlMG/GPNONZm4A 9jWLra/4W36WqzgbcBM6UDdhx0DIC+Y6+zKNeA30dY9HNE/BE+GNGljRr8882qbmTt54 dUi85YI+cpfD7MtI+8TFV8k9rCAUNgJtmc32JL6yC63wcnC+LGLXUtKZ9bOzdFBORkzQ AFqAY544uhLC75Bo/oP8XpYBPe18SDUKIgEpzU/5R8ZDt82K69Yh8faiI+wMsTZrr0UP GWocanVaIHjmxSwckaKglH2h/HzgEIhyJEMd5PwgjNxHNZx8eYbqefrOyFngfDgD5/VA dTXQ== X-Gm-Message-State: AOAM532g8iRsu8aTOQYqXVbvU9ivO+7p7ul0k2u2iq/k1ZdI27GBZgNJ lKpjhuiv+Bgi+xaJQkR01Gk= X-Google-Smtp-Source: ABdhPJzl4r+3SNeNNsgwDhSNMljeyw95BY3AjokZY4vQ+v6Wn1uSlEzLwEmpfVXmWBJ8Ki0XjkZ3cw== X-Received: by 2002:a2e:5716:: with SMTP id l22mr6068229ljb.244.1615160641921; Sun, 07 Mar 2021 15:44:01 -0800 (PST) Received: from rocinante ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id k11sm1262574ljg.119.2021.03.07.15.44.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 07 Mar 2021 15:44:00 -0800 (PST) Date: Mon, 8 Mar 2021 00:43:58 +0100 From: Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= To: Kunihiko Hayashi Cc: Bjorn Helgaas , Rob Herring , Lorenzo Pieralisi , Jingoo Han , Gustavo Pimentel , Marc Zyngier , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jassi Brar , Masami Hiramatsu Subject: Re: [PATCH v9 1/3] PCI: portdrv: Add pcie_port_service_get_irq() function Message-ID: References: <1611007785-25771-1-git-send-email-hayashi.kunihiko@socionext.com> <1611007785-25771-2-git-send-email-hayashi.kunihiko@socionext.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1611007785-25771-2-git-send-email-hayashi.kunihiko@socionext.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210307_234402_924770_336ECDE8 X-CRM114-Status: GOOD ( 10.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, [...] > +/* > + * pcie_port_service_get_irq - get irq of the service > + * @dev: PCI Express port the service is associated with > + * @service: For the service to find > + * > + * Get irq number associated with given service on a pci_dev > + */ > +int pcie_port_service_get_irq(struct pci_dev *dev, u32 service) [...] A small nitpick. It would be "IRQ" rather than "irq" in the above kernel-doc. Also, missing periods at the end of sentence. Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel