All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Mladek <pmladek@suse.com>
To: Joe Lawrence <joe.lawrence@redhat.com>
Cc: Bhaskar Chowdhury <unixbhaskar@gmail.com>,
	Matthew Wilcox <willy@infradead.org>,
	jpoimboe@redhat.com, jikos@kernel.org, mbenes@suse.cz,
	corbet@lwn.net, live-patching@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
	rdunlap@infradead.org
Subject: Re: [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence
Date: Mon, 8 Mar 2021 11:18:50 +0100	[thread overview]
Message-ID: <YEX6Cu0EcVpUklFG@alley> (raw)
In-Reply-To: <f8b10ee7-026c-1dc0-fb0c-2a887cd1e953@redhat.com>

On Fri 2021-03-05 11:00:10, Joe Lawrence wrote:
> On 3/5/21 8:37 AM, Bhaskar Chowdhury wrote:
> > On 12:56 Fri 05 Mar 2021, Matthew Wilcox wrote:
> > > On Fri, Mar 05, 2021 at 03:39:23PM +0530, Bhaskar Chowdhury wrote:
> > > > s/varibles/variables/
> > > > 
> > > > ...and remove leading spaces from a sentence.
> > > 
> > > What do you mean 'leading spaces'?  Separating two sentences with
> > > one space or two is a matter of personal style, and we do not attempt
> > > to enforce a particular style in the kernel.
> > > 
> > The spaces before the "In" .. nor I am imposing anything , it was peter caught
> > and told me that it is hanging ..move it to the next line ..so I did. ..
> > 
> 
> Initially I thought the same as Matthew, but after inspecting the diff I
> realized it was just a line wrap.  Looks fine to me.
> 
> > > >   Sometimes it may not be convenient or possible to allocate shadow
> > > >   variables alongside their parent objects.  Or a livepatch fix may
> > > > -require shadow varibles to only a subset of parent object instances.  In
> > > > +require shadow variables to only a subset of parent object instances.
> > > 
> > > wrong preposition, s/to/for/    ..where???
> 
> Hi Bhaskar,
> 
> Thanks for spotting, I'd be happy with v2 as is or a v3 if you want to
> update s/shadow variables to only/shadow variables for only/  but knowing
> me, I probably repeated the same phrasing elsewhere.  Up to you, thanks.

I could fix these when pushing unless anyone is against it.

> Acked-by: Joe Lawrence <joe.lawrence@redhat.com>

Acked-by: Petr Mladek <pmladek@suse.com>

Best Regards,
Petr

  reply	other threads:[~2021-03-08 10:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-05 10:09 [PATCH V2] docs: livepatch: Fix a typo and remove the unnecessary gaps in a sentence Bhaskar Chowdhury
2021-03-05 12:56 ` Matthew Wilcox
2021-03-05 13:37   ` Bhaskar Chowdhury
2021-03-05 16:00     ` Joe Lawrence
2021-03-08 10:18       ` Petr Mladek [this message]
2021-03-09  0:26 ` Jonathan Corbet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEX6Cu0EcVpUklFG@alley \
    --to=pmladek@suse.com \
    --cc=corbet@lwn.net \
    --cc=jikos@kernel.org \
    --cc=joe.lawrence@redhat.com \
    --cc=jpoimboe@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=live-patching@vger.kernel.org \
    --cc=mbenes@suse.cz \
    --cc=rdunlap@infradead.org \
    --cc=unixbhaskar@gmail.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.