From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 514A7C433E0 for ; Mon, 8 Mar 2021 16:39:47 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF76F6522F for ; Mon, 8 Mar 2021 16:39:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CF76F6522F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJIv3-0007AD-TR for qemu-devel@archiver.kernel.org; Mon, 08 Mar 2021 11:39:45 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJIsO-0004FD-PY for qemu-devel@nongnu.org; Mon, 08 Mar 2021 11:37:01 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:55928) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1lJIsL-0000Jy-Ql for qemu-devel@nongnu.org; Mon, 08 Mar 2021 11:36:59 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1615221416; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=IbLd/zT3nUYOF3HJXQ+uKoxTdrPiuZDTKFJuz7xLpJc=; b=ZaqedYOEvGJFCKUtERb/vGiKZAQWk2WQ+3O6z8a51+c+ye1WFEzibgQuMjW352fKWFwNh9 52OqdATYOeJLD6XqemzdRuew1OFhepbduTk2J79VZF02V5CbK3Ma3ugYWoOdEiah4sUH/0 /9hFejAh+8fjpwp+WaobLHSrEMxTcbE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-165-uFxikIvROeqMnQbLH4zK1Q-1; Mon, 08 Mar 2021 11:36:44 -0500 X-MC-Unique: uFxikIvROeqMnQbLH4zK1Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2F8141966321; Mon, 8 Mar 2021 16:36:43 +0000 (UTC) Received: from redhat.com (ovpn-114-69.ams2.redhat.com [10.36.114.69]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A300010013D7; Mon, 8 Mar 2021 16:36:37 +0000 (UTC) Date: Mon, 8 Mar 2021 16:36:34 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Tarun Gupta Subject: Re: [PATCH v1 1/1] vfio: Make migration support non experimental by default. Message-ID: References: <20210308160949.4290-1-targupta@nvidia.com> MIME-Version: 1.0 In-Reply-To: <20210308160949.4290-1-targupta@nvidia.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=berrange@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.251, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Cc: cjia@nvidia.com, quintela@redhat.com, cohuck@redhat.com, qemu-devel@nongnu.org, Kirti Wankhede , dgilbert@redhat.com, lushenming@huawei.com, alex.williamson@redhat.com, dnigam@nvidia.com, philmd@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Mar 08, 2021 at 09:39:49PM +0530, Tarun Gupta wrote: > VFIO migration support in QEMU is experimental as of now, which was done to > provide soak time and resolve concerns regarding bit-stream. > But, with the patches discussed in > https://www.mail-archive.com/qemu-devel@nongnu.org/msg784931.html , we have > corrected ordering of saving PCI config space and bit-stream. > > So, this patch proposes to make vfio migration support in QEMU to be enabled > by default. Tested by successfully migrating mdev device. > > Signed-off-by: Tarun Gupta > Signed-off-by: Kirti Wankhede > --- > hw/vfio/pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c > index f74be78209..15e26f460b 100644 > --- a/hw/vfio/pci.c > +++ b/hw/vfio/pci.c > @@ -3199,7 +3199,7 @@ static Property vfio_pci_dev_properties[] = { > DEFINE_PROP_BIT("x-igd-opregion", VFIOPCIDevice, features, > VFIO_FEATURE_ENABLE_IGD_OPREGION_BIT, false), > DEFINE_PROP_BOOL("x-enable-migration", VFIOPCIDevice, > - vbasedev.enable_migration, false), > + vbasedev.enable_migration, true), If it isn't experimental then why do we even need an experimental 'x-' property at all ? IOW, rather than changing this to "true", shouldn't we just be deleting the x-enable-migration property entirely and have the code just do the right thing. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|