All of lore.kernel.org
 help / color / mirror / Atom feed
From: Klaus Jensen <its@irrelevant.dk>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Fam Zheng <fam@euphon.net>,
	Peter Maydell <peter.maydell@linaro.org>,
	qemu-block@nongnu.org, Klaus Jensen <k.jensen@samsung.com>,
	qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Keith Busch <kbusch@kernel.org>, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device
Date: Mon, 8 Mar 2021 19:46:21 +0100	[thread overview]
Message-ID: <YEZw/cDu+1zouiHT@apples.localdomain> (raw)
In-Reply-To: <48178d72-444c-91fd-c1ef-0ae28b8a674e@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 890 bytes --]

On Mar  8 19:32, Paolo Bonzini wrote:
> On 08/03/21 13:22, Klaus Jensen wrote:
> > 
> > This patch introduced a simple nvme-subsys device model.  The subsystem
> > will be prepared with subsystem NQN with <subsys_id> provided in
> > nvme-subsys device:
> > 
> >    ex) -device nvme-subsys,id=subsys0: nqn.2019-08.org.qemu:subsys0
> 
> Hi Klaus, sorry for not spotting this before.  In the SCSI subsystem we
> moved away from using id as guest-visible data.  Keeping it as a default is
> fine I guess, but would it be possible to add an nqn property to nvme-subsys
> and use it if it is present instead of the id?
> 
> Thanks,
> 
> Paolo
> 

Hi Paolo,

Thanks for pointing this out! Absolutely - we have no specific reason to
use 'id', so we can just change it completely to use 'nqn'.

Peter, you want this in a v2 or did you already start integration of
this PR?

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2021-03-08 19:15 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 12:22 [PULL 00/38] emulated nvme device updates Klaus Jensen
2021-03-08 12:22 ` [PULL 01/38] hw/block/nvme: introduce nvme-subsys device Klaus Jensen
2021-03-08 18:32   ` Paolo Bonzini
2021-03-08 18:46     ` Klaus Jensen [this message]
2021-03-08 18:53       ` Peter Maydell
2021-03-08 18:55         ` Klaus Jensen
2021-03-08 12:22 ` [PULL 02/38] hw/block/nvme: support to map controller to a subsystem Klaus Jensen
2021-03-08 12:22 ` [PULL 03/38] hw/block/nvme: add CMIC enum value for Identify Controller Klaus Jensen
2021-03-08 12:22 ` [PULL 04/38] hw/block/nvme: support for multi-controller in subsystem Klaus Jensen
2021-03-08 12:22 ` [PULL 05/38] hw/block/nvme: add NMIC enum value for Identify Namespace Klaus Jensen
2021-03-08 12:22 ` [PULL 06/38] hw/block/nvme: support for shared namespace in subsystem Klaus Jensen
2021-03-08 12:22 ` [PULL 07/38] hw/block/nvme: remove unused parameter in check zone write Klaus Jensen
2021-03-08 12:22 ` [PULL 08/38] hw/block/nvme: refactor zone resource management Klaus Jensen
2021-03-08 12:22 ` [PULL 09/38] hw/block/nvme: pull write pointer advancement to separate function Klaus Jensen
2021-03-08 12:22 ` [PULL 10/38] nvme: updated shared header for copy command Klaus Jensen
2021-03-08 12:22 ` [PULL 11/38] hw/block/nvme: add simple " Klaus Jensen
2021-03-08 12:22 ` [PULL 12/38] hw/block/nvme: fix Close Zone Klaus Jensen
2021-03-08 12:22 ` [PULL 13/38] hw/block/nvme: add missing mor/mar constraint checks Klaus Jensen
2021-03-08 12:22 ` [PULL 14/38] hw/block/nvme: improve invalid zasl value reporting Klaus Jensen
2021-03-08 12:22 ` [PULL 15/38] hw/block/nvme: use locally assigned QEMU IEEE OUI Klaus Jensen
2021-03-08 12:22 ` [PULL 16/38] hw/block/nvme: add broadcast nsid support flush command Klaus Jensen
2021-03-08 12:22 ` [PULL 17/38] hw/block/nvme: document 'mdts' nvme device parameter Klaus Jensen
2021-03-08 12:22 ` [PULL 18/38] hw/block/nvme: deduplicate bad mdts trace event Klaus Jensen
2021-03-08 12:22 ` [PULL 19/38] hw/block/nvme: align zoned.zasl with mdts Klaus Jensen
2021-03-08 12:22 ` [PULL 20/38] hw/block/nvme: remove unnecessary endian conversion Klaus Jensen
2021-03-08 12:22 ` [PULL 21/38] hw/block/nvme: add identify trace event Klaus Jensen
2021-03-08 12:22 ` [PULL 22/38] hw/block/nvme: fix potential compilation error Klaus Jensen
2021-03-08 12:22 ` [PULL 23/38] hw/block/nvme: add trace event for zone read check Klaus Jensen
2021-03-08 12:22 ` [PULL 24/38] hw/block/nvme: report non-mdts command size limit for dsm Klaus Jensen
2021-03-08 12:23 ` [PULL 25/38] hw/block/nvme: remove redundant len member in compare context Klaus Jensen
2021-03-08 12:23 ` [PULL 26/38] hw/block/nvme: remove block accounting for write zeroes Klaus Jensen
2021-03-08 12:23 ` [PULL 27/38] hw/block/nvme: fix strerror printing Klaus Jensen
2021-03-08 12:23 ` [PULL 28/38] hw/block/nvme: try to deal with the iov/qsg duality Klaus Jensen
2021-03-08 12:23 ` [PULL 29/38] hw/block/nvme: remove the req dependency in map functions Klaus Jensen
2021-03-08 12:23 ` [PULL 30/38] hw/block/nvme: refactor nvme_dma Klaus Jensen
2021-03-08 12:23 ` [PULL 31/38] hw/block/nvme: support namespace detach Klaus Jensen
2021-03-08 12:23 ` [PULL 32/38] hw/block/nvme: fix namespaces array to 1-based Klaus Jensen
2021-03-08 12:23 ` [PULL 33/38] hw/block/nvme: fix allocated namespace list to 256 Klaus Jensen
2021-03-08 12:23 ` [PULL 34/38] hw/block/nvme: support allocated namespace type Klaus Jensen
2021-03-08 12:23 ` [PULL 35/38] hw/block/nvme: refactor nvme_select_ns_iocs Klaus Jensen
2021-03-08 12:23 ` [PULL 36/38] hw/block/nvme: support namespace attachment command Klaus Jensen
2021-03-08 12:23 ` [PULL 37/38] hw/block/nvme: support changed namespace asynchronous event Klaus Jensen
2021-03-08 12:23 ` [PULL 38/38] hw/block/nvme: support Identify NS Attached Controller List Klaus Jensen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEZw/cDu+1zouiHT@apples.localdomain \
    --to=its@irrelevant.dk \
    --cc=fam@euphon.net \
    --cc=k.jensen@samsung.com \
    --cc=kbusch@kernel.org \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.