From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 123EAC433DB for ; Mon, 8 Mar 2021 19:25:14 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9BA36652A8 for ; Mon, 8 Mar 2021 19:25:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9BA36652A8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=irrelevant.dk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:58756 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lJLVA-0002gs-AO for qemu-devel@archiver.kernel.org; Mon, 08 Mar 2021 14:25:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43248) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJL2T-0002LT-7g; Mon, 08 Mar 2021 13:55:33 -0500 Received: from new3-smtp.messagingengine.com ([66.111.4.229]:54909) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lJL2P-00005J-Ss; Mon, 08 Mar 2021 13:55:32 -0500 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 0E7FF580707; Mon, 8 Mar 2021 13:55:28 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Mon, 08 Mar 2021 13:55:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=irrelevant.dk; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=gmAvXZekthKVds1ec4JC9RLYhQa NMGXQmeY9PG701fA=; b=McUmZOtDPlcJGyHjiaoaLuKz2bxrIRUvFVpn6YlIkan 0v49aziIiYdWMbCVYDnk1c8PrJneyDKjxOcMYVJrYr6Ib4UP3EqUagXzpON8vu7J T7q94nQEHFuqogayacGGMYyKQ55MfozaMouE9X9C4DXWea73gYOMraZtfH8J32Lm J6md3IvwXy7OI9ru14z7/DOQX4snStLDu+PhIryp6M3KZQBPL0CnR0xwOOtedp4J KD3PgNJIG/H/wdY8i4VMNbUZ5wAmJt0f/MSaY9KA1rjWYpgAlX2LFIRGESrx/271 YSrqDsdFvts9ZEXzZx6xP5y07wPVQpYyq+XN3KFWcyw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=gmAvXZ ekthKVds1ec4JC9RLYhQaNMGXQmeY9PG701fA=; b=QN/zjqwCX3bRRCyRwuaNBb UDLkGJHy3ZXf0tiQTpBDRFBv0515SxBYvrYjtlNIoj9sTsGeJgulL0kKD6oBJYhz B4NnYxFVGCbJb+vzxe8z+JUeRaJ6+8N6TiMQ0sTgSzmqHoaO/1CIEfOUdnrMCZn+ w3MBaqY+6X5fBptTu1VhZ4fHAsB7KxoGVhLyJRnBtNKiDBA+jvi880chInR4MJiQ njU27PFE8IrmpVWjQoNFk0YNKyOuHMF8egsVyeE+YlGI+LPYz5vEu01Vvl2dt8Jr tv6nH//9nCso96uvy5ZiizYOzkumqnIoguF168xX8CgGAkHIL1eKvDcDvsf+pxiw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledruddugedgheegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefmlhgruhhs ucflvghnshgvnhcuoehithhssehirhhrvghlvghvrghnthdrughkqeenucggtffrrghtth gvrhhnpeehgeehgfffgeekveefteetudekheejffdtvedvudfgffelleefvdfftdekgffg udenucffohhmrghinhepvddtudelqddtkedrohhrghenucfkphepkedtrdduieejrdelke drudeltdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhm pehithhssehirhhrvghlvghvrghnthdrughk X-ME-Proxy: Received: from apples.localdomain (80-167-98-190-cable.dk.customer.tdc.net [80.167.98.190]) by mail.messagingengine.com (Postfix) with ESMTPA id A97F124005A; Mon, 8 Mar 2021 13:55:25 -0500 (EST) Date: Mon, 8 Mar 2021 19:55:24 +0100 From: Klaus Jensen To: Peter Maydell Subject: Re: [PULL 01/38] hw/block/nvme: introduce nvme-subsys device Message-ID: References: <20210308122313.286938-1-its@irrelevant.dk> <20210308122313.286938-2-its@irrelevant.dk> <48178d72-444c-91fd-c1ef-0ae28b8a674e@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="IEslRVchhB9HBTMs" Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=66.111.4.229; envelope-from=its@irrelevant.dk; helo=new3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Kevin Wolf , Qemu-block , Klaus Jensen , QEMU Developers , Max Reitz , Stefan Hajnoczi , Keith Busch , Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --IEslRVchhB9HBTMs Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mar 8 18:53, Peter Maydell wrote: > On Mon, 8 Mar 2021 at 18:46, Klaus Jensen wrote: > > > > On Mar 8 19:32, Paolo Bonzini wrote: > > > On 08/03/21 13:22, Klaus Jensen wrote: > > > > > > > > This patch introduced a simple nvme-subsys device model. The subsy= stem > > > > will be prepared with subsystem NQN with provided in > > > > nvme-subsys device: > > > > > > > > ex) -device nvme-subsys,id=3Dsubsys0: nqn.2019-08.org.qemu:subsy= s0 > > > > > > Hi Klaus, sorry for not spotting this before. In the SCSI subsystem = we > > > moved away from using id as guest-visible data. Keeping it as a defa= ult is > > > fine I guess, but would it be possible to add an nqn property to nvme= -subsys > > > and use it if it is present instead of the id? > > > > > > Thanks, > > > > > > Paolo > > > > > > > Hi Paolo, > > > > Thanks for pointing this out! Absolutely - we have no specific reason to > > use 'id', so we can just change it completely to use 'nqn'. > > > > Peter, you want this in a v2 or did you already start integration of > > this PR? >=20 > I haven't yet started working on this PR so if the change is trivial > feel free to roll a v2. >=20 Thanks, I'll do that! --IEslRVchhB9HBTMs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUigzqnXi3OaiR2bATeGvMW1PDekFAmBGcxoACgkQTeGvMW1P Den3vwgAnwF4Qs3v9+vOF77fg7D+0CSvwrOG3CTRW9phDaNZyYPXYyre6m592972 IzXPisc5/AI/GFV2a6hqGt16QUMcW8Jw6xITxr4EPkD2rotcDwR2SpZKjeOm/kVW DM6sr6iV9umQbkufhcKRXMaUMeWSQzQECuHlVbZ9zsLn2aWNHMBeGOmCdozfgQDR JxOx9Xryhs8Pn3n+CYOOLje2fB/JghOmkl9128brJ+W/01rlQgf08KwYtea9tSk+ RECqMUXPhnhNFnZTDpbrCzNyO8ez3awVk2lnnT5Sb9hNpfC5p2yOMwyEC+MWDbZc u2RATXoh1mGRDMSUZQtzr7zdAzdZkw== =/VTP -----END PGP SIGNATURE----- --IEslRVchhB9HBTMs--