From: Dan Carpenter <dan.carpenter@oracle.com>
To: frank.li@nxp.com
Cc: linux-usb@vger.kernel.org
Subject: [bug report] usb: cdns3: add power lost support for system resume
Date: Wed, 10 Mar 2021 12:19:11 +0300 [thread overview]
Message-ID: <YEiPD6L0BJkWrjid@mwanda> (raw)
Hello Frank Li,
The patch c450e48eb570: "usb: cdns3: add power lost support for
system resume" from Feb 18, 2021, leads to the following static
checker warning:
drivers/usb/cdns3/core.c:551 cdns_resume()
error: uninitialized symbol 'ret'.
drivers/usb/cdns3/core.c
544
545 if (!role_changed) {
546 if (cdns->role == USB_ROLE_HOST)
547 ret = cdns_drd_host_on(cdns);
548 else if (cdns->role == USB_ROLE_DEVICE)
549 ret = cdns_drd_gadget_on(cdns);
What about is "ret" if the role is USB_ROLE_NONE?
550
551 if (ret)
552 return ret;
553 }
554 }
555
regards,
dan carpenter
next reply other threads:[~2021-03-10 9:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-10 9:19 Dan Carpenter [this message]
2021-03-10 16:14 ` [bug report] usb: cdns3: add power lost support for system resume Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEiPD6L0BJkWrjid@mwanda \
--to=dan.carpenter@oracle.com \
--cc=frank.li@nxp.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.