All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: ltp@lists.linux.it
Subject: [LTP] [PATCH 1/3] lib: Add proper filesystem skiplist
Date: Wed, 10 Mar 2021 16:39:25 +0100	[thread overview]
Message-ID: <YEjoLfDjJOWMmdqb@pevik> (raw)
In-Reply-To: <YEjXn0FN25d6K0Lv@yuki.lan>

Hi Cyril,

..
> > > +	for (i = 0; skiplist[i]; i++) {
> > > +		if (!strcmp(fs_type, skiplist[i])) {
> > > +			tst_res(TINFO,
> > It'd be nice if skipping message could be TCONF to avoid:
> > tst_supported_fs_types.c:57: TINFO: Skipping tmpfs as requested by the test
> > tst_test.c:1056: TCONF: Skipping due to unsupported filesystem

> > but understand why - it'd make code more complicated (has_kernel_support() which
> > is used in tst_fs_is_supported() should not emit TCONF).

> I can make a internal wrapper for the tst_fs_is_supported() that prints
> the TINFO message and use that in the tst_supported_fs_types, which
> would make it silent in the case it's called from the test library...

Up to you, not really that important to bother with it.

Kind regards,
Petr

  reply	other threads:[~2021-03-10 15:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-10 12:26 [LTP] [PATCH 0/3] Add proper filesystem skiplist Cyril Hrubis
2021-03-10 12:26 ` [LTP] [PATCH 1/3] lib: " Cyril Hrubis
2021-03-10 12:58   ` Petr Vorel
2021-03-10 14:28     ` Cyril Hrubis
2021-03-10 15:39       ` Petr Vorel [this message]
2021-03-10 16:19   ` Martin Doucha
2021-03-10 16:22     ` Cyril Hrubis
2021-03-10 16:34       ` Martin Doucha
2021-03-11  8:39         ` Li Wang
2021-03-10 12:26 ` [LTP] [PATCH 2/3] lib: tst_fs_type change fs names to lowercase Cyril Hrubis
2021-03-10 12:26 ` [LTP] [PATCH 3/3] lib: Apply the skip_filesystems to rest of test as well Cyril Hrubis
2021-03-10 12:42 ` [LTP] [PATCH 0/3] Add proper filesystem skiplist Petr Vorel
2021-03-10 12:55 ` Jan Stancek
2021-03-10 14:14   ` Cyril Hrubis
2021-03-10 16:01     ` Jan Stancek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEjoLfDjJOWMmdqb@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.