All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lu <tonylu@linux.alibaba.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: davem@davemloft.net, mingo@redhat.com, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: add net namespace inode for all net_dev events
Date: Thu, 11 Mar 2021 14:39:17 +0800	[thread overview]
Message-ID: <YEm7FcfJ5NY6WM+J@TonyMac-Alibaba> (raw)
In-Reply-To: <20210310113112.743dcf17@gandalf.local.home>

On Wed, Mar 10, 2021 at 11:31:12AM -0500, Steven Rostedt wrote:
> On Wed, 10 Mar 2021 17:03:40 +0800
> Tony Lu <tonylu@linux.alibaba.com> wrote:
> 
> > I use pahole to read vmlinux.o directly with defconfig and
> > CONFIG_DEBUG_INFO enabled, the result shows 22 structs prefixed with
> > trace_event_raw_ that have at least one hole.
> 
> I was thinking of pahole too ;-)
> 
> But the information can also be captured from the format files with simple
> scripts as well. And perhaps be more tuned to see if there's actually a fix
> for them, and ignore reporting it if there is no fix, as all trace events
> are 4 byte aligned, and if we are off by one, sometimes it doesn't matter.

I am going to send a patch to fix this issue later. There are many
events have more than 1 holes, I am trying to pick up the events that are
really to be fixed.


Cheers,
Tony Lu

> 
> -- Steve

  reply	other threads:[~2021-03-11  6:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09  4:43 [PATCH] net: add net namespace inode for all net_dev events Tony Lu
2021-03-09 17:40 ` Steven Rostedt
2021-03-09 19:53   ` David Ahern
2021-03-09 20:02     ` Steven Rostedt
2021-03-09 20:17       ` David Ahern
2021-03-09 20:20         ` Alexei Starovoitov
2021-03-09 20:35         ` Steven Rostedt
2021-03-09 20:39           ` Alexei Starovoitov
2021-03-09 20:18       ` Alexei Starovoitov
2021-03-10  9:03   ` Tony Lu
2021-03-10 16:31     ` Steven Rostedt
2021-03-11  6:39       ` Tony Lu [this message]
2021-03-10 16:49     ` Steven Rostedt
2021-03-09 20:12 ` Eric Dumazet
2021-03-10  9:22   ` Lorenz Bauer
2021-03-10 12:01     ` Tony Lu
2021-03-10  9:33   ` Tony Lu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEm7FcfJ5NY6WM+J@TonyMac-Alibaba \
    --to=tonylu@linux.alibaba.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.