From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 986BEC433E0 for ; Fri, 12 Mar 2021 02:50:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6E35064F8E for ; Fri, 12 Mar 2021 02:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229636AbhCLCtt (ORCPT ); Thu, 11 Mar 2021 21:49:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49696 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231669AbhCLCtc (ORCPT ); Thu, 11 Mar 2021 21:49:32 -0500 Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7CAE9C061574 for ; Thu, 11 Mar 2021 18:49:32 -0800 (PST) Received: by mail-oo1-xc35.google.com with SMTP id 125-20020a4a1a830000b02901b6a144a417so1200056oof.13 for ; Thu, 11 Mar 2021 18:49:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EYVqRVBPVhizjxhXnWF45Gz26g8vdQA3COQqWInRBeA=; b=gL3L51OcWU67DmzWlOUOVcXvpiTxuMJpwzzNInvbPku7ZfttNYAc+vJTXP2pwN456X ezPUT2byJNG2YyVG7IIik1mPkyz9NjBjzxuYKRiFRa7CvXGRDLVP6zPuKYJCaNJJjd5U 3unxTI+29QH0F6WNzop7rJz1boWKj7QEAc6b4HaV/Dd7NYx0zPkBHjDvCzFqqPTmfAor xsUpYumiFVqeXRvL/F8ckV7rZLXqwWxm0vhgvdOjmOyyi7ZS+QxKPzvGzNyWFjcBgjaf 0NzS7W+VWwMhsuyYdahNOi3RQC01deewwBLdRixfZDlVZgTn0PPo1t553Ck7RAGtOJPE quSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EYVqRVBPVhizjxhXnWF45Gz26g8vdQA3COQqWInRBeA=; b=rNOrH+bD5Bfejlo2cDWDJC5aoS7V699umqRBoBIovNwrXHs5J43uLXG7QV7n0G0gAf 4QQQcpHpK6XYUxl0wX+iFmWflOOASgC/CsPd/FjjCLUz02huaQOO5hCIzJnFRAi06Dek tNQ+h8Jz05r5xfxCoVyHwPHtXfqfnEkSKOi7Zpp6Fho2mL7Br9OdKnJMolrwLC8nbtab WSqmFtyr8OkxqboxupCo5ocIixEe860uBHbBbT8gnlc9b1OYUC+o9hcTJRjMqOY5Xlx9 Gp7KZH/NvoVZUjjpPoJOdeomZu3BnjVCLAooOIgB1wjl55ZcqWO4Hw54KjdiPntxu1b+ 2/pQ== X-Gm-Message-State: AOAM530w6+EMTfyYC47ULbPNCRvCsnqblh2i1gh5WxhcCq3r46T7bDpi fQ52Lz2fMNs0UudlHdGrqf4dPQ== X-Google-Smtp-Source: ABdhPJy05T1NPkkQXB9EoKTWk0BgQA2YbcX/Rl20SMQs0NEdv0PPCLfiCzrohW58ne4IcabfxTDOIA== X-Received: by 2002:a4a:420d:: with SMTP id h13mr1638857ooj.24.1615517371923; Thu, 11 Mar 2021 18:49:31 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 64sm1102682otu.80.2021.03.11.18.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 18:49:31 -0800 (PST) Date: Thu, 11 Mar 2021 20:49:29 -0600 From: Bjorn Andersson To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Stephen Boyd , linux-arm-msm@vger.kernel.org, robdclark@chromium.org, Daniel Vetter , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify refclk handling Message-ID: References: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu 04 Mar 17:51 CST 2021, Douglas Anderson wrote: > The clock framework makes it simple to deal with an optional clock. > You can call clk_get_optional() and if the clock isn't specified it'll > just return NULL without complaint. It's valid to pass NULL to > enable/disable/prepare/unprepare. Let's make use of this to simplify > things a tiny bit. > > NOTE: this makes things look a tad bit asymmetric now since we check > for NULL before clk_prepare_enable() but not for > clk_disable_unprepare(). This seemed OK to me. We already have to > check for NULL in the enable case anyway so why not avoid the extra > call? > Reviewed-by: Bjorn Andersson > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index f27306c51e4d..942019842ff4 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -1261,14 +1261,9 @@ static int ti_sn_bridge_probe(struct i2c_client *client, > return ret; > } > > - pdata->refclk = devm_clk_get(pdata->dev, "refclk"); > - if (IS_ERR(pdata->refclk)) { > - ret = PTR_ERR(pdata->refclk); > - if (ret == -EPROBE_DEFER) > - return ret; > - DRM_DEBUG_KMS("refclk not found\n"); > - pdata->refclk = NULL; > - } > + pdata->refclk = devm_clk_get_optional(pdata->dev, "refclk"); > + if (IS_ERR(pdata->refclk)) > + return PTR_ERR(pdata->refclk); > > ret = ti_sn_bridge_parse_dsi_host(pdata); > if (ret) > -- > 2.30.1.766.gb4fecdf3b7-goog > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30BF7C433E0 for ; Fri, 12 Mar 2021 02:49:35 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9C4A64F73 for ; Fri, 12 Mar 2021 02:49:34 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9C4A64F73 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 038986EA9A; Fri, 12 Mar 2021 02:49:34 +0000 (UTC) Received: from mail-oo1-xc36.google.com (mail-oo1-xc36.google.com [IPv6:2607:f8b0:4864:20::c36]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4DC36EA9A for ; Fri, 12 Mar 2021 02:49:32 +0000 (UTC) Received: by mail-oo1-xc36.google.com with SMTP id r17-20020a4acb110000b02901b657f28cdcso1198114ooq.6 for ; Thu, 11 Mar 2021 18:49:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=EYVqRVBPVhizjxhXnWF45Gz26g8vdQA3COQqWInRBeA=; b=gL3L51OcWU67DmzWlOUOVcXvpiTxuMJpwzzNInvbPku7ZfttNYAc+vJTXP2pwN456X ezPUT2byJNG2YyVG7IIik1mPkyz9NjBjzxuYKRiFRa7CvXGRDLVP6zPuKYJCaNJJjd5U 3unxTI+29QH0F6WNzop7rJz1boWKj7QEAc6b4HaV/Dd7NYx0zPkBHjDvCzFqqPTmfAor xsUpYumiFVqeXRvL/F8ckV7rZLXqwWxm0vhgvdOjmOyyi7ZS+QxKPzvGzNyWFjcBgjaf 0NzS7W+VWwMhsuyYdahNOi3RQC01deewwBLdRixfZDlVZgTn0PPo1t553Ck7RAGtOJPE quSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=EYVqRVBPVhizjxhXnWF45Gz26g8vdQA3COQqWInRBeA=; b=XkQlZSn9fiGKZ575jKM4q9K28DpD6IrnWUAs4w8GCmY0cPR+GrqEvLAiDYXLXdDmuQ YRapt1NLTpNw4r/o2XHDnfiYv7wKHVhkU67owq8F4K9d7nNETuSI7DKj+DDGhc8huFzC PEgRXSHIIE3CIRIdEN3uVjY9jFpbTKDCgHqWAUdUq1DirYKcjFu5jU0rc2uWYFEsjiRa sb3QHz9i7uwG8JTDG2Kd5D8GjTWl/9ouIafKM0DF5PpQODEpN7WOJQtUIGiZnPICRom+ ifS545+BQfQPLkcZpF1AurOgeh3E7HE258imKGudZoQ0TIhvFYODieav7CoitctsLtbJ k4Mw== X-Gm-Message-State: AOAM530FTlGsM2XKVDsTAqF42d2Yi1N9EgaCuiTZq+6jkAL0OArU656V ebcL7WNg3tE+9hm8SG6e0uD7gg== X-Google-Smtp-Source: ABdhPJy05T1NPkkQXB9EoKTWk0BgQA2YbcX/Rl20SMQs0NEdv0PPCLfiCzrohW58ne4IcabfxTDOIA== X-Received: by 2002:a4a:420d:: with SMTP id h13mr1638857ooj.24.1615517371923; Thu, 11 Mar 2021 18:49:31 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id 64sm1102682otu.80.2021.03.11.18.49.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Mar 2021 18:49:31 -0800 (PST) Date: Thu, 11 Mar 2021 20:49:29 -0600 From: Bjorn Andersson To: Douglas Anderson Subject: Re: [PATCH 1/3] drm/bridge: ti-sn65dsi86: Simplify refclk handling Message-ID: References: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210304155144.1.Ic9c04f960190faad5290738b2a35d73661862735@changeid> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: robdclark@chromium.org, Jernej Skrabec , Jonas Karlman , David Airlie , linux-arm-msm@vger.kernel.org, Neil Armstrong , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , Andrzej Hajda , Laurent Pinchart , Sam Ravnborg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu 04 Mar 17:51 CST 2021, Douglas Anderson wrote: > The clock framework makes it simple to deal with an optional clock. > You can call clk_get_optional() and if the clock isn't specified it'll > just return NULL without complaint. It's valid to pass NULL to > enable/disable/prepare/unprepare. Let's make use of this to simplify > things a tiny bit. > > NOTE: this makes things look a tad bit asymmetric now since we check > for NULL before clk_prepare_enable() but not for > clk_disable_unprepare(). This seemed OK to me. We already have to > check for NULL in the enable case anyway so why not avoid the extra > call? > Reviewed-by: Bjorn Andersson > Signed-off-by: Douglas Anderson > --- > > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > index f27306c51e4d..942019842ff4 100644 > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c > @@ -1261,14 +1261,9 @@ static int ti_sn_bridge_probe(struct i2c_client *client, > return ret; > } > > - pdata->refclk = devm_clk_get(pdata->dev, "refclk"); > - if (IS_ERR(pdata->refclk)) { > - ret = PTR_ERR(pdata->refclk); > - if (ret == -EPROBE_DEFER) > - return ret; > - DRM_DEBUG_KMS("refclk not found\n"); > - pdata->refclk = NULL; > - } > + pdata->refclk = devm_clk_get_optional(pdata->dev, "refclk"); > + if (IS_ERR(pdata->refclk)) > + return PTR_ERR(pdata->refclk); > > ret = ti_sn_bridge_parse_dsi_host(pdata); > if (ret) > -- > 2.30.1.766.gb4fecdf3b7-goog > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel