From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Guenter Roeck <linux@roeck-us.net>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Kyle Tso <kyletso@google.com>
Subject: Re: [PATCH v2 1/2] usb: typec: tcpci: Add tcpc chip level callbacks
Date: Fri, 12 Mar 2021 07:34:42 +0100 [thread overview]
Message-ID: <YEsLgogC66Fzx7Vk@kroah.com> (raw)
In-Reply-To: <YEsLSevhzYja0fwk@kroah.com>
On Fri, Mar 12, 2021 at 07:33:45AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 11, 2021 at 09:24:42PM -0800, Badhri Jagan Sridharan wrote:
> > This change adds chip callbacks for the following operations:
> > 1. Notifying port role
> > 2. Notifying orientation
>
> This should be 2 different patches, one per callback, right?
>
> And where is the code using these callbacks? We can't add any hooks
> without in-tree users, as you know.
Ah, your second patch added that, sorry, missed it.
This should be a 4 patch series, remember, only do one thing per patch.
thanks,
greg k-h
next prev parent reply other threads:[~2021-03-12 6:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-12 5:24 [PATCH v2 1/2] usb: typec: tcpci: Add tcpc chip level callbacks Badhri Jagan Sridharan
2021-03-12 5:24 ` [PATCH v2 2/2] usb: typec: tcpci_maxim: configure charging & data paths Badhri Jagan Sridharan
2021-03-12 6:39 ` Guenter Roeck
2021-03-12 7:04 ` Badhri Jagan Sridharan
2021-03-12 9:01 ` Heikki Krogerus
2021-03-12 6:33 ` [PATCH v2 1/2] usb: typec: tcpci: Add tcpc chip level callbacks Greg Kroah-Hartman
2021-03-12 6:34 ` Greg Kroah-Hartman [this message]
2021-03-12 7:06 ` Badhri Jagan Sridharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YEsLgogC66Fzx7Vk@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=kyletso@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.