All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Bartosz Golaszewski <brgl@bgdev.pl>
Cc: "Joel Becker" <jlbec@evilplan.org>,
	"Christoph Hellwig" <hch@lst.de>, "Shuah Khan" <shuah@kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Geert Uytterhoeven" <geert@linux-m68k.org>,
	"Kent Gibson" <warthog618@gmail.com>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
	linux-doc <linux-doc@vger.kernel.org>,
	"Bartosz Golaszewski" <bgolaszewski@baylibre.com>
Subject: Re: [PATCH v3 08/11] gpio: sim: new testing module
Date: Fri, 12 Mar 2021 13:03:51 +0200	[thread overview]
Message-ID: <YEtKlyV13h2fbwJR@smile.fi.intel.com> (raw)
In-Reply-To: <CAMRc=MfeCWNnXwqBBu3CcdHXQ5QnNPBh8EJRTCtyZau+RqE-0w@mail.gmail.com>

On Fri, Mar 12, 2021 at 09:54:58AM +0100, Bartosz Golaszewski wrote:
> On Wed, Mar 10, 2021 at 1:28 PM Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:

...

> > > +             ret = sprintf(page, "n/a\n");
> >
> > I dunno '/' (slash) is a good character to be handled in a shell.
> > I would prefer 'none' or 'not available' (I think space is easier,
> > because the rules to escape much simpler: need just to take it into
> > quotes, while / needs to be escaped separately).
> >
> 
> My test cases work fine with 'n/a' but I can change it to 'none' if
> it's less controversial.


% git grep -n -w '"none"' -- drivers/ arch/ | wc -l
371

% git grep -n -w '"n/a"' -- drivers/ arch/ | wc -l
15

% git grep -n -w '"not available"' -- drivers/ arch/ | wc -l
5

...

> But I would be creating empty properties for nothing. Better to just
> not have them at all.

Up to you.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2021-03-12 11:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-09 20:59 [PATCH v3 00/11] gpio: implement the configfs testing module Bartosz Golaszewski
2021-03-09 20:59 ` [PATCH v3 01/11] configfs: increase the item name length Bartosz Golaszewski
2021-03-09 20:59 ` [PATCH v3 02/11] configfs: use (1UL << bit) for internal flags Bartosz Golaszewski
2021-03-09 20:59 ` [PATCH v3 03/11] configfs: implement committable items Bartosz Golaszewski
2021-03-09 20:59 ` [PATCH v3 04/11] samples: configfs: add a committable group Bartosz Golaszewski
2021-03-09 20:59 ` [PATCH v3 05/11] lib: bitmap: remove the 'extern' keyword from function declarations Bartosz Golaszewski
2021-03-09 20:59 ` [PATCH v3 06/11] lib: bitmap: order includes alphabetically Bartosz Golaszewski
2021-03-09 20:59 ` [PATCH v3 07/11] lib: bitmap: provide devm_bitmap_alloc() and devm_bitmap_zalloc() Bartosz Golaszewski
2021-03-10  9:48   ` Greg Kroah-Hartman
2021-03-09 20:59 ` [PATCH v3 08/11] gpio: sim: new testing module Bartosz Golaszewski
2021-03-10 12:28   ` Andy Shevchenko
2021-03-12  8:54     ` Bartosz Golaszewski
2021-03-12 11:03       ` Andy Shevchenko [this message]
2021-03-11  0:07   ` Linus Walleij
2021-03-09 20:59 ` [PATCH v3 09/11] selftests: gpio: provide a helper for reading chip info Bartosz Golaszewski
2021-03-09 20:59 ` [PATCH v3 10/11] selftests: gpio: add a helper for reading GPIO line names Bartosz Golaszewski
2021-03-09 20:59 ` [PATCH v3 11/11] selftests: gpio: add test cases for gpio-sim Bartosz Golaszewski
2021-03-10  9:51 ` [PATCH v3 00/11] gpio: implement the configfs testing module Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YEtKlyV13h2fbwJR@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=brgl@bgdev.pl \
    --cc=corbet@lwn.net \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hch@lst.de \
    --cc=jlbec@evilplan.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=warthog618@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.