From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F54DC433E0 for ; Thu, 25 Mar 2021 23:56:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68F20619F7 for ; Thu, 25 Mar 2021 23:56:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229642AbhCYXzy (ORCPT ); Thu, 25 Mar 2021 19:55:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60786 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbhCYXzu (ORCPT ); Thu, 25 Mar 2021 19:55:50 -0400 Received: from mail-qv1-xf36.google.com (mail-qv1-xf36.google.com [IPv6:2607:f8b0:4864:20::f36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4AFFEC06174A; Thu, 25 Mar 2021 16:55:50 -0700 (PDT) Received: by mail-qv1-xf36.google.com with SMTP id g8so2140554qvx.1; Thu, 25 Mar 2021 16:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=5MP2PxgWADvsrOSFuhaJ2os8rXXykLrd3KRlQltq1ac=; b=EJpGYQqtkzRc7/ZE31DqfVIOvVZo+9Shgs87OK2lo3dYCjM4WuGA50NaUFsYweAgiQ Ip3xa9ZiJTccaXMsjtfwil5haZKLMWCb4mKPuKI9Fn9kgRmaSpgccrpB6BU/4xS5nn7a W3nad+6zL556grdY3wKbEnvhcRkStPI5YnT5mcmKhlHQRll6V3A8xmErT1Y/FKIPou+j 6CdP6jkUiyLlBZ0b2kbH4iQpYTulog7WbwhlBBTdpJ5wUKuQY/baGtr5Sb5zvdSRjUzq YYgjsWZl1rbMDuWwFFPOtoMO/NVsMq5UW97cC2Ly+fwJYzcY0MUJ/33zqndeMyQVv5RC QR5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=5MP2PxgWADvsrOSFuhaJ2os8rXXykLrd3KRlQltq1ac=; b=M/Dvqs4nv+14xAkl6PhfIWdAROmEHDi9PXjkVVVJmFQHpezMBE8WeXLE43wn3dBPhZ 62piFHY1yd+8WWbc9C8GE+elUnDN5KWwuVsq1aPlYX6XVr6GhqAn1nwq49vJEgnkECa9 550m70uCfgdyaMeOkkKzA5wDoCofNeTV6Tt/JjZw/vDIKjx+yWuxSgBLIeWLfOjJXWFW 88zwDpOJ6dsgzdQaXQth/NtIiyviyMDxkFQ42GNjOOGf8M7q6RCM1yg1syoxk1TjKZkc IeyDRdZF4nkbqT2L8oRsOD8Ngtugbbsk7AVe+MPBrKMRU4A6oKscFNyu/Q0e4eo8jgwX gl9A== X-Gm-Message-State: AOAM532qtzxXgXKoeSQVKrwELJas0LoTShMJx/urbBlfgJfyRYu3Rg1i s+LC4fsb+Mizs/lTUrKbwes= X-Google-Smtp-Source: ABdhPJzHSKL2A1TZdO599D/nZqn+iirp77Riai+iU1fQFlmpVHptvk5ER85WcWh8BwlraLKaLDK5DA== X-Received: by 2002:ad4:510d:: with SMTP id g13mr11104362qvp.3.1616716549388; Thu, 25 Mar 2021 16:55:49 -0700 (PDT) Received: from Gentoo ([37.19.198.107]) by smtp.gmail.com with ESMTPSA id n77sm5463757qkn.128.2021.03.25.16.55.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Mar 2021 16:55:48 -0700 (PDT) Date: Fri, 26 Mar 2021 05:25:39 +0530 From: Bhaskar Chowdhury To: dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, rdunlap@infradead.org Subject: Re: [PATCH] btrfs: fixed rudimentary typos Message-ID: Mail-Followup-To: Bhaskar Chowdhury , dsterba@suse.cz, clm@fb.com, josef@toxicpanda.com, dsterba@suse.com, linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, rdunlap@infradead.org References: <20210325042113.12484-1-unixbhaskar@gmail.com> <20210325124954.GL7604@twin.jikos.cz> <20210325214704.GM7604@twin.jikos.cz> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="M5A017CyFTkYggv5" Content-Disposition: inline In-Reply-To: <20210325214704.GM7604@twin.jikos.cz> Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org --M5A017CyFTkYggv5 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On 22:47 Thu 25 Mar 2021, David Sterba wrote: >On Thu, Mar 25, 2021 at 11:40:04PM +0530, Bhaskar Chowdhury wrote: >> On 13:49 Thu 25 Mar 2021, David Sterba wrote: >> >On Thu, Mar 25, 2021 at 09:51:13AM +0530, Bhaskar Chowdhury wrote: >> >> >> >> s/contaning/containing >> >> s/clearning/clearing/ >> > >> >Have hou scanned the whole subdirectory for typos? We do typo fixing >> >about once a year in one big patch and won't fix them one by one. >> >> Once a year???? You must be kidding! that is not good whatever the workflow >> you have . > >No kidding. It's even worse, we get that every two years. > >* 2016 0132761017e012ab4dc8584d679503f2ba26ca86 > 33 files changed, 106 insertions(+), 105 deletions(-) > >* 2018 52042d8e82ff50d40e76a275ac0b97aa663328b0 > 25 files changed, 70 insertions(+), 69 deletions(-) > >You can see the diffstat touches nearly all the files, almost hundred of >fixed typos per patch. Now compare that to sending 70-100 individual >patches. Time spent on any patch is not zero and for such trivial >changes it's not justified so the workflow is to do that in batches. >If you care about fixing typos in fs/btrfs/, please fix them all. I've >found about 50. I certainly do , not only for btrfs but for the whole kernel, it might sound ridiculous , but someone has to bell the cat , right? If I get little cooperation from everyone , we can pull it through, it would be good for the future generation. --M5A017CyFTkYggv5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEnwF+nWawchZUPOuwsjqdtxFLKRUFAmBdIvgACgkQsjqdtxFL KRVLHgf9FL2CWA78IL6FlhJRhO3nGm4RlSegdJCW63FUhBlECEXeHc2GosYi52FU DnIHElBn1Mt5uM4eeP6zgg2/i7i3qe/3lTJZjXo55mRulS/zZC3W5bX99rgcCW92 dfinWgqBAjURS7qrBZFX6ScyU6oFTusIvZA03khmS/qZnEdyObmilJm3Ik1vKV1E P/YF3Fpb6d9kKVPoIdXE3aKWEKP5yB6DGOErWjwZ+/vdou9uVnW3DXdozJ0Z/JeP yodc+87BJa+X0u8xfk2FOw7/9dX5BEmIhLMvz/VNcf0wLr4+ShvxyrO5PDojCg3L 0hqqntTNzBUTcDCql+beISSRoIpDKw== =ABQC -----END PGP SIGNATURE----- --M5A017CyFTkYggv5--